Federated_Computer/federated-calendar
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
3,644 Commits 3 Branches 0 Tags
8b251d5a987986cf9aa55e383d4785dffb0fa22b
Commit Graph
3644 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Dan Levin 8b251d5a98 reminders-section: Introduce 15 minute reminder 
10 minute reminder is too little advanced notice. 30 minutes is too
much. Say hello to 15 minute reminder.
 2020-11-02 17:05:31 +01:00
Georges Basile Stavracas Neto a146b9050d project: Silence CI warnings 2020-10-31 16:55:06 -03:00
Georges Basile Stavracas Neto 06f0c4d011 schedule-section: Make date & time labels dim 
They should have been dim labels since the beginning, this was an
oversight.
 2020-10-31 16:15:54 -03:00
Georges Basile Stavracas Neto b481b40381 schedule-section: Mark date & time labels as action children 
Otherwise they appear inside the expanded section, and not outside like
we wanted. This was a regression from the libhandy 1.0 port.
 2020-10-31 16:15:54 -03:00
Georges Basile Stavracas Neto b725d25b86 schedule-section: Remove useless labels 
They're placeholders, and always overriden. Remove them.
 2020-10-31 16:15:54 -03:00
Georges Basile Stavracas Neto 968ae16e08 window: Use leaf type for GcalEventEditorDialog 
We're casting either way, to at least let's cast to something
that requires fewer characters.
 2020-10-31 16:15:54 -03:00
Georges Basile Stavracas Neto 4c24103bae event-editor-dialog: Make 'event' property read-only 
It is not meant to be set externally.
 2020-10-31 16:15:54 -03:00
Georges Basile Stavracas Neto b0cdca78b1 event-editor-dialog: Unify set_event and set_event_is_new 
The split is annoying, and a relic of time.
 2020-10-31 16:15:54 -03:00
Georges Basile Stavracas Neto 7e10c6d451 event-editor-dialog: Stop using response type 
Using dialog responses to communicate intent to GcalWindow was always
a hack, and as the code is cleaned, it's getting increasingly annoying.

Replace this with a proper 'remove-event' signal ('delete-event' would
conflict with the equally named GTK signal), remove the custom response
types, and cleanup the code.
 2020-10-31 16:15:54 -03:00
Georges Basile Stavracas Neto 1480d7ac70 event-editor-dialog: Code cleanup 
Use g_autofoo when possible; avoid allocating new strings when fetching
from GVariant; sort and reorder fields.
 2020-10-31 16:15:54 -03:00
Georges Basile Stavracas Neto c098dc7aa7 event-editor-dialog: Store sections in an array 
It allows us to simplify some boring copy-pasted code.
 2020-10-31 16:15:54 -03:00
Georges Basile Stavracas Neto 3a9f9009a4 event-editor-dialog: Remove dead code 
These weren't being used anywhere.
 2020-10-31 16:15:54 -03:00
Georges Basile Stavracas Neto 0f1dc88030 event-editor-dialog: Move notes to GcalNotesSection 2020-10-31 16:15:49 -03:00
Georges Basile Stavracas Neto 73cbe1f39c event-editor-dialog: Move summary to GcalSummarySection 2020-10-31 13:30:56 -03:00
Georges Basile Stavracas Neto 46aee00f65 event-editor-dialog: More schedule to GcalScheduleSection 2020-10-31 13:30:56 -03:00
Georges Basile Stavracas Neto 997f6bb671 event-editor-dialog: Move reminders to GcalRemindersSection 
Move all widgetry, logic, and setup to GcalReminderSection.
 2020-10-31 13:30:56 -03:00
Georges Basile Stavracas Neto a839a0d860 Introduce GcalEventEditorSection 
This is the interface to represent sections of the event editor
dialog.
 2020-10-31 13:30:56 -03:00
Georges Basile Stavracas Neto f9c466a1be event-editor-dialog: Notify context when setting property 
The 'context' property is set a explicit notify property, meaning we have
to manually notify it when setting it.
 2020-10-31 13:30:56 -03:00
Georges Basile Stavracas Neto b4029b0c23 edit-dialog: Rename to GcalEventEditorDialog 2020-10-31 13:30:56 -03:00
Georges Basile Stavracas Neto c73dc191db project: Move GcalEditDialog and friends to src/gui/event-editor/ 2020-10-30 15:13:35 -03:00
Georges Basile Stavracas Neto e67ebcfc50 project: Move all UI-related files to src/gui/ 
So we can have a nice separation.
 2020-10-30 14:44:33 -03:00
Georges Basile Stavracas Neto 92863f578f project: Split GResource files in subdirs 2020-10-30 14:17:40 -03:00
Georges Basile Stavracas Neto 87ce5e6d49 project: Move css-code.h to src/gui/ 
It is only used there.
 2020-10-30 13:47:38 -03:00
Georges Basile Stavracas Neto eb954505e4 project: Split meson files in subdirs 
It allows us to better control what each subdir does, etc. This is
only the first step; we want to also split GResources, etc.
 2020-10-30 13:45:50 -03:00
Michael Catanzaro 9ac1528e54 gcal-timeline: completed_calendars should be unsigned 
In on_calendar_monitor_completed_cb() we have this assert:

g_assert (self->completed_calendars <= g_hash_table_size (self->calendars));

That is comparing a signed integer to unsigned. This is dangerous. We
could add casts to say that we really want to do it, but
completed_calendars should never be negative, so might as well use
unsigned.
 2020-10-14 09:14:34 -05:00
Michael Catanzaro c2c89b667e gcal-timeline: never reset completed_calendars 
Since 78cb11c64d, GcalCalendarMonitor now
notifies when a completed calendar transitions to incomplete, and
GcalTimeline decrements its completed_calendars counter. But we forgot
to remove the code that resets completed_calendars when previously
needed. That's not required anymore, because we can trust
GcalCalendarMonitor to do the right thing.

In my case, I have 5 calendars enabled and 6 total. When starting
gnome-calendar, all 5 are successively completed, and
completed_calendars increments from 0 -> 1 -> 2 -> 3 -> 4 -> 5. Then,
when transitioning month view from January 2020 to December 2019, we
call reset_completed_calendars() and completed_calenders gets clobbered
to 0. Then it decrements from 0 -> -1 -> -2 -> -3 -> -4 -> -5 as the
GcalCalendarMonitors notify that they are no longer completed. Well,
that is what would happen, if it didn't crash when decrementing to -1.
We assert -1 <= 6 (the total number of calendars) and crash because -1
gets promoted to a huge unsigned int, since we're comparing signed to
unsigned. (That crash would have been avoided if we used
-Wsign-compare, although that warning would not have caught the logic
problem.)

Anyway, since GcalMonitor now notifies when calendars are no longer
complete, it is safe to simply remove reset_completed_calendars().
GcalTimeline will still notify if it needs to change its own complete
property (in on_calendar_monitor_completed_cb).

Fixes #567
Fixes #636
Fixes #638
Fixes #647
Fixes #650
 2020-10-14 09:13:12 -05:00
Juliano de Souza Camargo f18d4121bf Update Portuguese translation 
(cherry picked from commit a1fc5459ba6a1d9840b80385153559c7d2b5f1dc)
 2020-10-11 14:27:13 +00:00
Felix Eckhofer 2452ea07fb docs: Fix file name in HACKING guide 2020-09-28 12:01:32 +00:00
Stephan Woidowski caef9f96d9 Update British English translation 
(cherry picked from commit 75866ff912c0546a7ce6186e14390870f2a63f00)
 2020-09-27 12:22:44 +00:00
Asier Sarasua Garmendia f3d57d288a Update Basque translation 
(cherry picked from commit 00934401426887b3af5e514c2416e1baeba670e4)
 2020-09-19 07:23:24 +00:00
Cheng-Chia Tseng 8c959769f3 Update Chinese (Taiwan) translation 
(cherry picked from commit 6547bc6137ecadb6f35cb468179612822bf1a3fc)
 2020-09-17 13:59:12 +00:00
Juliano de Souza Camargo 5d087b0629 Update Portuguese translation 
(cherry picked from commit e1bd1a4c4056394bdd0573284304e52accec5981)
 2020-09-16 17:54:15 +00:00
Evangelos Ribeiro Tzaras ac46671334 window: Switch to HdyHeaderBar 
Change the headerbar to HdyHeaderBar
 2020-09-16 15:24:46 +00:00
Evangelos Ribeiro Tzaras 402ad34f42 window: Inherit from HdyApplicationWindow 
This commit makes the toplevel GcalWindow inherit from
HdyApplicationWindow instead of GtkApplicationWindow.
 2020-09-16 15:24:46 +00:00
Evangelos Ribeiro Tzaras 8be361b6ce project: Switch to libhandy-1 
This commit updates the dependencies for libhandy to the tagged 1.0
release and changes the code to accomodate the changes from
libhandy-0 to libhandy-1.

Notable changes:
edit-dialog: HdyDialog has been dropped in [1]
alarm-row: action child type in HdyActionRow has been removed.

[1] https://gitlab.gnome.org/GNOME/libhandy/-/merge_requests/434
 2020-09-16 15:24:46 +00:00
Evangelos Ribeiro Tzaras 2d5b1aa9d1 project: Cleanup code for unused views 
Got rid of the unused views in the GcalWindowView enum
and associated code in gcal-window.
 2020-09-16 15:24:46 +00:00
Georges Basile Stavracas Neto 28be1e858d build: Use meson summary instead of hardocded string 2020-09-16 10:28:33 -03:00
Georges Basile Stavracas Neto 5d858f1905 40.alpha 2020-09-16 10:28:32 -03:00
Stephan Woidowski f01add78da Update German translation 
(cherry picked from commit a213cf4336e4abe30bd40c911c87dc6f85e12807)
 2020-09-16 04:48:10 +00:00
Rūdolfs Mazurs 38c43e93a1 Update Latvian translation 
(cherry picked from commit c242d23805b72dd80f14f43c133dad3ef66e7b44)
 2020-09-15 18:12:07 +00:00
Dušan Kazik 8bc34da8d3 Update Slovak translation 
(cherry picked from commit 98a1c92984fb89024c71e2c6b2ad2725fe3fd1e1)
 2020-09-15 16:20:58 +00:00
Marek Černocký d473f9927d Updated Czech translation 2020-09-15 07:25:03 +02:00
Jordi Mas 635af58287 Update Catalan translation 2020-09-14 21:56:41 +02:00
Goran Vidović e897062474 Update Croatian translation 
(cherry picked from commit 0b168d7b4f63746385fea6d6cbb428a657991c1e)
 2020-09-13 18:22:05 +00:00
Jiri Grönroos 052f7a03f3 Update Finnish translation 
(cherry picked from commit 95f87811076294e74f4078bf7661eae2cb31e700)
 2020-09-13 18:19:48 +00:00
Aurimas Černius 5dad89f45e Updated Lithuanian translation 2020-09-13 20:02:28 +03:00
Milo Casagrande 8e97d865c8 Update Italian translation 
(cherry picked from commit 284ea04078b11a101c7511159b64d7ea95f053ad)
 2020-09-13 12:31:27 +00:00
Kukuh Syafaat b8d37769b7 Update Indonesian translation 
(cherry picked from commit 315b44602310b94a8f18427ba6a8ab01f8f86f09)
 2020-09-13 08:06:17 +00:00
Марко Костић 130de5ff4e Update Serbian translation 
(cherry picked from commit 8d934d0f7dc29a22b0be60a17d918a12761fd0c0)
 2020-09-13 07:35:59 +00:00
Henrique Machado Campos 689b197966 Update Brazilian Portuguese translation 
(cherry picked from commit a7bb9c4ade7a422e8b0fbd76d2adbd7cc851b28b)
 2020-09-13 06:35:52 +00:00