views/agenda: Cleanup unused Week View (!!!)
This is to show how much I suck at reviewing code. Look at this massive gold nugget of garbage. Nobody on their serious mind would have let that pass code review. But I did. And now I deserve the punishment to deal with this. Of course, the author didn't seem to have spared more than a fraction of a second of their brain power to even consider what they were doing here. But that's what code review is for - preventing garbage like this from landing. And yet, here we are, removing an invisible Week view from the sidebar.
This commit is contained in:
@@ -193,13 +193,6 @@ new_date_header_string (GDateTime *date)
|
||||
* Callbacks
|
||||
*/
|
||||
|
||||
static void
|
||||
on_event_activated (GcalAgendaView *self,
|
||||
GtkWidget *widget)
|
||||
{
|
||||
g_signal_emit_by_name (self, "event-activated", widget);
|
||||
}
|
||||
|
||||
static void
|
||||
stack_visible_child_changed_cb (AdwViewStack *stack,
|
||||
GParamSpec *pspec,
|
||||
@@ -726,8 +719,6 @@ gcal_agenda_view_class_init (GcalAgendaViewClass *klass)
|
||||
gtk_widget_class_bind_template_child (widget_class, GcalAgendaView, no_events_row);
|
||||
gtk_widget_class_bind_template_child (widget_class, GcalAgendaView, scrolled_window);
|
||||
|
||||
gtk_widget_class_bind_template_callback (widget_class, on_event_activated);
|
||||
|
||||
gtk_widget_class_set_css_name (widget_class, "agenda-view");
|
||||
}
|
||||
|
||||
|
||||
@@ -2,23 +2,6 @@
|
||||
<interface>
|
||||
<template class="GcalAgendaView" parent="GtkBox">
|
||||
<property name="orientation">vertical</property>
|
||||
<style>
|
||||
<class name="week-view" />
|
||||
</style>
|
||||
<child>
|
||||
<object class="GcalWeekHeader" id="header">
|
||||
<property name="visible">False</property>
|
||||
<signal name="event-activated" handler="on_event_activated" object="GcalAgendaView" swapped="yes" />
|
||||
</object>
|
||||
</child>
|
||||
<child>
|
||||
<object class="GcalWeekGrid" id="week_grid">
|
||||
<property name="visible">False</property>
|
||||
<property name="hexpand">True</property>
|
||||
<property name="vexpand">True</property>
|
||||
<signal name="event-activated" handler="on_event_activated" object="GcalAgendaView" swapped="yes" />
|
||||
</object>
|
||||
</child>
|
||||
<child>
|
||||
<object class="GtkScrolledWindow" id="scrolled_window">
|
||||
<property name="hexpand">True</property>
|
||||
|
||||
Reference in New Issue
Block a user