From e13eb17816ac881d9b68611f6681cb27988882a4 Mon Sep 17 00:00:00 2001 From: Georges Basile Stavracas Neto Date: Thu, 2 Mar 2023 21:45:13 -0300 Subject: [PATCH] views/agenda: Cleanup unused Week View (!!!) This is to show how much I suck at reviewing code. Look at this massive gold nugget of garbage. Nobody on their serious mind would have let that pass code review. But I did. And now I deserve the punishment to deal with this. Of course, the author didn't seem to have spared more than a fraction of a second of their brain power to even consider what they were doing here. But that's what code review is for - preventing garbage like this from landing. And yet, here we are, removing an invisible Week view from the sidebar. --- src/gui/views/gcal-agenda-view.c | 9 --------- src/gui/views/gcal-agenda-view.ui | 17 ----------------- 2 files changed, 26 deletions(-) diff --git a/src/gui/views/gcal-agenda-view.c b/src/gui/views/gcal-agenda-view.c index bd8cde73..53ccc3ac 100644 --- a/src/gui/views/gcal-agenda-view.c +++ b/src/gui/views/gcal-agenda-view.c @@ -193,13 +193,6 @@ new_date_header_string (GDateTime *date) * Callbacks */ -static void -on_event_activated (GcalAgendaView *self, - GtkWidget *widget) -{ - g_signal_emit_by_name (self, "event-activated", widget); -} - static void stack_visible_child_changed_cb (AdwViewStack *stack, GParamSpec *pspec, @@ -726,8 +719,6 @@ gcal_agenda_view_class_init (GcalAgendaViewClass *klass) gtk_widget_class_bind_template_child (widget_class, GcalAgendaView, no_events_row); gtk_widget_class_bind_template_child (widget_class, GcalAgendaView, scrolled_window); - gtk_widget_class_bind_template_callback (widget_class, on_event_activated); - gtk_widget_class_set_css_name (widget_class, "agenda-view"); } diff --git a/src/gui/views/gcal-agenda-view.ui b/src/gui/views/gcal-agenda-view.ui index 08f27a9e..1c8d8f21 100644 --- a/src/gui/views/gcal-agenda-view.ui +++ b/src/gui/views/gcal-agenda-view.ui @@ -2,23 +2,6 @@