Commit Graph
3307 Commits
Author SHA1 Message Date
Georges Basile Stavracas Neto f0060b7699 new-calendar-page: Use the new discoverer
The new discoverer is a vast improvement over the code
that use used to have here. Right now, we fail to use
Soup to detect the URL, and that's been reported multiple
times already.

Use the new web discoverer code, and adjust the UI to
match the new code. Namely, use a GtkPopover to show
the credentials widget.

Fixes #380
2019-07-13 16:04:31 -03:00
Georges Basile Stavracas Neto ff0644ad76 utils: Add auxiliary function to format display names
This will be used by the web source discoverer to format
any URLs that contain a file name in their path.
2019-07-13 16:04:31 -03:00
Georges Basile Stavracas Neto 371fdbc881 Introduce new source discoverer
The new source discoverer is a complete overhaul of
the current code. It is async-only, correctly threaded,
and easier to maintain.

A major new feature of this web source discoverer is
that it now pings the server to see if the URL feeds
us back with an iCalendar file.

Furthermore, it continues to use E-D-S WebDAV discovery
functions as a fallback mechanism.

Fixes #380
2019-07-13 16:04:30 -03:00
Georges Basile Stavracas Neto 2aa9bc1f61 tests: Add calendar server and tests
This will be used to write a propert test suite
for the new calendar discoverer code.
2019-07-13 16:04:30 -03:00
Georges Basile Stavracas Neto 54690e285a build: Improve test generation 2019-07-13 16:04:30 -03:00
Ömer Fadıl USTA 2e5067d75c Bump meson version to 0.50.0 2019-07-10 11:18:17 +03:00
Michael Catanzaro 34c062a7fa Fix crash in update_default_calendar_row()
It's wrong to call set_row() with NULL row.

Fixes #422
2019-07-10 01:01:42 +00:00
Michael Catanzaro 621d69e0bc utils: Use setlocale() in is_workday()
Trying to use environment variables to guess the locale was a good
attempt, but this is tricky because they have to be looked up in a
certain order: first LC_ALL, then fallback to LC_TIME, and finally LANG,
which was missed here. This caused a huge warning spam on the year view
when only LANG is set, and usually only LANG should be set since the
other environment variables are usually used for temporary overrides.
Instead, query the locale using setlocale().

Also, don't assert if the locale is shorter than expected (missing
territory code) since there is at least one valid locale that does not
have any territory codes (Esperanto) and since it's programmer error to
assert when the application processes unexpected input like this.

Fixes #424
2019-07-09 21:52:56 -03:00
Michael Catanzaro 223ed62034 weather-service: Fix buffer overflow in get_icon_name_sortkey()
We can just use strlen() here.

Fixes #425
2019-07-09 21:48:11 -03:00
Georges Basile Stavracas Neto 02a5eca945 weather-service: Reorganize file 2019-07-09 21:47:14 -03:00
Michael Catanzaro 04053dbf47 weather-service: Properly disconnect from GWeatherInfo
We fail to disconnect from the GWeatherInfo in both update_location()
and dispose. We have to fix update_location() manually. To avoid the
need to disconnect in dispose, we can just use g_signal_connect_object().
2019-07-09 21:26:22 -03:00
Georges Basile Stavracas Neto 8a98c697c4 week-header: Trivial style cleanup 2019-07-09 21:24:58 -03:00
Georges Basile Stavracas Neto c62bb2eb95 flatpak: Reorder some sources
Small cosmetic change.
2019-07-09 21:24:58 -03:00
Michael Catanzaro 3ed9669c6e week-header: Remove internal weather service
self->weather_service was only partially removed in 01fdf79e6a,
leading to a guaranteed crash when the weather is updated because
self->weather_service is now always NULL.

Fixes #397
2019-07-09 21:14:23 -03:00
Efstathios Iosifidis 6e61bb6a2e Update Greek translation 2019-07-08 19:27:04 +00:00
Kukuh Syafaat cbf3e433a5 Update Indonesian translation 2019-07-08 09:03:41 +00:00
Sveinn í Felli dee3627170 Update Icelandic translation
(cherry picked from commit 983a2560573679e351174b7b00458f578071ba2a)
2019-07-06 07:33:38 +00:00
Fabio Tomat 008055bf79 Update Friulian translation 2019-06-30 14:22:34 +00:00
Georges Basile Stavracas Neto 0b4119367a month-view: Use last cell to calculate multday event end
Instead of assuming all cells have the same width, use the last
cell to figure out the width of the event with the traditional:

    event width = end.x2 - start.x1
    event width = (end.x1 + end.width) - start.x1

https://gitlab.gnome.org/GNOME/gnome-calendar/issues/413
2019-06-26 11:04:39 -03:00
Rafael Fontenelle c1653f1889 Update Brazilian Portuguese translation 2019-06-26 09:33:23 +00:00
Daniel Mustieles 88121f5bec Updated Spanish translation 2019-06-26 11:01:05 +02:00
Piotr Drąg f486f7629d Update POTFILES.in 2019-06-25 19:39:22 +02:00
Georges Basile Stavracas Neto 33fc75ca01 calendar-management-page: Pass GcalCalendar 2019-06-25 14:16:47 -03:00
Georges Basile Stavracas Neto 47bed7bc77 new-calendar-page: Restore opening Online Accounts panel from label 2019-06-25 12:51:14 -03:00
Georges Basile Stavracas Neto a95097f594 calendar-management-dialog: Remove unused signal handler 2019-06-25 12:50:48 -03:00
Georges Basile Stavracas Neto 4a7536328e new-calendar-page: Add more file filters 2019-06-25 11:42:11 -03:00
Georges Basile Stavracas Neto fcfa403902 new-calendar-page: Reenable file filter
We were blocked on a GtkBuilder issue [1].

[1] https://gitlab.gnome.org/GNOME/gtk/issues/1973
2019-06-25 11:39:06 -03:00
Georges Basile Stavracas Neto 0f28e3fa53 new-calendar-page: Implement new designs
This looks soooooo much better =)

https://gitlab.gnome.org/GNOME/gnome-calendar/issues/388
2019-06-24 21:33:00 -03:00
Georges Basile Stavracas Neto 7da3197186 calendars-page: Remove previously deleted calendar if any
It is possible to delete a calendar, and immediately delete another.
When that happens, both should be deleted.
2019-06-24 21:33:00 -03:00
Georges Basile Stavracas Neto 39ebc5457a calendars-page: Fix callback parameters 2019-06-24 21:33:00 -03:00
Georges Basile Stavracas Neto e53a7532f2 calendars-page: Use the passed calendar for deletion 2019-06-24 21:33:00 -03:00
Georges Basile Stavracas Neto 78680d9b5b search-engine: Fix wrong debug message 2019-06-24 21:32:59 -03:00
Georges Basile Stavracas Neto 10e10f6605 edit-calendar-page: Silence warning 2019-06-24 21:32:59 -03:00
Georges Basile Stavracas Neto 170347b016 calendar-management-dialog: Trivial style cleanup 2019-06-24 21:32:59 -03:00
Georges Basile Stavracas Neto efa29b19d5 calendars-page: Use switch to toggle visibility 2019-06-24 21:32:59 -03:00
Georges Basile Stavracas Neto c092445363 calendar-management: Shuffle code around and cleanup 2019-06-24 21:32:59 -03:00
Georges Basile Stavracas Neto f7df717e1b edit-calendar-page: Add back button
And remove the remaining code (and a few extras) from the
calendar management dialog.
2019-06-24 21:32:59 -03:00
Georges Basile Stavracas Neto a2d15697d9 log: Increase prefix width
GcalCalendarManagementDialog is too wide and breaks the log
layout, so increase the spacing to fit it.
2019-06-24 21:32:58 -03:00
Georges Basile Stavracas Neto 5e9f7bf01e new-calendar-page: Add "Cancel" and "Add" header buttons 2019-06-24 21:32:58 -03:00
Georges Basile Stavracas Neto 804479ebcc calendar-management-page: Add helper to retrieve titlebar 2019-06-24 21:32:58 -03:00
Georges Basile Stavracas Neto e49ed1ed67 calendar-management: Move code to GcalNewCalendarPage 2019-06-24 21:32:58 -03:00
Georges Basile Stavracas Neto 9cc07c5786 calendar-management: Introduce GcalEditCalendarPage
This is the second of the three original pages we used to have.
This one edits calendars.
2019-06-24 21:32:58 -03:00
Georges Basile Stavracas Neto db4613ae71 new-calendar-page: Add stub page 2019-06-24 21:32:58 -03:00
Georges Basile Stavracas Neto 375b9fc53c calendar-management-dialog: Response to page switch 2019-06-24 21:32:57 -03:00
Georges Basile Stavracas Neto ad017d1709 calendars-page: Introduce GcalCalendarsPage
A page dedicated to show a list of calendars and add
new ones. Other pages will come in soon.
2019-06-24 21:32:57 -03:00
Georges Basile Stavracas Neto b2d2767131 calendar-row: Tweak margins 2019-06-24 21:32:57 -03:00
Georges Basile Stavracas Neto 831bbbdba8 calendar-management-page: Introduce new interface
This will be used by the pages of the calendar management dialog
to let it know they are actual pages, to offer an activation
mechanism, and to communicate with the dialog when they want to
switch to another page.
2019-06-24 21:32:57 -03:00
Georges Basile Stavracas Neto 4088b8b6bb source-dialog: Rename to GcalCalendarManagementDialog 2019-06-24 21:32:44 -03:00
Georges Basile Stavracas Neto c0720d0031 build: Move GcalSourceDialog to gui/calendar-management
Soon we will start populating this subfolder with many other
calendar management files, and to avoid making the gui/ folder
a mess, move source dialog to it.
2019-06-24 21:32:44 -03:00
Georges Basile Stavracas Neto 7217f9fa53 window: Add "Online Accounts..." button 2019-06-24 21:32:44 -03:00