Commit Graph
100 Commits
Author SHA1 Message Date
Georges Basile Stavracas Neto eb360dc809 shell-provider: use GcalEvent instead of event data
Following the sequence of porting commits, make the Shell's
search provider class handle events using GcalEvent classes
instead of the old GcalEventData structure.
2016-02-14 12:17:37 -02:00
Georges Basile Stavracas Neto e31e6eeac0 edit-dialog: use GcalEvent internally
Instead of using the ESource + ECalComponent combination,
use the new GcalEvent class, which wraps up and simplifies
most of the code.

This commit adds a GcalEditDialog::event property, and
adapts the dialog (and everything dependant on it's code)
to use the GcalEvent class.
2016-02-14 12:17:37 -02:00
Georges Basile Stavracas Neto 0ec0ea8121 event-widget: use GcalEvent internally
This saves a lot of code, and is much saner to maintain.
2016-02-14 12:17:37 -02:00
Georges Basile Stavracas Neto 2ded8b3147 event-widget: drop unused function 2016-02-14 12:17:37 -02:00
Georges Basile Stavracas Neto 5e0d4018f4 event: add a wrapper around events
Instead of relying on confusing structures, raw data
and direct access to components, add a wrapper for
events.
2016-02-14 12:17:37 -02:00
Georges Basile Stavracas Neto 9515c5e627 build: alphabetically sort source files 2016-02-12 15:17:48 -02:00
Georges Basile Stavracas Neto ca327e2ce5 time-selector: turn into a final class 2016-01-19 21:12:19 -02:00
Georges Basile Stavracas Neto 65cfea9609 search-view: turn into a final class 2016-01-19 20:55:17 -02:00
Georges Basile Stavracas Neto f9101b9bc8 year-view: turn into a final class 2016-01-19 20:45:05 -02:00
Georges Basile Stavracas Neto 771d227520 window: turn into a final class 2016-01-19 20:27:21 -02:00
Georges Basile Stavracas Neto 50ce09617e source-dialog: remove private field 2016-01-19 20:03:19 -02:00
Georges Basile Stavracas Neto 80b03531f2 manager: turn into a final class 2016-01-19 19:31:04 -02:00
Georges Basile Stavracas Neto f001fb48b7 event-widget: turn into a final class 2016-01-19 19:12:13 -02:00
Georges Basile Stavracas Neto 5fe6578b16 date-selector: turn into a final class
There is no subclass of GcalDateSelector, and
actually it isn't needed. So, turn the class
into a final class and get rid of the needless
private field.
2016-01-19 18:54:29 -02:00
Georges Basile Stavracas Neto adc83a7a93 application: turn into a final class
GcalApplication is not derivable, so turn it
into a final class and get rid of the private
field.
2016-01-19 18:43:11 -02:00
Georges Basile Stavracas Neto 994a2a839c Bump 3.19.4 release 2016-01-19 18:24:51 -02:00
Georges Basile Stavracas Neto bc6d40b718 build: remove glib-gettext
It's deprecated
2016-01-19 18:20:53 -02:00
Georges Basile Stavracas Neto 7a7910797c Update TODO 2016-01-19 18:16:34 -02:00
Georges Basile Stavracas Neto 7b28416361 month-view: make lines stronger
The current lines are very light and people
with visual issues may not find them easy.

To fix that, make these lines slightly stronger,
enough to make them clearly visible.

https://bugzilla.gnome.org/show_bug.cgi?id=758679
2016-01-12 17:00:07 -02:00
Georges Basile Stavracas Neto df9af0e8f9 month-view: remove leftover
This was supposed to be removed, since there's no
use in setting a state and immediately restore the
context.
2016-01-04 22:24:10 -02:00
Georges Basile Stavracas Neto b7e6de4c13 year-view: fix wrong padding
Since we're using css nodes now, the calendar-view
node overrides anything we could possibly set up. In
fact, I don't know how it was working before.
2016-01-04 19:22:28 -02:00
Georges Basile Stavracas Neto 6de0376ab6 month-view: fix warnings
We were calling gtk_style_context_get() with a state
different than that of the style_context, which yiels
warnings.

Fix that by saving, setting the flag and restoring the
context.
2016-01-04 16:50:47 -02:00
Georges Basile Stavracas Neto 21f3ed1ef1 project: more css names fixups 2016-01-04 16:50:46 -02:00
Georges Basile Stavracas Neto 5b8a26ec71 year-view: port to css nodes
Mainly by removing the gtk_widget_get_state_flags()
calls.
2016-01-04 16:50:40 -02:00
Georges Basile Stavracas Neto ef9868a0d7 event-widget: port to css nodes
This commit add a css name, and use the style
context's state flags as well.
2016-01-04 16:27:40 -02:00
Georges Basile Stavracas Neto 8b1054f638 month-view: set a css name
This will add a CSS Node in the style context,
and keep Calendar in sync with latest gtk+
upstream changes.
2016-01-04 16:27:40 -02:00
Georges Basile Stavracas Neto 2280a74856 edit-dialog: notify property before manually check sensitivity
When we check start & end time selector's sensitivity before
notifying the property change, the check is overriden by the
binding.

Fix that by performing the checks after the notification of the
property change.
2016-01-04 02:18:19 -02:00
Georges Basile Stavracas Neto abd6fa8b2d window: properly case ::manager property getter
It's a readwrite property, thus it must have an
case PROP_MANAGER set in get_property.
2015-12-31 00:37:36 -02:00
Georges Basile Stavracas Neto 961bf5dc88 window: setup edit dialog from UI file
This commit sets up the edit dialog from the window's ui
resource file, in a series of commits that tries to move
all C code to the UI definitions.

Also, GcalManager is a full GObject class, not a simple
pointer. As such, update the property spec to be of type
object, not pointer.
2015-12-30 17:37:12 -02:00
Georges Basile Stavracas Neto 13c4145507 edit-dialog: add ::writable and ::manager properties
By using these properties, we gain the possibility to
bind them to the widgets and save some needless code.

This commit adds GcalEditDialog::writable and ::manager
properties. Other needed properties will be eventually
added in the subsequent commits.
2015-12-30 17:34:29 -02:00
Georges Basile Stavracas Neto de207f9c63 edit-dialog: move bindings to UI file
We don't need to manually bind these properties in
the source code if we can make it on the UI files.
2015-12-30 15:05:20 -02:00
Georges Basile Stavracas Neto 4d19950c2c edit-dialog: cosmetic changes
Fixes some alignment issues, as well as some
needless checks. Also, use some handy glib
functions to shrink the code even more.
2015-12-30 14:59:16 -02:00
Georges Basile Stavracas Neto 3396291e3e edit-dialog: remove needless casts
These widgets are already stored as GtkWidgets,
and there is no need to do these casts.
2015-12-30 14:40:34 -02:00
Georges Basile Stavracas Neto 6f1eb7ca9d edit-dialog: turn into a final class
This commit updates GcalEditDialog's code for
it to be a final class. As such, we don't need
the GcalEditDialogPrivate type - we can simply
move our data to the GcalEditDialog struct.
2015-12-30 14:36:27 -02:00
Georges Basile Stavracas Neto 0ac827d87d edit-dialog: remove dead code
This is already set in the UI definition file
for the dialog.
2015-12-30 14:12:02 -02:00
Georges Basile Stavracas Neto 4d4aa8bb26 project: remove OnlyShowIn from desktop file
This limits the visibility of GNOME Calendar, which should
be usable in other desktop environments as well.

https://bugzilla.gnome.org/show_bug.cgi?id=758730
2015-12-09 20:43:39 -02:00
Georges Basile Stavracas Neto b6bec55185 month-view: don't show popover when clicking an invalid cell
Because we're using a simple (gint) cast to round y value of
the clicked point, a negative y was rounding to a valid cell
position and showing the popover even when the user clicked
on the blank cells before the actual month view.

Fix that by properly checking if y is negative.

https://bugzilla.gnome.org/show_bug.cgi?id=755910
2015-10-27 12:00:49 -02:00
Georges Basile Stavracas Neto 6afa9b98f6 month-view: fix mirroring macro
It was using a local variable, which is a bad idea. It
only worked because we were using it in the context of
that local variable, but it was luck.
2015-10-27 11:57:51 -02:00
Georges Basile Stavracas Neto 16e926bbcc Bump 3.18.0 release 2015-09-21 11:41:14 -03:00
Georges Basile Stavracas Neto d80595af69 build: update project version 2015-09-14 14:56:14 -03:00
Georges Basile Stavracas Neto bf1f87b19f Bump 3.17.92 release 2015-09-14 14:50:17 -03:00
Georges Basile Stavracas Neto 8bd3bcefcd Bump version 3.17.90 2015-08-19 17:43:22 -03:00
Georges Basile Stavracas Neto 4a96cecc9d Bump 3.17.4 release 2015-07-20 15:44:52 -03:00
Georges Basile Stavracas Neto d644cbc8bf search-view: update UI to match upstream
Latest GNOME applications follow a clear style of
searching and displaying results, with a no results
page.

To create a coherent usage between GNOME applications,
add the No results page to search popover.
2015-07-17 02:19:44 -03:00
Georges Basile Stavracas Neto 6080b62368 manager: implement ::move method 2015-07-16 00:22:54 -03:00
Georges Basile Stavracas Neto d3a806a684 year-view: improve font rendering
By using doubles instead of integers, we give a very
fluid resize effect for year view.
2015-07-15 23:55:08 -03:00
Georges Basile Stavracas Neto b56540a8d7 window: add tooltips to header buttons
In the case the user have any doubts about each
button, a nice tooltip shows and enlightens one's
mind.
2015-07-15 21:26:50 -03:00
Georges Basile Stavracas Neto 10e340c20f manager: initialize value
Avoids calling g_free on uninitialized memory,
which results in a nasty segfault.
2015-07-15 21:18:52 -03:00
Georges Basile Stavracas Neto 72c2988ff3 source-dialog: remove unused code 2015-07-15 21:10:27 -03:00
Georges Basile Stavracas Neto 80693e9ae5 edit-dialog: remove unused code 2015-07-15 21:10:12 -03:00
Georges Basile Stavracas Neto b1540e3f41 window: code cleanup
Remove the unneeded code to manage search bar visibility,
since it is correctly hidden now. Also, clean up some UI
code.
2015-07-15 20:57:12 -03:00
Georges Basile Stavracas Neto 0c1df74735 month-view: add keyboard navigation
This big patch implements keyboard navigation for
Month view and the main window. Also, refactor
some of it's drawing code.
2015-07-15 20:40:55 -03:00
Georges Basile Stavracas Neto 60fdb04c94 Bump 3.17.3 release 2015-06-22 22:01:59 -03:00
Georges Basile Stavracas Neto 2a22e49b51 project: update NEWS for 3.17.3 2015-06-22 21:59:37 -03:00
Georges Basile Stavracas Neto 1f666ba405 window: move forward/backward according to locale 2015-06-04 15:44:48 -03:00
Georges Basile Stavracas Neto 5381dc77a4 month-view: update focused cell on mouse events
Also, quit selection mode when Escape is pressed
2015-06-04 13:02:47 -03:00
Georges Basile Stavracas Neto e4b5da7f50 month-view: implement keyboard navigation
For this to be made, some significant changes on the inners
of GcalMonthView had to be done. Later on, I'll do a complete
rewrite of it, deprecating the use of 'sw' and 'k'.
2015-06-04 12:48:50 -03:00
Georges Basile Stavracas Neto 45977bad5b Bump 3.17.2 release 2015-05-25 15:23:58 -03:00
Georges Basile Stavracas Neto f7457b3074 build: fix uninstall-local 2015-05-25 15:08:56 -03:00
Georges Basile Stavracas Neto 0ccdbcff5e project: update NEWS for 3.17.2 2015-05-25 14:37:14 -03:00
Georges Basile Stavracas Neto 0a1a16060c po: add missing files to POTFILES.in 2015-05-25 14:31:45 -03:00
Georges Basile Stavracas Neto b7476cb84c manager: only load calendar sources
Do not blindly load every source loaded by the
ESourceRegistry::source-added, since it may be
a non-calendar source.
2015-05-25 14:05:49 -03:00
Georges Basile Stavracas Neto 0c47cda20c source-dialog: change visible page by pointers
Using their string representations was slow, compare
pointers which is fast.
2015-05-25 12:36:55 -04:00
Georges Basile Stavracas Neto b8fea7f1d1 source-dialog: fix memory leak
Free duplicated string when the listbox row is
destroyed.
2015-05-25 12:36:55 -04:00
Georges Basile Stavracas Neto 87c02b520a source-dialog: hide itself on response event 2015-05-25 12:36:55 -04:00
Georges Basile Stavracas Neto c1b14e48d4 window: comment misleading destruction of calendar row 2015-05-25 12:36:55 -04:00
Georges Basile Stavracas Neto 40b39337f3 source-dialog: remove deprecated xalign for buttons 2015-05-25 12:36:55 -04:00
Georges Basile Stavracas Neto 47674b4d61 source-dialog: remove the annoying 2px border from the dialog 2015-05-25 12:36:54 -04:00
Georges Basile Stavracas Neto ef9d1301d9 source-dialog: use a builder .ui definition for interface
We know that coding interfaces sucks, so use a .ui file instead.
2015-05-25 12:36:54 -04:00
Georges Basile Stavracas Neto f63541f475 manager: unred GOA client on finalize 2015-05-25 12:36:54 -04:00
Georges Basile Stavracas Neto 18f0026eb7 manager: use goa_client for private field
To not confuse it with the many other clients we
already have here
2015-05-25 12:36:54 -04:00
Georges Basile Stavracas Neto 9838c7fa41 window: fix more styling issues 2015-05-25 12:35:59 -04:00
Georges Basile Stavracas Neto 350cd5ea85 source-dialog: fix style 2015-05-25 12:35:58 -04:00
Georges Basile Stavracas Neto bbcd5bcc49 source-dialog: use GtkEntry::get_text_length 2015-05-25 12:35:58 -04:00
Georges Basile Stavracas Neto e3e30140b3 source-dialog: use g_clear_object instead of manual free 2015-05-25 12:35:58 -04:00
Georges Basile Stavracas Neto 6213f5cc78 source-dialog: remove useless checks before freeing memory
g_free is NULL-proof, no need to check if it's NULL
before using it.
2015-05-25 12:35:58 -04:00
Georges Basile Stavracas Neto f9b3f2f6c7 source-dialog: remove unused enum 2015-05-25 12:35:58 -04:00
Georges Basile Stavracas Neto cd872d42ed manager: load GOA client at construction time 2015-05-25 12:35:58 -04:00
Georges Basile Stavracas Neto 27fa9983f4 manager: change ::get_client to ::get_goa_client
This explains better the purpose of the methods, and also
don't collide with the ECalClient prefix we already use.
2015-05-25 12:35:58 -04:00
Georges Basile Stavracas Neto 87ecb99090 application: remove unused import 2015-05-25 12:35:58 -04:00
Georges Basile Stavracas Neto 2b4e46a4b6 manager: notify when sources are enabled/disabled
Add the new signal for GcalManager::source-enabled that
notifies connected widgets about the source change. With
that, we can keep checkboxes syncronizes.
2015-05-25 12:35:58 -04:00
Georges Basile Stavracas Neto 023a79a90f source-dialog: bind source::display-name with label::label 2015-05-25 12:35:58 -04:00
Georges Basile Stavracas Neto a9364d83cb window: better name Calendar Settings button 2015-05-25 12:35:58 -04:00
Georges Basile Stavracas Neto c3d34ae149 window: add a nice style to the calendar listbox 2015-05-25 12:35:58 -04:00
Georges Basile Stavracas Neto 134d8678fe source-dialog: connect the signal 2015-05-25 12:35:57 -04:00
Georges Basile Stavracas Neto 51a2695546 source-dialog: open online account settings when button is clicked 2015-05-25 12:35:57 -04:00
Georges Basile Stavracas Neto 60401426a2 source-dialog: silence gnome-control-center 2015-05-25 12:35:57 -04:00
Georges Basile Stavracas Neto 7482469b01 source-dialog: sort online accounts 2015-05-25 12:35:57 -04:00
Georges Basile Stavracas Neto 06e6f39721 source-dialog: remove accounts with GoaClient::account-removed 2015-05-25 12:35:57 -04:00
Georges Basile Stavracas Neto 1a580e3be5 source-dialog: hide empty goa rows instead of removing them 2015-05-25 12:35:57 -04:00
Georges Basile Stavracas Neto a8631eb99a source-dialog: initialize the icon name
Avoids some compiler warnings.
2015-05-25 12:35:57 -04:00
Georges Basile Stavracas Neto 321882f4b2 source-dialog: use subtitles to improve user discoveribility
Make it clear that you can configure your account
by clicking the row.
2015-05-25 12:35:57 -04:00
Georges Basile Stavracas Neto 2f882d2b0b source-dialog: add accounts when they're added 2015-05-25 12:35:57 -04:00
Georges Basile Stavracas Neto 10e032f510 source-dialog: open online account when row is activated 2015-05-25 12:35:57 -04:00
Georges Basile Stavracas Neto 06cfeace4d source-dialog: load online accounts 2015-05-25 12:35:57 -04:00
Georges Basile Stavracas Neto 3905622420 window: don't set the manager twice 2015-05-25 12:35:57 -04:00
Georges Basile Stavracas Neto 87299afe01 project: add online account row UI for source dialog 2015-05-25 12:35:57 -04:00
Georges Basile Stavracas Neto 5862f1671f window: add source dialog to builder file again 2015-05-25 12:35:57 -04:00
Georges Basile Stavracas Neto 7942677b8e application: move GoaClient to manager 2015-05-25 12:35:56 -04:00
Georges Basile Stavracas Neto 0142b0494e window: instance source dialog on init 2015-05-25 12:35:56 -04:00