Commit Graph
3 Commits
Author SHA1 Message Date
Niklas Wimmer b83a89a2e7 tests/range: Validate the compare function
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/798>
2026-07-22 14:13:36 +00:00
Niklas Wimmer ea2c637b35 core/range: Fix compare function
Fixes a regression from
https://gitlab.gnome.org/GNOME/gnome-calendar/-/commit/62345668748b571939c1c7b441e44664a05a0287

Essentially, `gcal_range_compare()` is just a faster subset of
`gcal_range_calculate_overlap()`. The commit that introduced this
regression accidentally flipped the sign of the compare function,
which made it no longer match with the implementation of overlap.

The function's implementation also did not match its doc comment,
returning any integer instead of only `-1`, `0` or `1`. Since the
behavior described in the doc comment is more commonly used for
comparison functions, the implementation was adjusted to match it.

To avoid any such failures in the future, the next commits will
add tests to validate.

Fixes: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/work_items/1615>
See: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/770>
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/798>
2026-07-22 14:13:36 +00:00
Niklas Wimmer 6ea211fbf9 flatpak: Remove intltool module
GNOME Calendar itself stopped depending on intltool in 3.25.3. After
intltool got removed from org.gnome.Sdk, it was added to our manifest
in 2019, because EDS still depended on it.

EDS stopped depending on intltool in 2021 (see linked MR).

Since this was the only module we used from the `shared-modules`
project, I also removed that git submodule.

See: <https://gitlab.gnome.org/GNOME/evolution-data-server/-/merge_requests/78>
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/802>
2026-07-22 13:24:28 +00:00