Federated_Computer/federated-calendar
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
5,279 Commits 3 Branches 0 Tags
a00a1f01bbc9942bf7f16ef4ab763fc2a27367ba
Commit Graph
28 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Federico Mena Quintero 84cf41cc4f core/timeline: Fix leak of QueueData in queue_event_data() 
The new QueueData was created even for REMOVE_EVENT, which causes an
early exit.  Only create the QueueData when needed.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/582>
 2025-05-30 14:10:05 +00:00
Federico Mena Quintero 2eec02b76a gui/views/month-view: Initialize two variables 
The static analizer can't figure out that they will always be initialized
by the for loop in this function.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/581>
 2025-05-28 18:08:54 +00:00
Federico Mena Quintero ef8c6ff55d utils/source-discoverer: Use temporary variable only when tracing is enabled 
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/581>
 2025-05-28 18:08:54 +00:00
Federico Mena Quintero a3ddd8e510 gui/views/month-view: Mark variable as unused 
It's just a temporary reference that will get removed at function exit.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/581>
 2025-05-28 18:08:54 +00:00
Federico Mena Quintero 3c38a272b8 gui/importer/import-dialog: Remove superfluous assignment 
The variable is initialized where it is declared.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/581>
 2025-05-28 18:08:54 +00:00
Federico Mena Quintero 8c2daf672b gui/importer/import-dialog: Remove an unused variable 
Looks like a cut&paste error.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/581>
 2025-05-28 18:08:54 +00:00
Federico Mena Quintero b03eabb7b7 gui/event-widget: Mark a variable as unused 
The actual parsed guri is unused here; the code just does the parsing
as a way to tell whether the event's location refers to a URI/service
or not (e.g. a physical location or address).

Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/581>
 2025-05-28 18:08:54 +00:00
Federico Mena Quintero 172f07c44e gui/views/week-grid: Remove superfluous assignment 
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/581>
 2025-05-28 18:08:54 +00:00
Federico Mena Quintero e56ce53ea5 gui/views/week-header: Remove superfluous assignment 
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/581>
 2025-05-28 18:08:54 +00:00
Federico Mena Quintero 81c8900076 gui/views/week-header: Remove unused variable 
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/581>
 2025-05-28 18:08:54 +00:00
Federico Mena Quintero bc53f169eb gui/views/week-header: Remove unused variable 
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/581>
 2025-05-28 18:08:54 +00:00
Federico Mena Quintero d1499329cc core/calendar-monitor: Replace a manual GRWLockWriterLocker with G_RW_LOCK_WRITER_AUTO_LOCK() 
This takes care of static-scan's warning about a variable being set
but never read.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/581>
 2025-05-28 18:08:54 +00:00
Federico Mena Quintero cf48f79f36 core/calendar-monitor: Replace a manual GRWLockWriterLocker with G_RW_LOCK_WRITER_AUTO_LOCK() 
This takes care of static-scan's warning about a variable being set
but never read.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/581>
 2025-05-28 18:08:54 +00:00
Federico Mena Quintero 26c3f83e3c core/calendar-monitor: Replace a manual GRWLockWriterLocker with G_RW_LOCK_WRITER_AUTO_LOCK() 
This takes care of static-scan's warning about a variable being set
but never read.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/581>
 2025-05-28 18:08:54 +00:00
Federico Mena Quintero e2dc3460a6 core/calendar-monitor: Replace a manual GRWLockWriterLocker with G_RW_LOCK_WRITER_AUTO_LOCK() 
This takes care of static-scan's warning about a variable being set
but never read.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/581>
 2025-05-28 18:08:54 +00:00
Federico Mena Quintero 1d5fd3eec9 core/calendar-monitor: Replace a manual GRWLockWriterLocker with G_RW_LOCK_WRITER_AUTO_LOCK() 
This takes care of static-scan's warning about a variable being set
but never read.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/581>
 2025-05-28 18:08:54 +00:00
Federico Mena Quintero 21b7607c39 core/calendar-monitor: Replace a manual GRWLockReaderLocker with G_RW_LOCK_READER_AUTO_LOCK() 
This takes care of static-scan's warning about a variable being set
but never read.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/581>
 2025-05-28 18:08:54 +00:00
Federico Mena Quintero f55f42b81c core/calendar-monitor: Replace a manual GRWLockReaderLocker with G_RW_LOCK_READER_AUTO_LOCK() 
This takes care of static-scan's warning about a variable being set
but never read.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/581>
 2025-05-28 18:08:54 +00:00
Federico Mena Quintero 32ebd80613 core/calendar: Replace a manual GMutexLocker with G_MUTEX_AUTO_LOCK() 
This takes care of static-scan's warning about a variable being set
but never read.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/581>
 2025-05-28 18:08:54 +00:00
Federico Mena Quintero eeb9c99172 core/calendar: Replace a manual GMutexLocker with G_MUTEX_AUTO_LOCK() 
This takes care of static-scan's warning about a variable being set
but never read.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/581>
 2025-05-28 18:08:54 +00:00
Federico Mena Quintero 0d3975b556 core/calendar: Replace a manual GMutexLocker with G_MUTEX_AUTO_LOCK() 
This takes care of static-scan's warning about a variable being set
but never read.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/581>
 2025-05-28 18:08:54 +00:00
Federico Mena Quintero e884a09268 core/calendar: Replace a manual GMutexLocker with G_MUTEX_AUTO_LOCK() 
This takes care of static-scan's warning about a variable being set
but never read.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/581>
 2025-05-28 18:08:54 +00:00
Federico Mena Quintero 872aae9183 core/calendar: Replace a manual GMutexLocker with G_MUTEX_AUTO_LOCK() 
This takes care of static-scan's warning about a variable being set
but never read.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/581>
 2025-05-28 18:08:54 +00:00
Federico Mena Quintero 384411b33a Increase the required version of glib to 2.80.0 
We'll need this for G_MUTEX_AUTO_LOCK().  It basically does

  g_autoptr (GMutexLocker) G_GNUC_UNUSED var = g_mutex_locker_new (mutex)

which will let us remove static-scan's warnings about assigned
variables that are never read, e.g. it complains about "locker" here:

    g_autoptr (GMutexLocker) locker = g_mutex_locker_new (&priv->shared.mutex);

The whole point of GMutexLocker is to be used with g_autoptr for a
mutex that is unlocked when its scope ends.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/581>
 2025-05-28 18:08:54 +00:00
Federico Mena Quintero 7d869ed4e8 CI: copy the scanbuild directory from the correct place 
Ninja's scan-build command creates a directory with an ugly unique
name.  So, we copy it to a well-known "scanbuild" directory instead.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/580>
 2025-05-27 13:42:19 +00:00
Federico Mena Quintero a00c72b139 Add an index.html landing page for GitLab pages 
For https://gnome.pages.gitlab.gnome.org/gnome-calendar/
 2025-05-26 18:39:08 -06:00
Federico Mena Quintero 1a232ba811 CI: Add a static-scan job 
This will run static analysis and publish the report on

  https://gnome.pages.gitlab.gnome.org/gnome-calendar/scanbuild
 2025-05-26 18:39:08 -06:00
Federico Mena Quintero 9c7315a66a CI: Add a test coverage job 
This uses grcov internally to generate the HTML report.  We use grcov
instead of, say, lcov, because grcov actually generates accessible
pages.

We use the gnome-build-meta:core-nightly container image.  It doesn't
contain grcov by default, but we download the binary from its github
page.  We can change this later to build a custom container image for
gnome-calendar's own CI.

This will publish the report on

  https://gnome.pages.gitlab.gnome.org/gnome-calendar/coverage/
 2025-05-26 18:13:55 -06:00