Commit Graph
17 Commits
Author SHA1 Message Date
Mohammed Sadiq 1b004fd1d9 window: Remove ununsed macro 2018-06-07 14:40:15 +00:00
Mohammed Sadiq f1a8aaed5f window: Simplify navigation code
Using <accelerator> in GtkBuilder can simplify lots of C code.
2017-12-06 21:40:15 +05:30
Mohammed Sadiq fd3cb3e9b5 window: Reuse window-state-changed callback
window-state-changed signal is already handled in window_state_method.
It is better not to override it again in class_init function.
2017-12-06 21:40:15 +05:30
Mohammed Sadiq 75ad9228f6 window: Simplify saving/loading window states
Follow https://wiki.gnome.org/HowDoI/SaveWindowState

* Use tuples in gsetting schema to save size and position
* Save changes to variable instead of saving to gsettings after every timemout
* Save the changes back to gsettings when the window is finalized.
2017-12-06 19:16:40 +05:30
Mohammed Sadiq 24a2e97df2 application: handle command line options right
Commandline arguments are now handled by the primary instance of the
application. And so outputs for --help, and --version are shown there.
Not where the application is invoked.

So hook to handle-local-options so that the arguments are parsed locally,
and sent unparsed ones to primary instance in case it is required.

As a side effect, the arguments passed to --date and --uuid are not updated
in the primary instance on subsequent runs (ie, when the primary instance
is already up and running). So check the commandline arguments as they
arrives rather than saving them to a variable, which won't then be updated.

https://bugzilla.gnome.org/show_bug.cgi?id=773152
2017-09-07 11:45:12 -03:00
Mohammed Sadiq 00b89b89cd gcal-event: fix several memory leaks
https://bugzilla.gnome.org/show_bug.cgi?id=782972
2017-05-24 15:08:31 -03:00
Mohammed Sadiq be731fcae7 event-widget: fix memory leak
https://bugzilla.gnome.org/show_bug.cgi?id=782566
2017-05-15 17:28:25 -03:00
Mohammed Sadiq 4dde284170 week-header: fix memory leak
https://bugzilla.gnome.org/show_bug.cgi?id=782561
2017-05-15 17:23:31 -03:00
Mohammed Sadiq 178e6a269a week-view: fix signal emission on scrolled_window
This was causing segfault in week-view

https://bugzilla.gnome.org/show_bug.cgi?id=782269
2017-05-06 12:51:25 -03:00
Mohammed Sadiq 9ed375cd99 application: fix setting active-date logic
https://bugzilla.gnome.org/show_bug.cgi?id=782192
2017-05-06 12:25:16 -03:00
Mohammed Sadiq cf787ea5b2 time-selector: set the right lower bound
There was a typo in function name, which was only setting
the upper bound for 24 hour time format. As the default
lower bound is 0, no issue was known so far.

But in cases like the user switched from 12 hour to 24 hour
format there is a chance for some issues to appear as the lower
bound of 12 Hour format is 1, and it won't be reset to 0 when
the user has switched to 24 hour format.

https://bugzilla.gnome.org/show_bug.cgi?id=781448
2017-04-18 09:32:37 -03:00
Mohammed Sadiq 1c9686b937 window: remove GSourceFunc once run
The function is supposed to run once every minute. So after
the function is run, just remove it from main thread. So that it won't
act as a time bomb.

https://bugzilla.gnome.org/show_bug.cgi?id=781081
2017-04-18 07:54:04 -03:00
Mohammed Sadiq 3be142a207 event: don't leak event description
https://bugzilla.gnome.org/show_bug.cgi?id=781400
2017-04-17 21:12:50 -03:00
Mohammed Sadiq 1449233382 application: cleanup finalize method
Calendar now segfaults due to faling function
gtk_style_context_remove_provider_for_screen in application finalize method.

As application finalize method is called only when the application closes,
there isn't any hard requirement to cleanup every trailings. Operating
System shall take care of that.

So removing the failing functions so as to not segfault on exit anymore.

https://bugzilla.gnome.org/show_bug.cgi?id=773871
2017-02-09 11:20:49 -02:00
Mohammed Sadiq 1e471b1b0c quick-add-popover: focus entry after calendar selection
Pressing 'Enter' key shall always save the event.
So focusing on 'Add' button after selecting calendar is redundant.

Instead, focus on the entry, so that the user can add more text without
manually focusing.

https://bugzilla.gnome.org/show_bug.cgi?id=778373
2017-02-09 09:48:45 -02:00
Mohammed Sadiq 0514d2b3b8 source-dialog: escape string in markup
Calendar name can potentially contain invalid markup texts.
So it have to be escaped to be safe.

https://bugzilla.gnome.org/show_bug.cgi?id=774986
2016-11-30 23:14:13 -02:00
Mohammed Sadiq 6cf5c0317d edit-dialog: check if event is new the right way
Checking if a new event is already having a source succeeds
for some reason (which should actually fail).

But thankfully we already have an event_is_new gboolean flag.
Check the status of that flag and add or update the event.

https://bugzilla.gnome.org/show_bug.cgi?id=771566
2016-11-22 09:54:28 -02:00