Commit Graph
112 Commits
Author SHA1 Message Date
Enzo MAROS 0e09efc43c window: Create calendar-management-dialog on demand
When the user deletes a calendar in the calendar management dialog, a
popover allows them to undo the deletion. The calendar is fully deleted
only when the toast is dismissed or when the toast reaches its timeout.
When the user closes the calendar management dialog without dismissing
the toast and before the end of the timeout, the calendar can still be
manipulated for a short period of time.

To fix this, I removed the calendar-management-dialog from the UI of the
window, and made the window create and destroy the dialog on demand.
This forces the toast overlay to dismiss all toasts.
2024-10-22 12:35:45 +00:00
Georges Basile Stavracas Neto c5424c8bfa calendar-management/new-calendar: Remove unused code 2024-10-11 22:39:04 -03:00
Jean-François Fortin Tam fb5b03b2df new-calendar: Title the local calendar group
In practice, the name and color widgets are currently meant to be used
when creating a local calendar, not when subscribing online, especially
as a single online calendar link can bundle multiple calendars.

This makes the scope of those widgets clearer,
and also makes the dialog more balanced.

Related: https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/566
2024-08-23 15:50:40 +00:00
Jean-François Fortin Tam 29396acf46 new-calendar: Use "title" in AdwPreferencesGroup
Replace the manually positioned & styled group label by a property

This simplifies the XML code, makes the style match the rest of the UI,
and prevents libadwaita from sometimes moving such labels to the bottom.
2024-08-23 15:50:40 +00:00
Jean-François Fortin Tam 126929b8c5 new-calendar: Clarify web calendar strings
Now that the "Open" button has been removed,
it is now a feature to "Connect" rather than "Import",
so update the section title to reflect that.

Also give a hint as to what protocols are supported.
2024-08-23 15:50:40 +00:00
Jean-François Fortin Tam a74ae36e6c Remove gcal-file-chooser-button code
As it is no longer used in the calendar management dialog,
and it was not used anywhere else in the codebase,
it can now be dropped entirely.
2024-08-23 15:50:40 +00:00
Jean-François Fortin Tam f827b8a1f2 Remove .ics file importer button in "New Calendar"
A file imported as a "new calendar" would make it dependent on the file.
This feature was confusing everybody and is downright dangerous.

This does not prevent anyone from creating normal calendars,
and importing events from .ics files into them.

Fixes https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/390
2024-08-23 15:50:40 +00:00
Jean-François Fortin Tam 2860a468f1 new-calendar: Show webcalendar subscription errors
Let the user know what went wrong,
using a secondary icon and tooltip directly in the URL entry field.
Also provide a hint to GTK that it is meant to be a URL field.

Fixes https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/1177
2024-08-16 18:46:36 -04:00
Diego Iván M.E 50c1197d61 new-calendar-page: Reset entry progress when validating
This way, the pulse is hidden once the operation fails, is cancelled
or succeeds.

Fixes #1273
2024-08-13 12:58:12 -06:00
Diego Iván M.E 648badb826 new-calendar-page: Cancel validation/discovery when user types
It allows the user to fix typos in URLs or delete them. Before this,
it would still prompt the password dialog, for instance

Closes #1272
2024-08-13 12:58:09 -06:00
Diego Iván M.E b024319f60 new-calendar-page: Change URL validation feedback
Currently, the progress bar is pulsed as soon as the user starts
typing, giving the impression that a process is on going. But,
in reality, validation is performed 500 ms.

After this changes the progress bar is pulsed only when validation
is on-going. The timeout has been increased to 750ms too.
2024-08-13 12:55:51 -06:00
Automeris naranja e00d8cbf66 gcal-calendars-page: Minor tweaks to the AdwToast title
AdwToast title is already bold, so using HTML b tags doesn't do
anything. To fix this, use quote symbols instead.

And:
- Use the quote symbols recommended by HIG:
https://developer.gnome.org/hig/guidelines/typography.html#take-advantage-of-unicode
- Add a translator comment explaining what "%s" means
2024-07-24 15:08:51 +00:00
Jean-François Fortin Tam 006437bf61 Avoid duplication when adding online calendars
When subscribing to one or multiple online Webcal or CalDAV calendars,
do not unexpectedly create an extra local calendar.

While this doesn't allow customizing names & colors while subscribing,
users can still easily set those just after adding the subscriptions,
as they are then returned to the "Calendars" page of "Manage Calendars".

Punting this to a separate step might not seem like the "perfect" flow,
but it works well enough and fixes the buggy UX that we currently had.

Fixes https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/566
Fixes https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/978
2024-07-09 16:44:01 -04:00
Sabri Ünal 2949deeaca i18n: Add context for Add Calendar buttons
Due to some languages using the "nplurals=1; plural=0" plural form,
and the string already in use in src/gui/calendar-management/gcal-new-calendar-page.c
with g_dngettext, add context to the other "Add Calendar" strings to fix the problem.

AFAIK, other locales (confirmed: be_BY, fa_IR, id_ID, kk_KZ, ko_KR, my_MM, zh_CN)
are also affected by this issue.
2024-07-02 15:45:14 +00:00
Jamie Gravendeel 294d8ce90a calendars-page: Remove suggested styling 2024-07-02 15:44:27 +00:00
Philipp S d518f20045 calendar-management-dialog: Ensure minimum dialog height 2024-05-28 14:03:49 +00:00
Jamie Gravendeel 7d1fc2f92a calendars-page: Restore raised functionality 2024-05-02 22:05:48 +02:00
Georges Basile Stavracas Neto eced2151aa calendar-management/edit: Use external-link-symbolic icon
As per mockups.
2024-05-02 14:54:43 -03:00
Georges Basile Stavracas Neto 9add430c30 calendar-management/edit: Always show calendar location
As per mockups.

See https://gitlab.gnome.org/Teams/Design/app-mockups/-/issues/102
2024-05-02 14:54:43 -03:00
Jamie Gravendeel 967e8cf494 edit-calendar-page: Port remove to AdwButtonRow
Also puts the remove button in its own PreferencesGroup so that the row
can be showed separately from the rest of the list.
2024-05-01 14:06:21 +00:00
Alice Mikhaylenko eb8ee25f6a calendars-page: Port Add Calendar button to AdwButtonRow 2024-05-01 13:47:16 +00:00
Georges Basile Stavracas Neto 0228df3bc9 calendar-management/page: Remove unused vfuncs 2024-05-01 10:45:57 -03:00
Georges Basile Stavracas Neto 57ba8e2bf1 calendar-management: Rework page interface
Make GcalCalendarManagementPage require implementors to be
AdwNavigationPages
2024-05-01 10:44:16 -03:00
Aurélien Delory eaf5f55ac3 calendar-management/edit: Bind title to calendar name
Closes: https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/1146
2024-05-01 10:30:30 -03:00
Hari Rana 65bb78f11a edit-calendar-page: Improve location row
This changes the tooltip text display area uniquely to the
subtitle label, and excludes HTML elements and attributes
from accessibility labels.
2024-04-26 12:41:47 +00:00
Hari Rana 991ad3385b calendars-page: Remove Esc shortcut
AdwDialog already provides its own controller to close the window
with Esc.
2024-04-04 14:31:06 -04:00
Hari Rana 2a31fbab7b calendar-management-dialog: Remove content height
The dialog will automatically request a height by itself, which will benefit those who use it in fullscreen and have tons of calendars.
2024-02-23 23:03:51 -05:00
Hari Rana 704af0870d calendars-page: Remove add_calendar_row ID
This removes the leftover and unused code from https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/382.
2024-02-16 18:16:24 -05:00
Monster 00ba0df868 general: Revert removed periods 2024-02-14 14:55:36 +00:00
Monster 3733d11380 general: Correct strings to comply with GNOME HIG 2024-02-14 14:55:36 +00:00
Georges Basile Stavracas Neto 72d3caaf94 calendar-management: Make it an AdwDialog
So it can behave like a bottom sheet when collapsed.
2024-01-27 12:32:12 -03:00
Hari RanaandGotam Gorabh 303c5fd0fe calendar-row: Add read-only icon for read-only calendars
Co-authored-by: Gotam Gorabh <gautamy672@gmail.com>
2023-12-14 02:46:56 +00:00
Hari Rana b270176d02 calendars-page: Add AdwClamp to contrain the size 2023-12-14 00:28:21 +00:00
Hari Rana 5a1fce406b calendar-management: Set width request
The minimum width of the dialog was really low, which would make it unreadable, so a width request is being set to set a reasonable minimum width.
2023-12-14 00:20:08 +00:00
Hari Rana 033fca7900 calendar-row: Mark string as translatable 2023-12-07 15:03:14 +00:00
Hari Rana e7a61de5fc calendars-page: Add shortcuts for Add Calendar
The "Add Calendar" button lacked a mnemonic, which made it difficult for keyboard users to activate it. It also adds a Ctrl+N shortcut.
2023-12-04 19:46:10 -05:00
Hari Rana 8c53034864 a11y: Add labels for calendar pages 2023-12-04 18:40:57 +00:00
Felipe Kinoshita a6f3f130ff gcal-calendars-page: Move new calendar button to bottom toolbar
Currently, if you have lots of calendars you need to scroll all the way
to the bottom of list to have access to the "New Calendar" button.

This commit moves the "New Calendar" button to be on a bottom toolbar
provided by AdwToolbarView. It makes the button always on view and easy
to access.

Closes https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/1051
2023-11-29 21:38:53 +00:00
Georges Basile Stavracas Neto e9ab7effad calendar-management/edit: Remove unnecessary binding
This is handled by the C code now.
2023-09-28 11:52:11 -03:00
Hari Rana db8127e79a calendar-row: Port to AdwActionRow
`AdwSwitchRow` doesn't allow us to add widgets before the switch as a suffix, which will be required for further use.
2023-08-07 23:15:22 +00:00
Hari Rana f210382bdc calendar-row: Port to AdwSwitchRow 2023-08-03 22:11:12 -04:00
axtloss 4079b5be0e calendar-editor/new-calendar: Fix unresponsive dialog after failed login
Adds the hide-on-close property to the dialog to stop it from becoming
unresponsive after the user tries to enter credentials multiple times.
2023-07-30 13:48:40 +00:00
Hari Rana 962646f065 calendar-row: Add go-next icon to indicate subpages 2023-07-29 07:49:44 +00:00
axtloss 779e3cd080 calendar-editor/new-calendar: Port authorization window to AdwMessageDialog
Replaces the AdwWindow authorization window with an AdwMessageDialog

Fixes #1044
2023-07-25 07:17:27 +00:00
Hari Rana 2bb1ae90e4 calendars-page: Add mnemonic for "Undo" 2023-07-23 09:58:25 -04:00
Hari Rana 540c27f72d calendars-page: Add Esc as shortcut to close window 2023-07-21 15:51:43 -04:00
Victoria Lacroix aec45594f9 gcal-utils: Combine GNOME Settings launchers
This refactor combines the functions
gcal_utils_launch_online_accounts_panel and
gcal_utils_launch_datetime_settings_panel into a single function that
takes a panel ID as an argument.
2023-07-15 23:04:51 +00:00
Hari Rana 3b818bf9dd edit-calendar: Fix visibility row 2023-06-22 09:44:20 -04:00
Georges Basile Stavracas Neto 750ab0aef8 calendar-management/calendars: Update title 2023-06-22 00:20:21 +00:00
Georges Basile Stavracas Neto cfad123629 calendar-management: Cleanup some more 2023-06-22 00:20:21 +00:00