Commit Graph
942 Commits
Author SHA1 Message Date
Otávio Silva c175073ab0 import-file-row: correctly display start and end dates in import dialog
In the import dialog, start and end date-time fields were being
incorrectly displayed, not considering the local timezone and the
24-hours vs 12-hours format used by the user. Also, the libical
already deals with the case in which events do not have the DTEND
field, simplifying the implementation.

Fixes #1175
2024-07-20 20:20:16 +00:00
Otávio Silva 0bc006be5c import-dialog: add constructed() override
Add GObject.constructed override and call the setup_calendars
function inside of it.
2024-07-20 20:20:16 +00:00
Otávio Silva b8903657c5 import-file-row: Receive a context
Modify the GcalImportFileRow struct to now have the
property GcalContext.
2024-07-20 20:20:16 +00:00
Jean-François Fortin Tam 006437bf61 Avoid duplication when adding online calendars
When subscribing to one or multiple online Webcal or CalDAV calendars,
do not unexpectedly create an extra local calendar.

While this doesn't allow customizing names & colors while subscribing,
users can still easily set those just after adding the subscriptions,
as they are then returned to the "Calendars" page of "Manage Calendars".

Punting this to a separate step might not seem like the "perfect" flow,
but it works well enough and fixes the buggy UX that we currently had.

Fixes https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/566
Fixes https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/978
2024-07-09 16:44:01 -04:00
Georges Basile Stavracas Neto 75a42c7d83 event-widget: Truncate the correct string
I shouldn't write code in a hurry
2024-07-09 17:40:01 -03:00
Georges Basile Stavracas Neto 06bf58d5fa event-widget: Don't modify translated strings 2024-07-09 17:35:48 -03:00
Daniel Garcia Moreno d7bbda4eaa views/agenda: Do not create new header for all-day
Fix https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/898
Fix https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/968
2024-07-09 19:59:42 +00:00
Dimitrios Christidis 5dbf0c24bd event-editor: Introduce reminder at event start time 2024-07-09 19:54:03 +00:00
Abdullahi Usman d8e2fd6d81 reminders-section: make alarm sound changes persistent
When the alarm sound changes, the change is not updated because
gcal-manager does not see the changes.

We now update the components and make more comparisons so that
it can be seen by gcal-manager
2024-07-09 19:47:13 +00:00
Abdullahi Usman 420a126ddb reminders-section: fix reminder alarm toggle button states
Alarm toggle state are in three stages because we do not update both
icon and active when pressed.

we now update the icons to match their states.
2024-07-09 19:47:13 +00:00
Vitaly Dyachkov 2dab78b556 Make event title selectable
Currenlty, there is no easy way to copy an event title.
2024-07-09 19:31:56 +00:00
Otávio Silva 7cebd2bf95 event-widget: Use "On..." in tooltip when location is a meeting service
In the tooltip, the event location always has the preposition "At ...".
This changes it to "On ..." when the location is a known meeting
service.
2024-07-09 16:26:29 -03:00
Otávio Silva f3359d0246 event-widget: Display meeting service name in event tooltip
In case the location is an URL, it is irrelevant to display the full
link,
as it is not clickable. So, this shows the meeting service provider if
it
is known or reduces the text in the tooltip, preventing it from covering
other information in the calendar.

Closes: #1232
2024-07-09 16:26:00 -03:00
Otávio Silva 9433db55a2 utils: Move get_service_name_from_url to utils
This function can be useful in contexts other than the creation of
the meeting row.
2024-07-09 16:14:47 -03:00
Sabri Ünal 2949deeaca i18n: Add context for Add Calendar buttons
Due to some languages using the "nplurals=1; plural=0" plural form,
and the string already in use in src/gui/calendar-management/gcal-new-calendar-page.c
with g_dngettext, add context to the other "Add Calendar" strings to fix the problem.

AFAIK, other locales (confirmed: be_BY, fa_IR, id_ID, kk_KZ, ko_KR, my_MM, zh_CN)
are also affected by this issue.
2024-07-02 15:45:14 +00:00
Jamie Gravendeel 294d8ce90a calendars-page: Remove suggested styling 2024-07-02 15:44:27 +00:00
José Guilherme fb86cede2f about: enclose version number string between backticks
When the text is pasted on gitlab, it recognizes the version SHA and
places a hyperlink to the commit, which might facilitate unintended
references to be created.

By enclosing the string between backticks, gitlab does not recognize it.

Closes #1246
2024-07-02 15:43:30 +00:00
Georges Basile Stavracas Neto de5f663373 style: Use CSS variables for event widget styling
This vastly simplifies the code!
2024-06-11 17:22:35 -03:00
Philipp S d518f20045 calendar-management-dialog: Ensure minimum dialog height 2024-05-28 14:03:49 +00:00
Philipp S 5695b718ff Update file gcal-event-widget.ui 2024-05-12 05:59:12 +00:00
Jamie Gravendeel 7d1fc2f92a calendars-page: Restore raised functionality 2024-05-02 22:05:48 +02:00
Georges Basile Stavracas Neto eced2151aa calendar-management/edit: Use external-link-symbolic icon
As per mockups.
2024-05-02 14:54:43 -03:00
Georges Basile Stavracas Neto 9add430c30 calendar-management/edit: Always show calendar location
As per mockups.

See https://gitlab.gnome.org/Teams/Design/app-mockups/-/issues/102
2024-05-02 14:54:43 -03:00
Jean-François Fortin Tam b547db1170 event-editor: Demystify the read-only padlock icon
Non-technical users may not realize why they can not edit some events
from read-only subscribed remote calendars.

A symbolic padlock icon does not suffice to make this obvious.
This tooltip makes the UI self-documenting, and improves accessibility.
2024-05-01 15:01:39 +00:00
Jean-François Fortin Tam f332b5a076 Delay search activation for better UX & perfs
A more realistic default delay avoids spamming the search backends.
Benefits of this approach:

* Improves overall performance, allows wider search timeline ranges;
* Reduces power consumption;
* Reduces or eliminates flickering in the GUI;
* Reduces the amount of trace logging noise by more than 15x.

Fixes https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/1170
2024-05-01 14:52:13 +00:00
Jean-François Fortin Tam d7f200fff8 search-button: Add debug statements
This makes it easier to troubleshoot what triggers and stops searches.
2024-05-01 14:52:13 +00:00
Jamie Gravendeel 967e8cf494 edit-calendar-page: Port remove to AdwButtonRow
Also puts the remove button in its own PreferencesGroup so that the row
can be showed separately from the rest of the list.
2024-05-01 14:06:21 +00:00
Alice Mikhaylenko 6a27049c93 event-editor-dialog: Port Delete Event button to AdwButtonRow 2024-05-01 13:47:16 +00:00
Alice Mikhaylenko a74e7179c1 reminders-section: Port Add Reminder row to AdwButtonRow 2024-05-01 13:47:16 +00:00
Alice Mikhaylenko eb8ee25f6a calendars-page: Port Add Calendar button to AdwButtonRow 2024-05-01 13:47:16 +00:00
Georges Basile Stavracas Neto 0228df3bc9 calendar-management/page: Remove unused vfuncs 2024-05-01 10:45:57 -03:00
Georges Basile Stavracas Neto 57ba8e2bf1 calendar-management: Rework page interface
Make GcalCalendarManagementPage require implementors to be
AdwNavigationPages
2024-05-01 10:44:16 -03:00
Aurélien Delory eaf5f55ac3 calendar-management/edit: Bind title to calendar name
Closes: https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/1146
2024-05-01 10:30:30 -03:00
Hari Rana 0c8e1834f7 about, appdata: Port to AdwAboutDialog.new_from_appdata
This removes a lot of duplicated code, as we can simply reuse the
appdata file. It will also allow us to add release notes without
needing to rewrite them. A simple update in the
`adw_about_dialog_new_from_appdata` method will take care of
displaying the release notes.

This also renames the appdata file from `appdata.xml` to
`metainfo.xml`, as `appdata.xml` is considered a legacy filename.
2024-04-26 12:56:14 +00:00
Jean-François Fortin Tam 704c0815a1 event-editor: Focus "Done" for read-only events
In commit 1494f7407, we focus the summary entry when opening the dialog.
However, this prevents the Escape keyboard shortcut from working
when opening a read-only event after having opened a writable event.

Set focus onto the "Done" button when showing a read-only event,
as it's the only widget that can be activated/clicked in this situation.

This makes the "Escape", "Spacebar" and "Enter" keyboard shortcuts work.

Fixes https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/1180
2024-04-26 12:54:59 +00:00
Hari Rana 65bb78f11a edit-calendar-page: Improve location row
This changes the tooltip text display area uniquely to the
subtitle label, and excludes HTML elements and attributes
from accessibility labels.
2024-04-26 12:41:47 +00:00
Hari Rana 991ad3385b calendars-page: Remove Esc shortcut
AdwDialog already provides its own controller to close the window
with Esc.
2024-04-04 14:31:06 -04:00
Matthias Schaufelberger 5d460f0715 Change issue-url for "Report an issue"
"Report an Issue" now redirects to the issues overview page instead of
directly creating a new issue which is only possible for logged in
users.

Fixes: #1206
2024-03-30 18:44:12 +01:00
Alexandre Franke 5f0d548e8f metainfo: fix URLs 2024-03-01 14:15:33 +01:00
Georges Basile Stavracas Neto cbe89a9daa gui/event-editor: Rework calendars menu
Use a GtkListBox and bind from the model. Create rows from the model
items, and bind properties as needed.

The action target is set only when the calendar is writable because
setting an invalid action+target pair makes the row insensitive.

Remove the ancient menu icon hack.
2024-03-01 00:39:42 -03:00
Georges Basile Stavracas Neto 4795999092 Revert "event-editor: Revert "New Event" string back to "Unnamed Event""
This reverts commit 18da9c9f3b.
2024-02-25 14:32:07 -03:00
Georges Basile Stavracas Neto 18da9c9f3b event-editor: Revert "New Event" string back to "Unnamed Event" 2024-02-25 13:18:06 -03:00
Hari Rana ddb54c8c1c event-editor: Improve event name validation handling
- Fix a bug where clicking the "Add Event" button created an empty title in the event editor dialog.
- Add "error" class when the user writes an invalid event name.
- Add new function to validate event name.

Because the sections are split into files, the event editor will need a signal to check that each section is correct, and each section will have to emit the signal. This will need to be done in a future commit.
2024-02-25 08:55:17 -05:00
Hari Rana 1494f7407f summary-section: Grab focus on summary entry when opening dialog
Due to an unintentional behavior change from AdwWindow to AdwDialog, the entry row must be focused after the dialog is displayed.
2024-02-24 22:53:54 +00:00
Hari Rana 2a31fbab7b calendar-management-dialog: Remove content height
The dialog will automatically request a height by itself, which will benefit those who use it in fullscreen and have tons of calendars.
2024-02-23 23:03:51 -05:00
Jean-François Fortin Tam 1ae6fbb637 event-editor: Fix widgets groups sensitivity sync
A side-effect of changing the default "writable" state in commit 06b3c38
is that we must ensure that all the widget groups are synced with it.

Fixes https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/1178
2024-02-23 17:13:01 -05:00
Jean-François Fortin Tam 06b3c38db8 event-editor: Fix the "Save" / "Done" button label
The "Done" button was apparently meant for read-only events,
while the "Save" action was for everything else.
It didn't work correctly because of a mismatch between code and UI XML.

Fixes: https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/1142
2024-02-23 16:19:40 +00:00
Georges Basile Stavracas Neto ac8c7d6c4f gui/event-widget: Set weak ref on preview popover
So that when it's destroyed, the internal ref becomes NULL and we then
can safely call g_clear_pointer() on it.

Closes: https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/1154
2024-02-18 17:25:42 -03:00
Hari Rana 704af0870d calendars-page: Remove add_calendar_row ID
This removes the leftover and unused code from https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/382.
2024-02-16 18:16:24 -05:00
Monster 00ba0df868 general: Revert removed periods 2024-02-14 14:55:36 +00:00