Philipp S
74c17a7126
views/week: Align hour bar labels at the top
...
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/572 >
2025-05-30 14:28:39 +00:00
Federico Mena Quintero
2eec02b76a
gui/views/month-view: Initialize two variables
...
The static analizer can't figure out that they will always be initialized
by the for loop in this function.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/581 >
2025-05-28 18:08:54 +00:00
Federico Mena Quintero
a3ddd8e510
gui/views/month-view: Mark variable as unused
...
It's just a temporary reference that will get removed at function exit.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/581 >
2025-05-28 18:08:54 +00:00
Federico Mena Quintero
3c38a272b8
gui/importer/import-dialog: Remove superfluous assignment
...
The variable is initialized where it is declared.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/581 >
2025-05-28 18:08:54 +00:00
Federico Mena Quintero
8c2daf672b
gui/importer/import-dialog: Remove an unused variable
...
Looks like a cut&paste error.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/581 >
2025-05-28 18:08:54 +00:00
Federico Mena Quintero
b03eabb7b7
gui/event-widget: Mark a variable as unused
...
The actual parsed guri is unused here; the code just does the parsing
as a way to tell whether the event's location refers to a URI/service
or not (e.g. a physical location or address).
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/581 >
2025-05-28 18:08:54 +00:00
Federico Mena Quintero
172f07c44e
gui/views/week-grid: Remove superfluous assignment
...
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/581 >
2025-05-28 18:08:54 +00:00
Federico Mena Quintero
e56ce53ea5
gui/views/week-header: Remove superfluous assignment
...
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/581 >
2025-05-28 18:08:54 +00:00
Federico Mena Quintero
81c8900076
gui/views/week-header: Remove unused variable
...
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/581 >
2025-05-28 18:08:54 +00:00
Federico Mena Quintero
bc53f169eb
gui/views/week-header: Remove unused variable
...
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/581 >
2025-05-28 18:08:54 +00:00
Titouan Real
69f8b1821a
general: Remove dead code
...
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/578 >
2025-05-27 00:48:02 +00:00
Titouan Real
9aa3497202
calendar-management: Use callbacks to apply changes
2025-05-24 16:39:59 +02:00
Georges Basile Stavracas Neto
766369dd48
build: Remove unused variables
2025-05-21 01:38:07 -03:00
Hari Rana
6cd138974f
views/week-header: Port to gtk_widget_compute_point
...
`gtk_widget_translate_coordinates` is deprecated.
2025-05-21 01:21:38 -03:00
Hari Rana
2bfa881c2d
views/week-grid: Port to gtk_widget_compute_point
...
`gtk_widget_translate_coordinates` is deprecated.
2025-05-21 01:21:38 -03:00
Hari Rana
a25b129643
views/month: Disallow moving focus out of the view with arrow keys
2025-05-21 01:17:33 -03:00
Hari Rana
ed1db0bf72
views/month: Move out of the view when pressing tab
...
This makes it so the user can easily skip the entire month view
by pressing tab within the month view. This means, events can only
be accessed with arrow keys in the month view.
2025-05-21 01:14:17 -03:00
Hari Rana
1ab79d0cc8
views/month: Set all non-visible rows as unfocusable
...
When tabbing into the month view, the keyboard focus would go
to the first week row in the widget hierarchy, rather than the
visible row. Setting the `GtkWidget:can-focus` property to
FALSE on every non-visible row only allows keyboard focus
within the visible rows.
2025-05-21 01:13:38 -03:00
Hari Rana
8c02d0ce24
views/month: Use macros for first and last visible row indexes
2025-05-20 22:33:43 -04:00
Titouan Real
cbaa0c8e83
gui/application: Add myself as a developer
2025-05-18 23:25:45 +02:00
Philipp S
784375dedc
gui/application: Add myself as a designer
2025-05-07 17:35:10 +00:00
Hari Rana
3d7197d3cd
gui/window: Set parent widget as last focus when event widget is unfocusable
...
When selecting an event with a pointer, the keyboard-focused widget
was being set instead of the last focus widget, which was
then refocused after the event popover closed.
This patch fixes that bug by only setting the parent widget as
the last focus widget if the event widget itself is unfocusable,
like in the agenda view. The `GtkWidget:focus-on-click` property
is already enabled, so it takes care of refocusing the event
widget if it's focusable.
Commit https://gitlab.gnome.org/GNOME/gnome-calendar/-/commit/a3fb57939a307f5b661cc2f205e562f43a0a31fa
technically fixed https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/915 ,
but this patch solidifies the commit.
Closes https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/915
2025-05-05 12:05:41 -04:00
Georges Basile Stavracas Neto
06ef0539e4
views/week: Properly math out selection positions
...
Commit 69ac7468e2 introduced a regression since it calculates the
height of the selection widget based on the Y position of end+1 cell,
which is the first cell of the next column in the case of the last
cell.
Fix that by mathing out properly.
Fixes: 69ac7468e2
Closes: https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/1397
2025-05-04 17:16:18 -03:00
Georges Basile Stavracas Neto
5504872eb6
views/week: Better scope some variables
...
Move them to inner scopes, and make them signed integers.
2025-05-04 17:15:04 -03:00
Zoey
1c7760bd89
Reuse day_of_month to check if date of month is 1
2025-05-01 18:27:05 +01:00
Georges Basile Stavracas Neto
c42d987335
gui/window: Track focus widget when showing event preview
...
Store a weak pointer to whatever widget triggered the preview, and
restore when the popover is closed. This should fix the focused list
box row issue.
2025-04-30 21:43:52 -03:00
Hari Rana
0aaf13626c
views/agenda: Only focus rows
...
This is to avoid selecting the event widget twice, while still
being able to use the GtkListBoxRow's features.
2025-04-30 21:43:43 -03:00
Hari Rana
a3fb57939a
gui/event-widget: Implement button features
...
This implements button functionality to make it able to focus
and activate it. This also sets the appropriate accessibility
role and labels/descriptions.
Related: https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/1036
2025-04-30 21:23:44 -03:00
Vishruth-Thimmaiah
749d7e96e8
gcal-week-grid: Make DnD highlight area height match event's duration
...
Fixes issue #1341
2025-04-21 19:40:30 +00:00
Hari Rana
a09c02591e
event-editor/notes: Add height-request
...
The larger physical size of the text view helps convey that it's
a text box, and not a regular button or list box row.
Related: https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/1081
2025-04-21 13:32:49 -04:00
Hari Rana
445000b3cc
event-editor/notes: Add 'focused' CSS class when focused
...
This mimics what GtkEntryRow does, and allows for an always visible
focus ring when the notes text view has focus.
Related: https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/1081
2025-04-21 13:32:49 -04:00
Hari Rana
140dd3b145
event-editor/notes: Make it an AdwPreferencesRow
2025-04-21 13:32:45 -04:00
Titouan Real
931254c2a4
common/date-chooser: Housekeeping
...
Add some assertions and comments
2025-04-09 15:35:20 +00:00
Titouan Real
303cba1622
gui: Move DateChooser to common
...
DateChooser is used both by the event editor and the main window.
Moving it to common for a better file organization.
2025-04-09 15:35:20 +00:00
Titouan Real
0aa0619e99
gui: Move CalendarComboRow to common
...
CalendarComboRow is used both by the event editor and the importer.
Moving it to common for a better file organization.
2025-04-09 15:35:20 +00:00
Adrien Plazas
97791dbb99
weather-settings: Drop error style on empty search
...
This prevents an empty search entry from having the error style,
otherwise typing in it just once and not finding a location will keep
the entry red until the app is started anew.
2025-04-09 15:32:20 +00:00
Georges Basile Stavracas Neto
340081d431
views/week: Remove shared size group
2025-04-04 21:00:30 -03:00
Georges Basile Stavracas Neto
5ac19000ea
views/week: Use a separator instead of custom CSS
2025-04-04 21:00:30 -03:00
Georges Basile Stavracas Neto
f336b142f4
views/week: Reimplement arrow changes with CSS
2025-04-04 21:00:30 -03:00
Georges Basile Stavracas Neto
9048fe939f
views/week: Move expand header button to week view
2025-04-04 21:00:30 -03:00
Georges Basile Stavracas Neto
c0dfe588ae
views/week: Add 'can-expand' property
2025-04-04 21:00:29 -03:00
Georges Basile Stavracas Neto
f653dcd9e6
views/week: Add 'expanded' property
2025-04-04 21:00:29 -03:00
Georges Basile Stavracas Neto
a07d80cccf
views/week: Extract headers into GcalWeekView
...
Instead of handling them in GcalWeekHeader
2025-04-04 21:00:29 -03:00
Georges Basile Stavracas Neto
65f793b59e
views/week: Use widget for DnD
2025-04-04 21:00:29 -03:00
Georges Basile Stavracas Neto
f4ef9a29c3
views/week: Use anonymous struct for DnD
2025-04-04 21:00:29 -03:00
Georges Basile Stavracas Neto
cbfada052d
views/week: Use widget to draw selection
...
Same as week grid.
2025-04-04 21:00:29 -03:00
Georges Basile Stavracas Neto
e94600668c
weeks/view: Add anonymous struct for selection
...
Same as the grid view.
2025-04-04 21:00:29 -03:00
Georges Basile Stavracas Neto
ea23581cf5
views/week: Use g_autoptr more
...
And remove an unused variable.
2025-04-04 21:00:29 -03:00
Georges Basile Stavracas Neto
82fa42ec9e
views/week: Replace chain up by manual snapshotting
...
Should make it easier to spot mistakes in the future.
2025-04-04 21:00:29 -03:00
Georges Basile Stavracas Neto
fb52dae400
views/week: Turn GcalWeekHeader into a GtkWidget
...
No functional changes so far.
2025-04-04 21:00:29 -03:00