Federated_Computer/federated-calendar
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

views/week: Properly math out selection positions

Browse Source 
Commit 69ac7468e2 introduced a regression since it calculates the
height of the selection widget based on the Y position of end+1 cell,
which is the first cell of the next column in the case of the last
cell.

Fix that by mathing out properly.

Fixes: 69ac7468e2
Closes: https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/1397
This commit is contained in:
Georges Basile Stavracas Neto
2025-05-04 17:16:18 -03:00
parent 5504872eb6
commit 06ef0539e4
1 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/gui/views/gcal-week-grid.c
+9 -4
View File
@@ -634,6 +634,8 @@ gcal_week_grid_size_allocate (GtkWidget *widget,
if (gtk_widget_should_layout (self->selection.widget))
{
gint selection_height;
gint start_row;
gint end_row;
gint column;
gint start;
gint end;
@@ -654,13 +656,16 @@ gcal_week_grid_size_allocate (GtkWidget *widget,
start = start - end;
}
column = start * 30 / MINUTES_PER_DAY;
column = (int) floor (start * 30 / (double) MINUTES_PER_DAY);
#define Y_POSITION(cell_) (round (((cell_) * 30 % MINUTES_PER_DAY) * minutes_height))
#define Y_POSITION(row_) ((gint) round (((row_) * 30) * minutes_height))
start_row = start - column * 48;
end_row = (end + 1) - column * 48;
x = column * column_width;
y = Y_POSITION (start);
selection_height = Y_POSITION (end + 1) - y;
y = Y_POSITION (start_row);
selection_height = Y_POSITION (end_row) - y;
#undef Y_POSITION