Commit Graph
2263 Commits
Author SHA1 Message Date
Georges Basile Stavracas Neto 8f715c19b5 application: Move CSS providers to GcalWindow 2021-09-05 18:34:32 -03:00
Georges Basile Stavracas Neto 229b6f7add window: Silence a compilar warning 2021-09-05 18:07:27 -03:00
Georges Basile Stavracas Neto 52ef8ff6bf application: Only add CSS providers once
Instead of adding the color CSS provider over and over on
every activation, only add it once. Also make sure to start
the manager after doing that.
2021-08-19 14:26:06 -03:00
Georges Basile Stavracas Neto 7fd8babdda application: Activate on open
Otherwise, there might be no window available.
2021-08-16 19:48:09 -03:00
Georges Basile Stavracas Neto 7bf8d8851b application: Add weak ref to window 2021-08-16 19:47:54 -03:00
Georges Basile Stavracas Neto 440bb39498 window: Add weak pointer to import dialog
Otherwise we crash the second time it's opened.
2021-08-16 19:07:35 -03:00
Georges Basile Stavracas Neto e689f18b1e Add file importing dialog
Add a file importing dialog, and pass through files received from command
line.

Fixes https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/5
2021-08-16 18:26:21 -03:00
Georges Basile Stavracas Neto a080d8ec0f utils: Protect against NULL description 2021-08-16 15:27:19 -03:00
Georges Basile Stavracas Neto e90c67a57d manager: Ensure default calendar property is always set 2021-08-16 15:26:59 -03:00
Georges Basile Stavracas Neto aec1d8d5cd calendar-page: Add rounded corners to listbox 2021-08-06 17:37:40 -03:00
Georges Basile Stavracas Neto 8c71c60e8d calendar-management: Switch to HdyWindow
Make GcalCalendarManagementDialog an HdyWindow subclass,
and adapt the widgetry to work with the new parent class.

Use HdyHeaderBar everywhere.
2021-08-06 17:32:58 -03:00
Georges Basile Stavracas Neto 68160348dc Introduce GcalEventPopover
GcalEventPopover gives a preview of the event, and handy access
to the event description and information. It also allows easily
joining meetings if any one if available.

The list of supported meeting URLs is small now, but I hope
more people will contribute as we go.

It is also possible to edit the event through an edit button.
2021-06-27 18:45:12 -03:00
Georges Basile Stavracas Neto 01ee4a2b49 utils: Add Google extractor
Google events have an exotic section at the end of their event
descriptions, we can parse that to find some information like
the meeting URL.
2021-06-27 18:36:05 -03:00
Georges Basile Stavracas Neto 7079cf2a80 quick-add-popover: Properly localize string arrays
N_() only marks strings for translation, it is necessary to call gettext()
when using the strings.
2021-06-21 18:34:53 -03:00
Georges Basile Stavracas Neto bdce9b29ba quick-add-popover: Don't leak GDateTime
Not sure how this went through.
2021-06-21 18:34:52 -03:00
Georges Basile Stavracas Neto a7d40352b7 quick-add-popover: Mark string arrays const
As they really are.
2021-06-21 18:34:50 -03:00
Marco Trevisan (Treviño) fdb69db48a weather-service: Enable met.no provider
As per the switch to libgweather 40 with commits 216a8984 and a2a6d2e4
we already comply with met.no TOS [1] as we already provide explicitly
the application contact info and (implicitly, being a GApplication) the
application-id.

So we can enable the met.no weather provider, making the weather
forecast to work again.

[1] https://api.met.no/doc/TermsOfService

Fixes: https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/682
2021-05-31 20:02:36 +02:00
Sebastian Keller af7a17ef01 event: Fix multiday detection for all-day events
All-day events always use UTC, so when the multiday detection code was
converting them to the local timezone, they span an additional day if
the local timezone is not the same as UTC. This was leading to all-day
events always being considered multiday events.

Fix this by ignoring the timezone for all-day events, like all other
comparisons do. Also don't consider all-day events spanning 1 day to be
multiday since as per RFC 5545 the end date is non-inclusive and if
omitted to be start + 1 day.
2021-05-11 19:35:31 +00:00
Rajat Jain 19ee70f9ab window: Add missing keyboard shortcut
Add missing accelerator for <Alt>+Down as it was
mentioned in shortcuts dialog but not implemented.

Fixes #492

Signed-off-by: Rajat Jain <rajatjain.ix@gmail.com>
2021-05-11 19:11:31 +00:00
Sebastian Keller 44e2420645 range: Handle zero-length ranges when calculating overlap
Zero length ranges, such as for events without a DTEND could be
considered to overlap a range if they were at exactly the end of the
range. The end of a range however is the first date that is supposed to
not overlap, so a zero-length range on exactly this point should not be
considered overlapping.

This fixes cases where all-day events from the next month could show up
on the same day of the current month if they did not have a DTEND.

This also adds tests for all possible cases of such zero-length events
overlapping.

Fixes https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/701
2021-04-21 13:59:26 +00:00
Johannes Maibaum a2a6d2e4aa weather-service: Set contact_info to DOAP file URL
Currently, GNOME Calendar does not set up the contact_info needed in
libgweather 40 API. This leads to the following assertion, and no
weather forecast info being shown in Calendar:

`gweather_info_update: assertion 'info->contact_info != NULL' failed.`

To fix the assertion, set the URL to the DOAP file on the master branch.
GNOME Weather does the same, see:

https://gitlab.gnome.org/GNOME/gnome-weather/-/commit/6763f7dc9cb25eac4aa13e94e07ea932a42c8e4d

Part of #682
2021-04-13 01:07:37 +00:00
Johannes Maibaum 78d0df1404 window: Remove nested CLAMP() on switching views 2021-04-11 19:06:38 +02:00
Johannes Maibaum 4c51539168 window: Fix GcalWindow's change-view accelerators
Commit 2d5b1aa9d1 removed the
GCAL_WINDOW_VIEW_DAY variant of the GcalWindowView enum. Since then, the
change-view accelerators to switch to GCAL_WINDOW_VIEW_{WEEK,MONTH,YEAR}
were broken, as the accelerator setup was assuming
GCAL_WINDOW_VIEW_WEEK==1, which isn't true anymore with
GCAL_WINDOW_VIEW_DAY being gone.

This change fixes the enum values in the accelerator setup.
2021-04-11 19:06:05 +02:00
Sebastian Keller fb242dd109 time-zone-monitor: Use local timezone as fallback without dbus service
On systems without anything providing the org.freedesktop.timedate1
interface, the timezone returned by the monitor would always be NULL,
because it was never set. This can lead to crashes in places that expect
the monitor to always return a valid timezone. So in that case use the
local timezone from when the monitor got initialized.

Fixes https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/703
2021-04-11 00:27:08 +00:00
Sebastian Keller a0d24cd5d8 time-zone-monitor: Fix timezone leak on timezone changes
The old timezone was never being unref'ed before it got overwritten.
2021-04-11 00:27:08 +00:00
Georges Basile Stavracas Neto d1a0dbd8f5 event: Switch to g_time_zone_new_identifier()
And add the relevant NULL checks here.
2021-02-26 19:26:49 -03:00
Georges Basile Stavracas Neto 27c6d2c017 time-zone-monitor: Switch to g_time_zone_new_identifier()
We don't even need to check for NULL here because if the system timezone
is invalid, we're too screwed to have a fallback path anyway.
2021-02-26 19:26:49 -03:00
Georges Basile Stavracas Neto 64fe7e543c utils/date-time-utils: Use g_time_zone_new_identifier()
g_time_zone_new() is deprecated in favor of it, so use it.
2021-02-26 19:26:49 -03:00
Georges Basile Stavracas Neto 9800fbec4b utils/date-time-utils: Trivial style cleanup 2021-02-26 19:26:49 -03:00
Christopher Davis 709cfb75fa gui: Use HdyViewSwitcher
For GNOME 40 apps should migrate to use HdyViewSwitcher.
For now, this does not mean full adaptivity.
2021-02-14 16:34:13 +00:00
Eric Daigle a93ae8778a new-calendar-page: add callback for new calendar color chooser
The color chosen in the new calendar page is currently ignored
when creating a new calendar, as described in #681.

Added a callback similar to that used for the name text entry,
allowing new calendars to be created with the chosen color.

Closes https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/681
2021-02-14 16:01:11 +00:00
Michael Catanzaro 1740382963 Fix typo because I am hopeless 2021-01-12 16:39:47 -06:00
Michael Catanzaro 216a8984d4 Disable yr.no weather provider
See: #682
2021-01-12 15:56:53 -06:00
Michael Catanzaro 0733844690 Remove autocleanup for GWeatherLocation with new gweather 2021-01-12 15:08:50 -06:00
Georges Basile Stavracas Neto efe60e10d1 notes-section: Remove scrolled window
The entire dialog is wrapped under a scrolled window, it
doesn't make much sense to have yet another one for the
notes. This is a relif of times when the edit dialog didn't
have a scrolled window.

Remove the scrolled window of the notes section.
2020-11-10 15:00:59 +00:00
Georges Basile Stavracas Neto 7a5580980b summary-section: Use expandable entries
Now the entry grows as much as possible to accomodate the
text.

Fixes https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/153
2020-11-10 15:00:59 +00:00
Georges Basile Stavracas Neto b4fedbbba5 Introduce GcalExpandableEntry
This is simply a copy-past of GNOME To Do's GtdExpandableEntry.
2020-11-10 15:00:59 +00:00
Georges Basile Stavracas Neto d41af9f8a0 summary-section: Set max-width-char on entries
We want them to grow a bit more, and not let the expansion
of the title label detemine the width. Allow the location
and title entries to expand, and set a maximum width char
to 30 on them.

See https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/554
2020-11-10 15:00:59 +00:00
Dan Levin 8b251d5a98 reminders-section: Introduce 15 minute reminder
10 minute reminder is too little advanced notice. 30 minutes is too
much. Say hello to 15 minute reminder.
2020-11-02 17:05:31 +01:00
Georges Basile Stavracas Neto a146b9050d project: Silence CI warnings 2020-10-31 16:55:06 -03:00
Georges Basile Stavracas Neto 06f0c4d011 schedule-section: Make date & time labels dim
They should have been dim labels since the beginning, this was an
oversight.
2020-10-31 16:15:54 -03:00
Georges Basile Stavracas Neto b481b40381 schedule-section: Mark date & time labels as action children
Otherwise they appear inside the expanded section, and not outside like
we wanted. This was a regression from the libhandy 1.0 port.
2020-10-31 16:15:54 -03:00
Georges Basile Stavracas Neto b725d25b86 schedule-section: Remove useless labels
They're placeholders, and always overriden. Remove them.
2020-10-31 16:15:54 -03:00
Georges Basile Stavracas Neto 968ae16e08 window: Use leaf type for GcalEventEditorDialog
We're casting either way, to at least let's cast to something
that requires fewer characters.
2020-10-31 16:15:54 -03:00
Georges Basile Stavracas Neto 4c24103bae event-editor-dialog: Make 'event' property read-only
It is not meant to be set externally.
2020-10-31 16:15:54 -03:00
Georges Basile Stavracas Neto b0cdca78b1 event-editor-dialog: Unify set_event and set_event_is_new
The split is annoying, and a relic of time.
2020-10-31 16:15:54 -03:00
Georges Basile Stavracas Neto 7e10c6d451 event-editor-dialog: Stop using response type
Using dialog responses to communicate intent to GcalWindow was always
a hack, and as the code is cleaned, it's getting increasingly annoying.

Replace this with a proper 'remove-event' signal ('delete-event' would
conflict with the equally named GTK signal), remove the custom response
types, and cleanup the code.
2020-10-31 16:15:54 -03:00
Georges Basile Stavracas Neto 1480d7ac70 event-editor-dialog: Code cleanup
Use g_autofoo when possible; avoid allocating new strings when fetching
from GVariant; sort and reorder fields.
2020-10-31 16:15:54 -03:00
Georges Basile Stavracas Neto c098dc7aa7 event-editor-dialog: Store sections in an array
It allows us to simplify some boring copy-pasted code.
2020-10-31 16:15:54 -03:00
Georges Basile Stavracas Neto 3a9f9009a4 event-editor-dialog: Remove dead code
These weren't being used anywhere.
2020-10-31 16:15:54 -03:00