Commit Graph
100 Commits
Author SHA1 Message Date
Georges Basile Stavracas Neto 5a6fabddc8 window: Rework property creation 2018-01-27 14:28:55 -02:00
Georges Basile Stavracas Neto 333fa79437 resources: Don't strip XML blanks
It only makes it harder to debug, and we gain effectively
nothing from that.
2018-01-27 14:27:16 -02:00
Georges Basile Stavracas Neto 845eed5cea ci: Use a Rawhide image
We depend on an unstable version of GWeather.
2018-01-27 12:52:14 -02:00
Georges Basile Stavracas Neto 50a5bbefaf ci: Add libgweather dependency 2018-01-27 12:31:08 -02:00
Georges Basile Stavracas Neto 4f4b10baab ci: update to Fedora 27
We should eventually add Ubuntu too.
2018-01-27 12:14:24 -02:00
Georges Basile Stavracas Neto fe40a97926 project: Add missing dependencies to CI 2018-01-27 11:57:47 -02:00
Georges Basile Stavracas Neto 519de35520 project: Change build stage name to 'build-calendar' 2018-01-27 11:49:22 -02:00
Georges Basile Stavracas Neto e4062c7952 project: Add CI integration 2018-01-27 13:47:46 +00:00
Georges Basile Stavracas Neto a853e85293 project: delete configure script
Let's use raw Meson from now on.
2018-01-27 11:41:28 -02:00
Georges Basile Stavracas Neto 6c203d55c4 build: Remove even more dead code 2018-01-27 00:52:45 -02:00
Georges Basile Stavracas Neto dd1e82e761 Merge branch 'meson-improvements' into 'master'
Meson improvements

See merge request GNOME/gnome-calendar!25
2018-01-27 01:58:52 +00:00
Georges Basile Stavracas Neto d68b45038c project: update TODO 2018-01-16 08:32:43 -02:00
Georges Basile Stavracas Neto f0a2a43438 Merge branch 'master' into 'master'
week-view: display "12 PM" correctly

See merge request GNOME/gnome-calendar!22
2018-01-10 16:08:08 +00:00
Georges Basile Stavracas Neto e72f7356c1 Merge branch 'master' into 'master'
Issue #228 : Add --quit command line argument

See merge request GNOME/gnome-calendar!17
2018-01-10 15:33:31 +00:00
Georges Basile Stavracas Neto e63f55f8b9 Merge branch 'wip/piotrdrag/placeholder-translations' into 'master'
ui: Unmark placeholder strings from translation

See merge request GNOME/gnome-calendar!18
2018-01-03 16:51:13 +00:00
Georges Basile Stavracas Neto b8f51e1d3d window: a load more weather changes 2017-12-17 11:35:19 -02:00
Georges Basile Stavracas Neto 61b9ba85a2 month-view: cleanup includes 2017-12-16 23:52:06 -02:00
Georges Basile Stavracas Neto 9f1885d807 weather-service: use GPtrArray for public API
Using GLists and GSLists is a bad practice. These data
structures are too much inneficient and GPtrArray has
the advantage of having a free function pointer, so we
can hide the underlying free function from the consumers
of this API.

This also gets rid of another allocation cycle in Month
view.
2017-12-16 23:12:06 -02:00
Georges Basile Stavracas Neto dcf4ff0bda views: more weather service cleanups
Did I ever say how happy I'll be when people start
actually following my code style when densing code
to my projects?
2017-12-16 22:36:39 -02:00
Georges Basile Stavracas Neto d283316382 views: simplify reference leak workaround
Oh so many unecessary casts =(
2017-12-16 21:49:22 -02:00
Georges Basile Stavracas Neto 5c1bf907fa views: move :event-activated signal to GcalView
We don't really need to copy this signal to every GcalView
implementation. It's just wasting code.
2017-12-16 21:44:09 -02:00
Georges Basile Stavracas Neto c306bbc1ef month-view: properly cleanup weather data from cells 2017-12-16 21:34:31 -02:00
Georges Basile Stavracas Neto b70f3fa0b6 month-view: fix another allocation cycle 2017-12-12 11:06:46 -02:00
Georges Basile Stavracas Neto d2dea218ae view: pass the correct property value
It should be a pointer to a GcalWeatherService, not a pointer
to a pointer to a GcalWeatherService.
2017-12-12 11:06:07 -02:00
Georges Basile Stavracas Neto 92f054fc12 project: update Flatpak manifest 2017-12-12 11:04:42 -02:00
Georges Basile Stavracas Neto d42a943e4d Merge branch 'gweather-api-fix' into 'master'
Adapt to the libgweather API changes

See merge request GNOME/gnome-calendar!15
2017-12-12 12:00:52 +00:00
Georges Basile Stavracas Neto 8670c6fd8e source-dialog: cast to GtkWidget* before increasing refcount
So that we check for the right type.
2017-12-11 23:22:42 -02:00
Georges Basile Stavracas Neto 23a9de1108 weather-service: major reorganization and cleanup
To make it more like the actual code style of GNOME Calendar.

Hope Florian doesn't get (too) mad of me removing and modifying
so much on his code. I'm sorry dude, my OCD didn't allow me to
just flood the gate.
2017-12-11 23:10:55 -02:00
Georges Basile Stavracas Neto fcd9fa1c31 Merge "utils: reworked uri splitting with help of libsoup"
See merge request GNOME/gnome-calendar!14
2017-12-11 23:07:30 +00:00
Georges Basile Stavracas Neto 4f02a3e97f Merge branch 'add-className' into 'master'
Add a topWindow class with the app's reversed domain name

See merge request GNOME/gnome-calendar!13
2017-12-07 12:50:50 +00:00
Georges Basile Stavracas Neto d3232e664f Merge branch 'wip/sadiq' into 'master'
window: Simplify saving/loading window states

See merge request GNOME/gnome-calendar!9
2017-12-06 13:53:05 +00:00
Georges Basile Stavracas Neto 06f4a5b182 Merge branch 'mcatanzaro/leak' into 'master'
event: Fix a minor leak

See merge request GNOME/gnome-calendar!6
2017-12-06 11:04:02 +00:00
Georges Basile Stavracas Neto 89e90fec6d Merge branch 'wip/mcatanzaro/timezone' into 'master'
Events created in month or year view are created with incorrect time and missing timezone

Closes #168

See merge request GNOME/gnome-calendar!7
2017-12-06 10:45:42 +00:00
Georges Basile Stavracas Neto 276ecef0eb Merge branch 'wip/mcatanzaro/tooltips' into 'master'
event-widget: Fix time in tooltip text

Closes #225

See merge request GNOME/gnome-calendar!8
2017-12-06 10:40:51 +00:00
Georges Basile Stavracas Neto bbbabecc58 Merge branch 'master' into 'master'
Add <Ctrl>+f shortcut to activate search bar.

See merge request GNOME/gnome-calendar!5
2017-12-05 23:13:44 +00:00
Georges Basile Stavracas Neto 8c4a0ca613 event-widget: always hide color box on vertical events
Otherwise we get weird borders on Week view.
2017-12-01 11:26:59 -02:00
Georges Basile Stavracas Neto a2b66f212f project: ignore more folders 2017-11-30 14:45:47 -02:00
Georges Basile Stavracas Neto e8468ec0df event-widget: use a 16px rounded rectangle for event colors
This looks better than the thin borders, helps a lot colorblind
people and makes the overall layout just as good.

Ship it!

[#211]
2017-11-30 14:45:47 -02:00
Georges Basile Stavracas Neto 3c6df94be9 Merge branch 'nextcould-translations' into 'master'
project: update Nextcloud in translations

See merge request GNOME/gnome-calendar!4
2017-11-28 23:56:59 +00:00
Georges Basile Stavracas Neto 141e631f22 Merge branch 'issues/220' into 'master'
doc: add an issue template

Closes #220

See merge request GNOME/gnome-calendar!2
2017-11-28 14:41:48 +00:00
Georges Basile Stavracas Neto 0e1404a11b flatpak: use GitLab url 2017-11-27 13:30:51 +00:00
Georges Basile Stavracas Neto ea8b9e76e7 event-widget: use a stack to handle orientation
Instead of setting the position of the labels in a grid,
use two different grids and switch between them using a
stack.
2017-11-25 11:43:52 -02:00
Georges Basile Stavracas Neto f8ce4937c2 month-view: move variables around
Just to make it clear that these variables are only used when
we really need to reprocess the event widgets.
2017-11-25 11:43:52 -02:00
Georges Basile Stavracas Neto 63f3078a80 week-grid: don't try to optimize allocation
This is making the week grid miss some valid reallocation
cases.
2017-11-25 11:43:52 -02:00
Georges Basile Stavracas Neto cbcffe3bcd trivial: remove obsolete TODO 2017-11-21 22:51:57 -02:00
Georges Basile Stavracas Neto e73240bc9a trivial: style fix 2017-11-21 20:13:28 -02:00
Georges Basile Stavracas Neto e34964802c month-view: remove unused variable 2017-11-21 20:13:28 -02:00
Georges Basile Stavracas Neto 7e2601e1a2 project: add the right file to the resources 2017-11-19 13:52:39 -02:00
Georges Basile Stavracas Neto a3d1bfcfc5 application: load custom css files
So that theme maintainers can drop their CSS here,
and make Calendar look beautiful everywhere.
2017-11-19 13:42:11 -02:00
Georges Basile Stavracas Neto 41fb5c83d6 theme: fine tune line color 2017-11-19 13:34:23 -02:00
Georges Basile Stavracas Neto bb2566dab8 month-view: hide last row if it's empty
This can make it put up to 5 events in my 1366x768 screen!

\o/
2017-11-19 12:29:29 -02:00
Georges Basile Stavracas Neto 0f1a8c93f2 month-view: fix hiding event widgets when removing 2017-11-19 12:18:32 -02:00
Georges Basile Stavracas Neto 1f1e351c47 month-view: remove useless field
This also fixes the bug where changing the text
direction doesn't reposition the event widgets.
2017-11-19 12:11:02 -02:00
Georges Basile Stavracas Neto 2e750b69e5 month-view: reorganize code
This is another major reorganization of the Month view's
allocation code. The goal is not to reduce the number
of lines, but to make them readable and maintainable.

During this reorganization, multiple bugs that were never
hit were ironed out! That itself would be a major win, but
since the code is actually more readable, we can expect
more improvements from now on.
2017-11-19 12:05:52 -02:00
Georges Basile Stavracas Neto 192e860edc trivial: style fix 2017-11-18 21:57:25 -02:00
Georges Basile Stavracas Neto 9fa9de2df7 month-view: use a custom structure to help multiday allocation
Instead of using 3 different, barely synchronized arrays. This
makes the code easier to read, and is more semantic too.
2017-11-18 21:57:25 -02:00
Georges Basile Stavracas Neto 7af8dd3c40 Bump 3.27.2 release 2017-11-15 21:31:35 -02:00
Georges Basile Stavracas Neto 34d20a07ec month-popover: remove leftover comment 2017-11-15 21:04:46 -02:00
Georges Basile Stavracas Neto 4d23949a99 month-view: properly update today mark
https://bugzilla.gnome.org/show_bug.cgi?id=775103
2017-11-15 20:15:28 -02:00
Georges Basile Stavracas Neto 7470db159d flatpak: add libdazzle 2017-11-15 20:04:07 -02:00
Georges Basile Stavracas Neto a66ff3bf85 Merge branch 'wip/gbsneto/month-cell-subwindow' 2017-11-15 19:25:39 -02:00
Georges Basile Stavracas Neto 54839efbf4 month-view: fix rtl
This removes much of the subtle complexities of the size allocation
function in month view, and finally delivers a readable and working
implementation of the month view.

This also introduces a small code refactoring, and fixes clicking
on a cell on RTL.
2017-11-15 19:03:10 -02:00
Georges Basile Stavracas Neto b638a1537c event-widget: also compare by multiday 2017-11-15 15:32:37 -02:00
Georges Basile Stavracas Neto 09cd5d05cb month-popover: sort events 2017-11-15 03:17:04 -02:00
Georges Basile Stavracas Neto 72b9b34235 month-view: win the fight against the sizing machinery
We can now guarantee that the month cells unconditionally get
their desired allocations, but the event widgets are only created
when necessary.

I won.
2017-11-15 02:31:03 -02:00
Georges Basile Stavracas Neto eff50668d4 month-view: introduce new overflow popover window
This ~almost~ implements a perfectly semantic transition (which
is kinda impossible now).
2017-11-15 02:03:26 -02:00
Georges Basile Stavracas Neto 8d6785b6f7 month-view: implement a different hiding algorithm
As if the previous one wasn't crazy enough :(
2017-11-13 19:27:55 -02:00
Georges Basile Stavracas Neto b4cc36b344 month-view: fight the sizing machinery even harder
Make sure something changed in child widgets AND events,
otherwise just top allocating at all.
2017-11-13 17:06:38 -02:00
Georges Basile Stavracas Neto 31409b6e44 month-view: improve layout algorithm
Multiday event handling was a mess, and still it. But this commit
makes it at least layout things correctly.

It's not perfect, though; This commit brought back that terrible
allocation cycle issue, since we're showing and hiding events in
size-allocate.
2017-11-13 14:23:35 -02:00
Georges Basile Stavracas Neto 2c9f7e2041 month-view: reorganize header 2017-11-13 12:44:04 -02:00
Georges Basile Stavracas Neto 86b565a817 month-view: Improve code readability
No real changes except code reorganization and refactoring, just
to make it a little bit less painful to read and maintain.
2017-11-13 12:40:45 -02:00
Georges Basile Stavracas Neto 2a11959bdd month-cell: show +X in overflow label
Instead of "Other X Events".
2017-11-11 18:15:18 -02:00
Georges Basile Stavracas Neto b5ad149261 month-cell: improve calculation of header box height
Should also consider the top and bottom margins.
2017-11-11 18:15:02 -02:00
Georges Basile Stavracas Neto 432e7ab7ea month-cell: move day label to the start of the cell 2017-11-11 18:08:22 -02:00
Georges Basile Stavracas Neto 4dd4c2410f month-cell: Move day label to top, split from overflow 2017-11-11 17:48:59 -02:00
Georges Basile Stavracas Neto af90070cf4 doap: remove Isaque and Erick as maintainers
They don't maintain it anymore.
2017-11-11 17:35:01 -02:00
Georges Basile Stavracas Neto 1968151114 project: add libdazzle dependency 2017-11-11 17:33:49 -02:00
Georges Basile Stavracas Neto caffb60065 utils: add autoptr support for ESource 2017-11-08 23:26:25 -02:00
Georges Basile Stavracas Neto 5977eeefc8 month-cell: only update label when date changes
If the date is the same, we don't need to update the label.
This might cause an infinite resize loop.
2017-10-31 01:11:26 -02:00
Georges Basile Stavracas Neto 907e55ccbe month-view: remove reminescent dnd code
Month view does not manage Drag n' Drop anymore, but
this code was left behind by accident.
2017-10-31 01:00:15 -02:00
Georges Basile Stavracas Neto 1e54c9db12 month-view: only idle add month cell update when necessary 2017-10-31 00:34:45 -02:00
Georges Basile Stavracas Neto 523609f2c0 month-view: always update month cells in idle
This way, we can schedule the multiple resizing queueing
operations to after the size-allocate phase is over.
2017-10-29 19:05:42 -02:00
Georges Basile Stavracas Neto e04b7f0fd3 event-widget: lazily relayout main grid 2017-10-29 19:05:34 -02:00
Georges Basile Stavracas Neto 2357f5d766 month-cell: draw out-of-month cell day labels differently 2017-10-07 11:41:00 -03:00
Georges Basile Stavracas Neto 3411dbb13d month-view: don't outsmart GTK resizing machinery
If we need to resize, then let's just accept we need to
resize the month view (event if that's an expensive
operation) and do the resizing.

This fixed many minor annoyances like invisible overflow
labels, on-the-fly text direction changes, etc.
2017-10-07 11:40:48 -03:00
Georges Basile Stavracas Neto a5e733f705 month-cell: don't enbold overflow label
Only the day label should be made bold.
2017-10-07 11:27:56 -03:00
Georges Basile Stavracas Neto ff9c663c8c month-view: only update selection if there's a start date
We can potentially not have an end date set, but there's always
a start date. If there isn't, it means the user clicked from
outside of month view, or at an invalid cell, in which cases we
shouldn't display the quick add popover anyway.
2017-10-07 11:20:23 -03:00
Georges Basile Stavracas Neto a0c224a0d5 edit-dialog: alarm rows are not activatable
Otherwise, they show that annoying hover effect
that is ultimately useless, since clicking on the
row won't do anything.
2017-10-07 11:08:51 -03:00
Georges Basile Stavracas Neto df40a4d8bf month-view: don't hide month view when dragging from popover 2017-10-07 11:01:32 -03:00
Georges Basile Stavracas Neto 37fb5e8492 month-view: fix event positioning on RTL locales
We have to pick the mirrored column index on RTL locales.
2017-10-06 21:23:05 -03:00
Georges Basile Stavracas Neto f83471c609 window: trivial code refactoring 2017-10-06 20:32:00 -03:00
Georges Basile Stavracas Neto 999160495d log: accept NULL log domains 2017-10-06 20:32:00 -03:00
Georges Basile Stavracas Neto e59910f0e9 month-view: rewrite was a template widget 2017-10-06 20:32:00 -03:00
Georges Basile Stavracas Neto b9310a84a3 widgets: ensure types on class_init
This will avoid GtkBuilder crashing because it couldn't
find the correct type for a given widget.
2017-09-20 19:14:15 -03:00
Georges Basile Stavracas Neto 8a2376ae55 event: refactor gcal_event_is_multiday 2017-09-14 14:05:53 -03:00
Georges Basile Stavracas Neto 349839ee49 event-widget: make font relative to initial font size 2017-09-14 13:50:43 -03:00
Georges Basile Stavracas Neto 4262f2fb25 project: update meson file code style 2017-09-14 13:31:19 -03:00
Georges Basile Stavracas Neto f486569e19 week-grid: improve positioning code 2017-09-14 13:31:04 -03:00
Georges Basile Stavracas Neto 925e17e16c event-widget: fix dragging events 2017-09-14 13:26:28 -03:00
Georges Basile Stavracas Neto d099f0f243 event-widget: use semibold for hour label
We want to emphasize the hour, but not so much.
2017-09-14 13:26:28 -03:00