Federated_Computer/federated-calendar
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
565 Commits 3 Branches 0 Tags
5397a1e4ba43debe6bc1230d92ed471c168102bb
Commit Graph
565 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Erick Pérez Castellanos 5397a1e4ba edit-dialog: fix wrongly updating ECalComponent 
GcalEditDialog::clear_data was clearing the summary on the internal
ECalComponent instance. Blocking signal handler call allow to clear the
widget without clearing the component.

Bug: https://bugzilla.gnome.org/show_bug.cgi?id=739307
 2014-12-04 17:10:48 -05:00
Erick Pérez Castellanos de90213fd7 month-view: fix cell rendering glitch 
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=739294
 2014-12-04 17:10:48 -05:00
Georges Basile Stavracas Neto b8a4812f3b edit-dialog: don't keep an internal cached version of the summary 
This is part of the Edit dialog's redesign.

Fixes bug #739268.
 2014-12-04 17:10:48 -05:00
Erick Pérez Castellanos 74c9f009d8 edit-dialog: show events description, minor tweaks 2014-12-04 17:10:48 -05:00
Erick Pérez Castellanos eb436f57db window: update setting when the view changes 
Note: Eventually I ended reverting the changes I have made here a few
commits back.
 2014-12-04 17:10:48 -05:00
Erick Pérez Castellanos 1c98dd5c04 window: fix update labels on view change 
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=739039
 2014-12-04 17:10:48 -05:00
Erick Pérez Castellanos e873503744 app: added search-view to window views enum 2014-12-04 17:10:48 -05:00
Erick Pérez Castellanos 852c5eda9f style: remove duplicated '_subscriber' prefix 2014-12-04 17:10:48 -05:00
Erick Pérez Castellanos 9ffabe03ba week-view: fix unref of not added widget 
This works in conjunction with code implemented in GcalSubscriber where
the ownership of the event widget passes into the container, so the
container is free to delete it in case it does not fit into the range
represented by the view.
 2014-12-04 17:10:47 -05:00
Erick Pérez Castellanos 48bcb57363 week-view: rename internal method 
Note: The body of the method was added by mistake on the previous
commit. This commit make the code build again.
 2014-12-04 17:10:47 -05:00
Erick Pérez Castellanos dc21b70760 week-view: add subscriber range update 
Remove unneeded GcalView deprecated method.
Hook event widget activation
 2014-12-04 17:10:47 -05:00
Erick Pérez Castellanos dd2a0da883 misc: fix styling issues and gcc warnings 
Update code style
 2014-12-04 17:10:47 -05:00
Erick Pérez Castellanos d7d8dd94ee window: update date on view on binding creation 
Ensure the views has events widgets in it for the first time the user
clicks on it.
 2014-12-04 17:10:47 -05:00
Erick Pérez Castellanos 4bdc696b54 window: update_view when the property changes 
Update the value of the internal holder of the property
 2014-12-04 17:10:47 -05:00
Erick Pérez Castellanos f988eac12f view iface: remove more unused methods 
GcalView::draw_event overlapped a bit with GcalView::will_add_event, so
the same reasons for removing one stand for the other.
GcalView::clear was a hack for the composited GcalDayView which has
gone, and was a bad experiment.
 2014-12-04 17:10:47 -05:00
Erick Pérez Castellanos 5422066bb0 view iface: another round at cleaning 
Remove unused methods laying there for a long time now.
 2014-12-04 17:10:47 -05:00
Erick Pérez Castellanos 8e066850a3 window: added New Event item to menu button 
Updated label on app-menu action.
 2014-12-04 17:10:47 -05:00
Erick Pérez Castellanos defb99d8a8 window: replace New Event with Today button 
As Lapo rightfully explain, providing a button there for creating a new
event is way to prominently and might divert users of the intended click
on a cell behavior to create an event.
New event will be also accessible from the hamburger icon on the left of
the header-bar and Ctrl-N key shortcut.
Also as Lapo suggestion Today button fall better on the header bar than
between the navigation buttons.
 2014-12-04 17:10:46 -05:00
Erick Pérez Castellanos 28be6bc581 window: remove FIXME comment 
edit_dialog_closed already hides the widget. Reminder is not needed anymore
 2014-12-04 17:10:46 -05:00
Erick Pérez Castellanos 18b4ef8186 month-view: remove FIXME 
Subscription is already being made. Remove reminder.
 2014-12-04 17:10:46 -05:00
Erick Pérez Castellanos 6f2b01018f view iface: remove unused will_add_event 
ECalDataModelSubscriber interface notify each view only about the events
beloging to the subscribed range so there's no need of checking if the
event widget will be added.
The safety check of not adding the same widget twice its stil being made
on each GtkContainer::add implementation.
 2014-12-04 17:10:46 -05:00
Erick Pérez Castellanos c7e27c7ef4 year-view: makes a descendant of GcalSubscriber 2014-12-04 17:10:46 -05:00
Erick Pérez Castellanos aca1b66743 month-view: makes a descendant of GcalSubscriber 
By making GcalMonthView a descendat of GcalSubscriber it gets
implementation for each of the methods on ECalDataModel subscriber and
utomatically gains the functionality of adding and removing events widgets
 2014-12-04 17:10:46 -05:00
Erick Pérez Castellanos cfb2c39a7d build: add GcalSubscriber abstract class 
GcalSubscriber abstract class is meant for handling the implementation
of ECalDataModelSubscriber interface. The code in each vfunc implemented
is the same for each view, then it makes sense to have a class holding
these implementations and make every views descend from it. This class
sits in the middle between GtkContainer and each of the views.
 2014-12-04 17:10:46 -05:00
Erick Pérez Castellanos 605cb7fc25 build: stop complaints from gcc 
Gcc complaints this variable may be used uninitialized
 2014-12-04 17:10:46 -05:00
Erick Pérez Castellanos 37f0e8ecfd style: add entry class to notes textview 2014-12-04 17:10:46 -05:00
Erick Pérez Castellanos 68a427528c manager: fix remove source from ECalDataModel 
When a source is removed should be removed from the internal
ECalDataModel instance as well
 2014-12-04 17:10:45 -05:00
Erick Pérez Castellanos 772fa7b586 manager: remove internal date range 
This is not needed since the range is kept by ECalDataModel instance
 2014-12-04 17:10:45 -05:00
Erick Pérez Castellanos 792c6a9cec manager: remove internal query 
The internal query is not needed since that's handled now by the
ECalDataModel instance
 2014-12-04 17:10:45 -05:00
Erick Pérez Castellanos 5f8cadb650 manager: fix clients' hash construction 
free_manager_unit should have been removed from clients construction previously
 2014-12-04 17:10:45 -05:00
Erick Pérez Castellanos 4c0938e5cb manager: free clients' hash-table with g_free 
Since ECalDataModel keeps a ref to the connected EClients there's no
need of keeping another and using a custom free function for clients' hash
 2014-12-04 17:10:45 -05:00
Georges Basile Stavracas Neto 37be39e9d0 edit-dialog: implement composite widget of edit dialog 
Also, this patch implements a major design review of the dialog.
 2014-12-04 17:10:45 -05:00
Erick Pérez Castellanos 08d9cd8e9b theme: remove unneeded rules 2014-12-04 17:10:45 -05:00
Erick Pérez Castellanos 9b281eff69 month-view: implement ECalDataModel::components_modified vfunc 2014-12-04 17:10:45 -05:00
Georges Basile Stavracas Neto 19d380e80f project: replace GdkColor by GdkRGBA 
Fixes bug #738553
 2014-12-04 17:10:45 -05:00
Erick Pérez Castellanos 39318534cd window: fix focus issue when creating event 
https://bugzilla.gnome.org/show_bug.cgi?id=738858
 2014-12-04 17:10:44 -05:00
Erick Pérez Castellanos 3805496dbb event-widget: fix memory leak. 
According to valgrind pango leaks memory when creating a PangoLayout
using gtk_widget_create_pango_layout with a literal string.
 2014-12-04 17:10:44 -05:00
Erick Pérez Castellanos c2eda0e446 event-widget: fix memory corruption 
GdkRBA should not be allocated using g_new0. Used G_SLICE=debug-blocks
to find it.
 2014-12-04 17:10:44 -05:00
Erick Pérez Castellanos cf96da6308 memory: fix memory leaks scattered around 2014-12-04 17:10:44 -05:00
Erick Pérez Castellanos a158fc5757 application: handle ref count of GtkCssProvider correctly 
It seems gtk_style_context_add_provider_for_screen increase the ref
count of the GtkCssProvider (maybe copy it to GdkScreen and this isn't
releasing it correctly). We're forcing an _unref to keep the destruction
process working as expected. Previously gtk_css_provider_finalize was
not called at any time on the closing process.
 2014-12-04 17:10:44 -05:00
Erick Pérez Castellanos 6c7593dbb1 application: free properties' memory on finalize 
Note: GtkCssProvider doesn't finalize correctly yet, but it is correct
to clear the reference belonging to the application.
 2014-12-04 17:10:44 -05:00
Erick Pérez Castellanos fb2461b813 application: properly quit application 
Fixes destruction process. Calling g_application_quit skip the reference
decreasing process of GApplication and that resulted in a bunch of
_finalize methods not being called. By removing the windows GApplication
finalize properly.
 2014-12-04 17:10:43 -05:00
Erick Pérez Castellanos ed32e8d624 application: do not access instance data on _new 
The settings setup could be delayed to _init vfunc of the
application.
 2014-12-04 17:10:43 -05:00
Erick Pérez Castellanos bddf1d2104 event-widget: fixed memory leak 
Each property was owned by the widget, and I was not freeing its memory
at destruction time
 2014-12-04 17:10:43 -05:00
Erick Pérez Castellanos d37347418b month-view: implement ECalDataModel::components_removed vfunc 
Previous fixes on GcalEventWidget allow to use the recurid in order to
differentiate instances of the same event.
 2014-12-04 17:10:43 -05:00
Erick Pérez Castellanos a9b302b205 month-view: fix double free of the passed component 2014-12-04 17:10:43 -05:00
Erick Pérez Castellanos 2b92e0977f event-widget: include recurid on event uuid 
By taking recur id into event uuid we are able to properly handle events recurrences
 2014-12-04 17:10:43 -05:00
Erick Pérez Castellanos c777d4c852 views: use new comparison function 2014-12-04 17:10:42 -05:00
Erick Pérez Castellanos ab2050b695 month-view: change widget comparison for inclusion 
Using new function ensure checking recurid besides everything else
 2014-12-04 17:10:42 -05:00
Erick Pérez Castellanos 2a100b5fce event-widget: add method to test equality 2014-12-04 17:10:42 -05:00