Commit Graph
100 Commits
Author SHA1 Message Date
Georges Basile Stavracas Neto 4fb135f7dc theme: improve spacing in month view 2018-04-30 22:03:52 -03:00
Georges Basile Stavracas Neto b6df8cde7b manager: fix reference management
GcalManager:remove_event() is an asynchronous function
that, by the time the callback is executed, unreferences
the event that is being removed. This implies that, when
the function was called, a reference was taken -- we don't
want the event to be finalized during the operation, after
all.

The problem is that the reference was never taken.

Fix that by properly owning a reference to the event when
removing it, and dropping it when the removal is finished.

Issue: #268
2018-04-30 21:26:03 -03:00
Georges Basile Stavracas Neto bc0744cc0d tests: update multiday test
Until we have a better control over the system timezone,
let's not hit that issue.
2018-04-30 20:45:46 -03:00
Georges Basile Stavracas Neto 91fdf1783b event: improve documentation for gcal_event_is_multiday
Add some examples, so I can remember them in a few days from
now.
2018-04-30 20:45:01 -03:00
Georges Basile Stavracas Neto 65b00e5a23 flatpak: build documentation too 2018-04-30 20:44:39 -03:00
Georges Basile Stavracas Neto 5ff7afab88 build: rename gtk_doc to documentation 2018-04-30 20:35:24 -03:00
Georges Basile Stavracas Neto bedc98b192 event: fix multiday check
Checking if an event is multiday is currently broken
because g_date_time_difference() returns raw time spans,
and that value means "there is 24h of difference between
these dates", when what we're looking for is "how many
days are between these two dates".

To fix that, use the GDate API instead of GDateTime.
2018-04-30 19:31:01 -03:00
Georges Basile Stavracas Neto 61b7845b5a Bump 3.29.0 release 2018-03-05 16:14:32 -03:00
Georges Basile Stavracas Neto 8cfb66aaed GNOME Calendar 3.27.92 2018-03-05 16:07:12 -03:00
Georges Basile Stavracas Neto 41c8804450 tests: add more event tests 2018-02-27 14:57:34 -03:00
Georges Basile Stavracas Neto a8350555da event: trivial cleanups 2018-02-27 14:57:20 -03:00
Georges Basile Stavracas Neto c51957f214 test: properly initialize variables 2018-02-26 23:39:15 -03:00
Georges Basile Stavracas Neto bc3a41d96c tests: Add event test 2018-02-26 23:18:54 -03:00
Georges Basile Stavracas Neto 3b860ece2e utils: add autoptr support to ECalComponent 2018-02-26 23:18:10 -03:00
Georges Basile Stavracas Neto e630c12f01 tests: reorganize meson file 2018-02-26 22:16:02 -03:00
Georges Basile Stavracas Neto f19bf803ba docs: update CONTRIBUTING.md 2018-02-23 16:11:36 -03:00
Georges Basile Stavracas Neto 1234dd8292 manager: small cleanup
Use g_clear_pointer()
2018-02-23 15:48:15 -03:00
Georges Basile Stavracas Neto 6ce9aa2f3f ci: make test verbose 2018-02-23 15:48:15 -03:00
Georges Basile Stavracas Neto e7ecf6a915 Revert "ci: Install project before running tests"
This reverts commit 3bf88e2103.
2018-02-21 19:24:09 +00:00
Georges Basile Stavracas Neto 3bf88e2103 ci: Install project before running tests 2018-02-21 16:55:48 +00:00
Georges Basile Stavracas Neto 528c1b32f0 ci: Add missing geoclue2-devel dependency 2018-02-20 22:06:38 +00:00
Georges Basile Stavracas Neto d64a03a57d ci: Rework CI steps 2018-02-18 19:01:46 +00:00
Georges Basile Stavracas Neto bd0b16c58f flatpak: Trivial style update 2018-02-18 19:01:24 +00:00
Georges Basile Stavracas Neto 9984a3a1e7 Bump 3.27.90 release 2018-02-12 00:07:51 +00:00
Georges Basile Stavracas Neto c60a881ca3 event: Use G_DEFINE_QUARK 2018-01-30 02:07:47 -02:00
Georges Basile Stavracas Neto cc45db2354 appdata: Update bugtracker URL 2018-01-30 02:01:33 -02:00
Georges Basile Stavracas Neto 05f8446aa9 style: Remove tabs 2018-01-30 01:59:20 -02:00
Georges Basile Stavracas Neto 832e0e3599 style: Fix CSS for selected month cells 2018-01-30 01:58:39 -02:00
Georges Basile Stavracas Neto 503191377f application: More code style cleanup and reorganization 2018-01-30 01:30:59 -02:00
Georges Basile Stavracas Neto ab259fe57b date-selector: Use parameter specs to declare properties 2018-01-30 01:10:43 -02:00
Georges Basile Stavracas Neto f83826515e edit-dialog: Use parameter specs to define properties 2018-01-30 01:10:25 -02:00
Georges Basile Stavracas Neto f3b4f68bf0 event: Use parameter specs to declare properties 2018-01-30 01:10:08 -02:00
Georges Basile Stavracas Neto 2856131064 flatpak: Make master builds traceable and run with --debug 2018-01-30 00:39:05 -02:00
Georges Basile Stavracas Neto 37283f7d38 flatpak: Update to libical 3.0.1 2018-01-30 00:39:05 -02:00
Georges Basile Stavracas Neto 8892c31379 week-view: Remove embarrassing debug message 2018-01-28 12:50:04 -02:00
Georges Basile Stavracas Neto 09b986f526 quick-add-popover: Only remove existing rows
We can receive the source-changed signal on read-only sources,
and these sources have no row associated. Trying to remove the
non-existing row would yield a warning.
2018-01-28 12:45:57 -02:00
Georges Basile Stavracas Neto f698981aa8 application: Improve order of statup
This commit makes sure that logging is set before
actually logging anything. It also sychronizes the
application startup with the manager startup.
2018-01-28 12:39:13 -02:00
Georges Basile Stavracas Neto 194407ecfb views: Instrument and fix reference leaks 2018-01-28 12:08:04 -02:00
Georges Basile Stavracas Neto 58b3340736 window: Remove dead code
An unused variable and a binding to a non existing property
2018-01-28 11:17:50 -02:00
Georges Basile Stavracas Neto 7364d8bf29 manager: Handle refresh in the source directly
Instead of implementing code to refresh sources, let's just
use the ESourceRefresh extension and let Evolution handle that.
2018-01-28 10:43:48 -02:00
Georges Basile Stavracas Neto 037567209c view: Remove first weekday helpers when unecessary
Not all views need to know the first weekday, and those
who need, it can be stored internally.
2018-01-28 10:20:19 -02:00
Georges Basile Stavracas Neto 30ba757c40 utils: Cleanup first weekday function 2018-01-28 09:59:08 -02:00
Georges Basile Stavracas Neto 3873b3b5bb shell-search-provider: Remove dead fixme 2018-01-28 09:56:17 -02:00
Georges Basile Stavracas Neto b936759e5c project: Make time format a first-class citizen
The current code deals with 12/24h clock formats almost like
a workaround of the issue. This commit adds proper support to
different clock formats.
2018-01-28 02:30:55 -02:00
Georges Basile Stavracas Neto 79987734cd enums: Generate enums with standard GLib syntax 2018-01-28 02:30:07 -02:00
Georges Basile Stavracas Neto c7f6fd19c4 project: Move enums to gcal-enums.h 2018-01-28 00:44:36 -02:00
Georges Basile Stavracas Neto b45f7b2392 doap: Update database link 2018-01-28 00:32:07 -02:00
Georges Basile Stavracas Neto 71e9c3e0c7 shell-search-provider: Instrument and modernize code 2018-01-28 00:27:56 -02:00
Georges Basile Stavracas Neto 0bfc6fe291 shell-search-provider: Rework property initialization 2018-01-28 00:13:15 -02:00
Georges Basile Stavracas Neto 74f353eb33 window: Make menu completely non-homogeneous 2018-01-27 23:54:04 -02:00
Georges Basile Stavracas Neto 9424d8f3cc weather-settings: Only deserialize valid locations 2018-01-27 23:32:21 -02:00
Georges Basile Stavracas Neto fe53414b07 weather-settings: Instrument more loading functions 2018-01-27 23:27:25 -02:00
Georges Basile Stavracas Neto a7aa997ac3 weather-service: Remove more dead code 2018-01-27 23:27:03 -02:00
Georges Basile Stavracas Neto c4ca9cac3c project: Rename GcalSearchView to GcalSearchPopover
This was never a view, but a popover.
2018-01-27 23:02:36 -02:00
Georges Basile Stavracas Neto 1dcf0d1f24 project: Unify headers 2018-01-27 22:35:20 -02:00
Georges Basile Stavracas Neto ac4f8feb15 weather-service: More small refactorings
Now it appears to be fully funcitonal again!
2018-01-27 22:26:30 -02:00
Georges Basile Stavracas Neto 718266f349 window: Bind manager to GcalWeatherSettings
A missing entry point from the previous refactorings
2018-01-27 22:25:57 -02:00
Georges Basile Stavracas Neto 50ec8fd30b window: Notify properties by pspec
It avoids lookups on the class properties.
2018-01-27 22:25:32 -02:00
Georges Basile Stavracas Neto 6dc3d9ee39 weather-settings: Improve start/stop logic 2018-01-27 21:56:58 -02:00
Georges Basile Stavracas Neto 5dddff9939 weather-service: Fix debug location
This is tricking us into thinking the code is being
executed when in fact it's falling into the early return.
2018-01-27 21:56:14 -02:00
Georges Basile Stavracas Neto 5a651b01f8 window: Rework property initialization
There is a clear chain of properties that must be respected
in order to make Calendar initialize properly:

 1. GcalManager, since it provider access to the settings
 2. The initial date
 3. GcalWeatherService, that depends on settings and the initial date
2018-01-27 21:46:15 -02:00
Georges Basile Stavracas Neto 5a0844c127 application: Remove conditional include
We always generate the config file nowadays.
2018-01-27 21:26:33 -02:00
Georges Basile Stavracas Neto 737181c655 application: Use g_auto* to simplify code 2018-01-27 21:11:08 -02:00
Georges Basile Stavracas Neto 499db7bfd4 weather: Rework weather management
This commit brings a few changes that I was too lazy to
split in different commits:

 * Remove a few useless arguments in the GcalWeatherService API
 * Move the weather management code from GcalWindow to GcalWeatherSettings
 * A few style changes
2018-01-27 20:36:29 -02:00
Georges Basile Stavracas Neto ab20672aeb weather: Move to a subdirectory 2018-01-27 15:24:32 -02:00
Georges Basile Stavracas Neto a8d6bfea0b month-popover: Properly mark static function as static 2018-01-27 14:30:31 -02:00
Georges Basile Stavracas Neto 702c089c17 weather-service: Simplify code 2018-01-27 14:30:02 -02:00
Georges Basile Stavracas Neto 5a6fabddc8 window: Rework property creation 2018-01-27 14:28:55 -02:00
Georges Basile Stavracas Neto 333fa79437 resources: Don't strip XML blanks
It only makes it harder to debug, and we gain effectively
nothing from that.
2018-01-27 14:27:16 -02:00
Georges Basile Stavracas Neto 845eed5cea ci: Use a Rawhide image
We depend on an unstable version of GWeather.
2018-01-27 12:52:14 -02:00
Georges Basile Stavracas Neto 50a5bbefaf ci: Add libgweather dependency 2018-01-27 12:31:08 -02:00
Georges Basile Stavracas Neto 4f4b10baab ci: update to Fedora 27
We should eventually add Ubuntu too.
2018-01-27 12:14:24 -02:00
Georges Basile Stavracas Neto fe40a97926 project: Add missing dependencies to CI 2018-01-27 11:57:47 -02:00
Georges Basile Stavracas Neto 519de35520 project: Change build stage name to 'build-calendar' 2018-01-27 11:49:22 -02:00
Georges Basile Stavracas Neto e4062c7952 project: Add CI integration 2018-01-27 13:47:46 +00:00
Georges Basile Stavracas Neto a853e85293 project: delete configure script
Let's use raw Meson from now on.
2018-01-27 11:41:28 -02:00
Georges Basile Stavracas Neto 6c203d55c4 build: Remove even more dead code 2018-01-27 00:52:45 -02:00
Georges Basile Stavracas Neto dd1e82e761 Merge branch 'meson-improvements' into 'master'
Meson improvements

See merge request GNOME/gnome-calendar!25
2018-01-27 01:58:52 +00:00
Georges Basile Stavracas Neto d68b45038c project: update TODO 2018-01-16 08:32:43 -02:00
Georges Basile Stavracas Neto f0a2a43438 Merge branch 'master' into 'master'
week-view: display "12 PM" correctly

See merge request GNOME/gnome-calendar!22
2018-01-10 16:08:08 +00:00
Georges Basile Stavracas Neto e72f7356c1 Merge branch 'master' into 'master'
Issue #228 : Add --quit command line argument

See merge request GNOME/gnome-calendar!17
2018-01-10 15:33:31 +00:00
Georges Basile Stavracas Neto e63f55f8b9 Merge branch 'wip/piotrdrag/placeholder-translations' into 'master'
ui: Unmark placeholder strings from translation

See merge request GNOME/gnome-calendar!18
2018-01-03 16:51:13 +00:00
Georges Basile Stavracas Neto b8f51e1d3d window: a load more weather changes 2017-12-17 11:35:19 -02:00
Georges Basile Stavracas Neto 61b9ba85a2 month-view: cleanup includes 2017-12-16 23:52:06 -02:00
Georges Basile Stavracas Neto 9f1885d807 weather-service: use GPtrArray for public API
Using GLists and GSLists is a bad practice. These data
structures are too much inneficient and GPtrArray has
the advantage of having a free function pointer, so we
can hide the underlying free function from the consumers
of this API.

This also gets rid of another allocation cycle in Month
view.
2017-12-16 23:12:06 -02:00
Georges Basile Stavracas Neto dcf4ff0bda views: more weather service cleanups
Did I ever say how happy I'll be when people start
actually following my code style when densing code
to my projects?
2017-12-16 22:36:39 -02:00
Georges Basile Stavracas Neto d283316382 views: simplify reference leak workaround
Oh so many unecessary casts =(
2017-12-16 21:49:22 -02:00
Georges Basile Stavracas Neto 5c1bf907fa views: move :event-activated signal to GcalView
We don't really need to copy this signal to every GcalView
implementation. It's just wasting code.
2017-12-16 21:44:09 -02:00
Georges Basile Stavracas Neto c306bbc1ef month-view: properly cleanup weather data from cells 2017-12-16 21:34:31 -02:00
Georges Basile Stavracas Neto b70f3fa0b6 month-view: fix another allocation cycle 2017-12-12 11:06:46 -02:00
Georges Basile Stavracas Neto d2dea218ae view: pass the correct property value
It should be a pointer to a GcalWeatherService, not a pointer
to a pointer to a GcalWeatherService.
2017-12-12 11:06:07 -02:00
Georges Basile Stavracas Neto 92f054fc12 project: update Flatpak manifest 2017-12-12 11:04:42 -02:00
Georges Basile Stavracas Neto d42a943e4d Merge branch 'gweather-api-fix' into 'master'
Adapt to the libgweather API changes

See merge request GNOME/gnome-calendar!15
2017-12-12 12:00:52 +00:00
Georges Basile Stavracas Neto 8670c6fd8e source-dialog: cast to GtkWidget* before increasing refcount
So that we check for the right type.
2017-12-11 23:22:42 -02:00
Georges Basile Stavracas Neto 23a9de1108 weather-service: major reorganization and cleanup
To make it more like the actual code style of GNOME Calendar.

Hope Florian doesn't get (too) mad of me removing and modifying
so much on his code. I'm sorry dude, my OCD didn't allow me to
just flood the gate.
2017-12-11 23:10:55 -02:00
Georges Basile Stavracas Neto fcd9fa1c31 Merge "utils: reworked uri splitting with help of libsoup"
See merge request GNOME/gnome-calendar!14
2017-12-11 23:07:30 +00:00
Georges Basile Stavracas Neto 4f02a3e97f Merge branch 'add-className' into 'master'
Add a topWindow class with the app's reversed domain name

See merge request GNOME/gnome-calendar!13
2017-12-07 12:50:50 +00:00
Georges Basile Stavracas Neto d3232e664f Merge branch 'wip/sadiq' into 'master'
window: Simplify saving/loading window states

See merge request GNOME/gnome-calendar!9
2017-12-06 13:53:05 +00:00
Georges Basile Stavracas Neto 06f4a5b182 Merge branch 'mcatanzaro/leak' into 'master'
event: Fix a minor leak

See merge request GNOME/gnome-calendar!6
2017-12-06 11:04:02 +00:00
Georges Basile Stavracas Neto 89e90fec6d Merge branch 'wip/mcatanzaro/timezone' into 'master'
Events created in month or year view are created with incorrect time and missing timezone

Closes #168

See merge request GNOME/gnome-calendar!7
2017-12-06 10:45:42 +00:00