Georges Basile Stavracas Neto
40b39337f3
source-dialog: remove deprecated xalign for buttons
2015-05-25 12:36:55 -04:00
Georges Basile Stavracas Neto
47674b4d61
source-dialog: remove the annoying 2px border from the dialog
2015-05-25 12:36:54 -04:00
Georges Basile Stavracas Neto
ef9d1301d9
source-dialog: use a builder .ui definition for interface
...
We know that coding interfaces sucks, so use a .ui file instead.
2015-05-25 12:36:54 -04:00
Erick Pérez Castellanos
b1fc6991e9
calendars' popover: refine UI
...
Always show Calendars Settings button. Scroll only the list of calendars.
2015-05-25 12:36:54 -04:00
Georges Basile Stavracas Neto
f63541f475
manager: unred GOA client on finalize
2015-05-25 12:36:54 -04:00
Georges Basile Stavracas Neto
18f0026eb7
manager: use goa_client for private field
...
To not confuse it with the many other clients we
already have here
2015-05-25 12:36:54 -04:00
Erick Pérez Castellanos
c2d89a5903
build: simplify UI files using gtk-builder-tool
2015-05-25 12:36:54 -04:00
Erick Pérez Castellanos
fb73f6574b
calendar's popover: use GbScrolledWindow
...
This solve the problem of too many calendars making the window too tall.
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=749459
2015-05-25 12:36:54 -04:00
Erick Pérez Castellanos
3d7ffdbaa7
app: add GbScrolledWindow
...
GbScrolledWindow comes from Builder, courtesy of christian Hergert.
We'll use it in calendars' popover.
2015-05-25 12:36:54 -04:00
Erick Pérez Castellanos
fdba286915
source-dialog: g_object_ref() returns the object
2015-05-25 12:36:54 -04:00
Erick Pérez Castellanos
53e3c04bb2
source-dialog: make NULL comparison explicit
2015-05-25 12:36:54 -04:00
Erick Pérez Castellanos
2677ec560a
source-dialog: avoid unneeded comparisons
...
Sources are unique, so the comparison can be avoided once the source is
found
2015-05-25 12:36:54 -04:00
Erick Pérez Castellanos
1431f4b895
style: align arguments properly
2015-05-25 12:36:54 -04:00
Erick Pérez Castellanos
46a92fd96b
source-dialog: join two conditionals
...
Below the main conditionals were another if with no else block.
Those can be joined using && operator.
Some minor style fixes in here also.
2015-05-25 12:36:54 -04:00
Erick Pérez Castellanos
d1f437f4d9
style: use the entire line
2015-05-25 12:36:54 -04:00
Erick Pérez Castellanos
d4f6963328
style: remove unneeded curly brackets
2015-05-25 12:36:54 -04:00
Erick Pérez Castellanos
899928e795
style: remove whitespace
2015-05-25 12:36:53 -04:00
Erick Pérez Castellanos
798b63903d
source-dialog: sources are unique
...
Destroy the row and break the loop as soon as the source is found
2015-05-25 12:36:53 -04:00
Erick Pérez Castellanos
cfa81e86a5
style: group variables declarations
2015-05-25 12:36:53 -04:00
Erick Pérez Castellanos
cff0b59b2e
style: ensure separation of code and declarations
2015-05-25 12:36:53 -04:00
Erick Pérez Castellanos
b04720135f
window: sources are unique
...
There's no need to loop through the rest of the list once the ESource has been
found
2015-05-25 12:36:53 -04:00
Erick Pérez Castellanos
44480da71a
window: I rather have these lines
...
I prefer a clean separation between declarations and code
2015-05-25 12:36:53 -04:00
Erick Pérez Castellanos
c256bec634
utils: make NULL comparison explicit
2015-05-25 12:36:53 -04:00
Georges Basile Stavracas Neto
9838c7fa41
window: fix more styling issues
2015-05-25 12:35:59 -04:00
Georges Basile Stavracas Neto
350cd5ea85
source-dialog: fix style
2015-05-25 12:35:58 -04:00
Georges Basile Stavracas Neto
bbcd5bcc49
source-dialog: use GtkEntry::get_text_length
2015-05-25 12:35:58 -04:00
Georges Basile Stavracas Neto
e3e30140b3
source-dialog: use g_clear_object instead of manual free
2015-05-25 12:35:58 -04:00
Georges Basile Stavracas Neto
6213f5cc78
source-dialog: remove useless checks before freeing memory
...
g_free is NULL-proof, no need to check if it's NULL
before using it.
2015-05-25 12:35:58 -04:00
Georges Basile Stavracas Neto
f9b3f2f6c7
source-dialog: remove unused enum
2015-05-25 12:35:58 -04:00
Georges Basile Stavracas Neto
cd872d42ed
manager: load GOA client at construction time
2015-05-25 12:35:58 -04:00
Georges Basile Stavracas Neto
27fa9983f4
manager: change ::get_client to ::get_goa_client
...
This explains better the purpose of the methods, and also
don't collide with the ECalClient prefix we already use.
2015-05-25 12:35:58 -04:00
Georges Basile Stavracas Neto
87ecb99090
application: remove unused import
2015-05-25 12:35:58 -04:00
Georges Basile Stavracas Neto
2b4e46a4b6
manager: notify when sources are enabled/disabled
...
Add the new signal for GcalManager::source-enabled that
notifies connected widgets about the source change. With
that, we can keep checkboxes syncronizes.
2015-05-25 12:35:58 -04:00
Georges Basile Stavracas Neto
023a79a90f
source-dialog: bind source::display-name with label::label
2015-05-25 12:35:58 -04:00
Georges Basile Stavracas Neto
a9364d83cb
window: better name Calendar Settings button
2015-05-25 12:35:58 -04:00
Georges Basile Stavracas Neto
c3d34ae149
window: add a nice style to the calendar listbox
2015-05-25 12:35:58 -04:00
Georges Basile Stavracas Neto
134d8678fe
source-dialog: connect the signal
2015-05-25 12:35:57 -04:00
Georges Basile Stavracas Neto
51a2695546
source-dialog: open online account settings when button is clicked
2015-05-25 12:35:57 -04:00
Georges Basile Stavracas Neto
60401426a2
source-dialog: silence gnome-control-center
2015-05-25 12:35:57 -04:00
Georges Basile Stavracas Neto
7482469b01
source-dialog: sort online accounts
2015-05-25 12:35:57 -04:00
Georges Basile Stavracas Neto
06e6f39721
source-dialog: remove accounts with GoaClient::account-removed
2015-05-25 12:35:57 -04:00
Georges Basile Stavracas Neto
1a580e3be5
source-dialog: hide empty goa rows instead of removing them
2015-05-25 12:35:57 -04:00
Georges Basile Stavracas Neto
a8631eb99a
source-dialog: initialize the icon name
...
Avoids some compiler warnings.
2015-05-25 12:35:57 -04:00
Georges Basile Stavracas Neto
321882f4b2
source-dialog: use subtitles to improve user discoveribility
...
Make it clear that you can configure your account
by clicking the row.
2015-05-25 12:35:57 -04:00
Georges Basile Stavracas Neto
2f882d2b0b
source-dialog: add accounts when they're added
2015-05-25 12:35:57 -04:00
Georges Basile Stavracas Neto
10e032f510
source-dialog: open online account when row is activated
2015-05-25 12:35:57 -04:00
Georges Basile Stavracas Neto
06cfeace4d
source-dialog: load online accounts
2015-05-25 12:35:57 -04:00
Georges Basile Stavracas Neto
3905622420
window: don't set the manager twice
2015-05-25 12:35:57 -04:00
Georges Basile Stavracas Neto
87299afe01
project: add online account row UI for source dialog
2015-05-25 12:35:57 -04:00
Georges Basile Stavracas Neto
5862f1671f
window: add source dialog to builder file again
2015-05-25 12:35:57 -04:00