Federated_Computer/federated-calendar
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

gui/calendar-list: Turn row into a checkbox

Browse Source 
Using a GtkCheckButton widget as a child as we've been doing was a
little bit too much, considering it was overachieving its use case.
Given the nature of a button, the widget was also capable of
being targetable, focusable, and activatable, which forces
a keyboard user to tab an additional time to get to the
next row in the list.

This patch introduces a new method by turning the entire row into a
check button widget, with an image widget that becomes visible or
invisible, which addresses the issues raised above. This also
avoids binding properties bidirectionally, as the image is only
used for decorative purposes.

https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/542#note_2459629

Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/588>
This commit is contained in:
Hari Rana
2025-06-28 20:27:28 +00:00
committed by Jordan Petridis
parent 2ee31847fa
commit 40cbf66c1b
1 changed files with 17 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/gui/gcal-calendar-list.c
+17 -10
View File
@@ -67,7 +67,7 @@ create_row_func (gpointer data,
{
g_autoptr (GdkPaintable) paintable = NULL;
GcalCalendar *calendar;
GtkWidget *label, *icon, *checkbox, *box, *row;
GtkWidget *label, *icon, *box, *row, *image;
calendar = GCAL_CALENDAR (data);
@@ -97,20 +97,23 @@ create_row_func (gpointer data,
gtk_widget_set_tooltip_text (label, gcal_calendar_get_name (calendar));
gtk_widget_set_hexpand (label, TRUE);
/* checkbox */
checkbox = gtk_check_button_new ();
image = gtk_image_new_from_icon_name ("checkmark-small-symbolic");
g_object_bind_property (calendar,
"visible",
checkbox,
"active",
G_BINDING_BIDIRECTIONAL | G_BINDING_SYNC_CREATE);
image,
"visible",
G_BINDING_SYNC_CREATE);
gtk_box_append (GTK_BOX (box), icon);
gtk_box_append (GTK_BOX (box), label);
gtk_box_append (GTK_BOX (box), checkbox);
gtk_box_append (GTK_BOX (box), image);
gtk_list_box_row_set_child (GTK_LIST_BOX_ROW (row), box);
g_object_set_data (G_OBJECT (row), "check", checkbox);
g_object_set (G_OBJECT (row), "accessible-role", GTK_ACCESSIBLE_ROLE_CHECKBOX, NULL);
gtk_accessible_update_state (GTK_ACCESSIBLE (row),
GTK_ACCESSIBLE_STATE_CHECKED, gcal_calendar_get_visible (calendar),
-1);
g_object_set_data (G_OBJECT (row), "calendar", calendar);
return row;
@@ -125,9 +128,13 @@ on_listbox_row_activated_cb (GtkListBox *listbox,
GtkListBoxRow *row,
GcalCalendarList *self)
{
GtkCheckButton *check = g_object_get_data (G_OBJECT (row), "check");
GcalCalendar *calendar = g_object_get_data (G_OBJECT (row), "calendar");
gtk_check_button_set_active (check, !gtk_check_button_get_active (check));
gcal_calendar_set_visible (calendar, !gcal_calendar_get_visible (calendar));
gtk_accessible_update_state (GTK_ACCESSIBLE (row),
GTK_ACCESSIBLE_STATE_CHECKED, gcal_calendar_get_visible (calendar),
-1);
}