Federated_Computer/federated-calendar
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

event: Set dt_end to next day when DTEND is not defined

Browse Source 
from RFC5545 (p. 54) https://datatracker.ietf.org/doc/html/rfc5545#page-54
For cases where a "VEVENT" calendar component specifies a "DTSTART"
property with a DATE value type but no "DTEND" nor "DURATION" property,
the event's duration is taken to be one day.

Fix https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/327
This commit is contained in:
Daniel Garcia Moreno
2023-11-09 14:37:09 +00:00
committed by Georges Basile Stavracas Neto
parent 6afb5cf3a5
commit 20aa929966
2 changed files with 46 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/core/gcal-event.c
+1
View File
@@ -368,6 +368,7 @@ setup_component (GcalEvent *self,
if (!end || !e_cal_component_datetime_get_value (end))
{
self->all_day = TRUE;
self->dt_end = g_date_time_add_days (self->dt_start, 1);
}
else
{
tests/test-event.c
+45
View File
@@ -30,6 +30,19 @@
"DTEND:20180715T035959Z\n" \
"END:VEVENT\n"
#define STUB_EVENT_DTEND "BEGIN:VEVENT\n" \
"SUMMARY:Stub all day\n" \
"UID:example@uid\n" \
"DTSTART;VALUE=DATE:20231108\n" \
"DTEND;VALUE=DATE:20231109\n" \
"END:VEVENT\n"
#define STUB_EVENT_NODTEND "BEGIN:VEVENT\n" \
"SUMMARY:Stub all day\n" \
"UID:example@uid\n" \
"DTSTART;VALUE=DATE:20231108\n" \
"END:VEVENT\n"
#define EVENT_STRING_FOR_DATE(dtstart,dtend) \
"BEGIN:VEVENT\n" \
"SUMMARY:Stub event\n" \
@@ -130,6 +143,37 @@ event_summary (void)
/*********************************************************************************************************************/
static void
event_no_dtend (void)
{
g_autoptr (GcalEvent) event_dtend = NULL;
g_autoptr (GcalEvent) event_nodtend = NULL;
GDateTime *end_dtend = NULL;
GDateTime *end_nodtend = NULL;
g_test_bug ("327");
event_dtend = create_event_for_string (STUB_EVENT_DTEND, NULL);
event_nodtend = create_event_for_string (STUB_EVENT_NODTEND, NULL);
end_dtend = gcal_event_get_date_end (event_dtend);
end_nodtend = gcal_event_get_date_end (event_nodtend);
// assert event with DTEND is working correctly
g_assert_true (gcal_event_get_all_day (event_dtend));
g_assert_true (end_dtend != NULL);
// assert event without DTEND is working correctly, has a date_end assigned
// for all day
g_assert_true (gcal_event_get_all_day (event_nodtend));
g_assert_true (end_nodtend != NULL);
// The event without dtend should be all day and should have the same
// date_end than the event that explicitly specified it.
g_assert_true (g_date_time_equal (end_dtend, end_nodtend));
}
/*********************************************************************************************************************/
static void
event_date_start (void)
{
@@ -256,6 +300,7 @@ main (gint argc,
g_test_add_func ("/event/clone", event_clone);
g_test_add_func ("/event/uid", event_uid);
g_test_add_func ("/event/summary", event_summary);
g_test_add_func ("/event/nodtend", event_no_dtend);
g_test_add_func ("/event/date/start", event_date_start);
g_test_add_func ("/event/date/end", event_date_end);
g_test_add_func ("/event/date/singleday", event_date_singleday);