Federated_Computer/federated-calendar
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

event-editor/time-selector: Don't change dropdown on callback

Browse Source 
The 'update_time' function shouldn't try to update the dropdown,
as it is actually invoked by the dropdown itself. This causes a
cyclic loop with signal emission.

Closes: https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/1133
This commit is contained in:
Georges Basile Stavracas Neto
2023-12-13 19:41:41 -03:00
parent 3b9bf55dd5
commit 1043917ecf
1 changed files with 1 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/gui/event-editor/gcal-time-selector.c
+1 -8
View File
@@ -71,14 +71,7 @@ update_time (GcalTimeSelector *selector)
hour = hour % 12; hour = hour % 12;
if (gtk_drop_down_get_selected (GTK_DROP_DOWN (selector->period_dropdown)) == PM) if (gtk_drop_down_get_selected (GTK_DROP_DOWN (selector->period_dropdown)) == PM)
{ hour += 12;
g_signal_handlers_block_by_func (selector->period_dropdown, update_time, selector);
gtk_drop_down_set_selected (GTK_DROP_DOWN (selector->period_dropdown), hour >= 12);
hour += 12;
g_signal_handlers_unblock_by_func (selector->period_dropdown, update_time, selector);
}
} }
now = g_date_time_new_now_local (); now = g_date_time_new_now_local ();