From 1043917ecf85b4e3ce741a0d4fa75a90ee2c1b76 Mon Sep 17 00:00:00 2001 From: Georges Basile Stavracas Neto Date: Wed, 13 Dec 2023 19:39:41 -0300 Subject: [PATCH] event-editor/time-selector: Don't change dropdown on callback The 'update_time' function shouldn't try to update the dropdown, as it is actually invoked by the dropdown itself. This causes a cyclic loop with signal emission. Closes: https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/1133 --- src/gui/event-editor/gcal-time-selector.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/src/gui/event-editor/gcal-time-selector.c b/src/gui/event-editor/gcal-time-selector.c index 4b4785ca..6c54f942 100644 --- a/src/gui/event-editor/gcal-time-selector.c +++ b/src/gui/event-editor/gcal-time-selector.c @@ -71,14 +71,7 @@ update_time (GcalTimeSelector *selector) hour = hour % 12; if (gtk_drop_down_get_selected (GTK_DROP_DOWN (selector->period_dropdown)) == PM) - { - g_signal_handlers_block_by_func (selector->period_dropdown, update_time, selector); - - gtk_drop_down_set_selected (GTK_DROP_DOWN (selector->period_dropdown), hour >= 12); - hour += 12; - - g_signal_handlers_unblock_by_func (selector->period_dropdown, update_time, selector); - } + hour += 12; } now = g_date_time_new_now_local ();