Don't reset the extensions' settings on every refresh
shellcheck / shellcheck (push) Failing after 15s
shellcheck / shellcheck (push) Failing after 15s
gnome-extensions.sh loaded gnome-settings.dconf unconditionally, so each refresh (install.sh runs it) undid users' changes to those settings, bypassing apply-gnome-settings.sh's check that the file has changed. That script, which install.sh runs later, already loads the settings when needed. The smoketest's 11-refresh caught it: Tiling Shell's selected-layouts went back to the file's value. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -28,5 +28,6 @@ for ext in "${EXTENSIONS[@]}"; do
|
||||
echo " Installed and enabled: $ext"
|
||||
done
|
||||
|
||||
# Load settings from dconf file
|
||||
dconf load /org/gnome/shell/extensions/ < "$SCRIPT_DIR/gnome-settings.dconf"
|
||||
# The extensions' settings (gnome-settings.dconf) are loaded by
|
||||
# apply-gnome-settings.sh, which install.sh runs later, and only when the file
|
||||
# has changed. Loading them here too reset users' own changes on every refresh.
|
||||
|
||||
Reference in New Issue
Block a user