From 906f2b1b47634fb26f41275243775abb8bfdd973 Mon Sep 17 00:00:00 2001 From: David Young Date: Thu, 5 Nov 2026 09:01:39 -0700 Subject: [PATCH] Don't reset the extensions' settings on every refresh gnome-extensions.sh loaded gnome-settings.dconf unconditionally, so each refresh (install.sh runs it) undid users' changes to those settings, bypassing apply-gnome-settings.sh's check that the file has changed. That script, which install.sh runs later, already loads the settings when needed. The smoketest's 11-refresh caught it: Tiling Shell's selected-layouts went back to the file's value. Co-Authored-By: Claude Opus 5.5 --- gnome/gnome-extensions.sh | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/gnome/gnome-extensions.sh b/gnome/gnome-extensions.sh index 337af76..9d3421b 100755 --- a/gnome/gnome-extensions.sh +++ b/gnome/gnome-extensions.sh @@ -28,5 +28,6 @@ for ext in "${EXTENSIONS[@]}"; do echo " Installed and enabled: $ext" done -# Load settings from dconf file -dconf load /org/gnome/shell/extensions/ < "$SCRIPT_DIR/gnome-settings.dconf" \ No newline at end of file +# The extensions' settings (gnome-settings.dconf) are loaded by +# apply-gnome-settings.sh, which install.sh runs later, and only when the file +# has changed. Loading them here too reset users' own changes on every refresh.