Georges Basile Stavracas Neto
0c1636b7aa
gui/multi-choice: Use g_clear_pointer more
...
Just a cosmetic improvement.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/721 >
2026-03-10 20:45:35 -03:00
Guillaume Bernard
5a663ee671
multi-choice: Fix i18n of navigation button tooltips
...
The previous approach built tooltip strings by formatting a translated
category name (e.g. "Month") into a generic "Previous %1$s" template.
This is a classic gettext concatenation anti-pattern: languages with
grammatical gender (French, Spanish, German, …) need the adjective to
agree with the noun, and word order can differ from English, so
translators of the format string have no way to produce a correct
result.
Replace the format strings and their helper callbacks with two explicit
GObject properties on GcalMultiChoice: prev-button-tooltip-text and
next-button-tooltip-text. The buttons in the template now bind to
these properties directly. Each widget instance in gcal-date-chooser.blp
sets its own fully self-contained translatable string ("Previous month",
"Next month", "Previous year", "Next year"), giving translators all the
context they need to handle gender and word order correctly.
Closes: https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/1547
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/721 >
2026-03-10 20:43:02 -03:00
Hari Rana
50e048c7e0
utils: Turn number of weekdays into a macro
...
While "7" may be obvious in the context of calendaring that
it represents the number of week days, it often gives me the
impression of it being a magic number when I'm hyperfocused on certain
parts of the codebase for several consecutive hours. Turning the
number into a macro helps me scan functions much more easily.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/674 >
2026-03-08 21:53:40 -04:00
Hari Rana
da7b625e18
data: Update screenshot URLs
...
See:
- https://gitlab.gnome.org/Teams/Websites/static.gnome.org/-/merge_requests/47#note_2701250
- https://gitlab.gnome.org/Teams/Websites/static.gnome.org/-/merge_requests/48
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/719 >
2026-03-08 20:15:26 -04:00
Hari Rana
1141c758a4
data: Update screenshots
...
This also sets the month view as the default screenshot.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/717 >
2026-03-08 09:26:11 -04:00
Hari Rana
2638766d10
views/month-view: Focus adjacent cell when tabbing forward from the last event widget
...
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/564 >
2026-03-03 21:11:16 -03:00
Hari Rana
e607a6bd2e
views/month-view: Clear marks when tabbing from a cell
...
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/564 >
2026-03-03 21:11:16 -03:00
Hari Rana
d6a450ff1f
gui/window: Focus last focused widget upon closing quick add popover
...
This also introduces the `focus_last_focused_widget()` to make the
code a little bit cleaner.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/564 >
2026-03-03 21:11:16 -03:00
Hari Rana
4e54c18d06
views/month-view: Set focus to cell upon click release
...
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/564 >
2026-03-03 21:11:16 -03:00
Hari Rana
3102766c51
views/month-view: Allow selecting cells
...
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/564 >
2026-03-03 21:11:16 -03:00
Hari Rana
6c6dd46a89
views/month-view: Scroll view when out of bounds
...
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/564 >
2026-03-03 18:35:18 -05:00
Hari Rana
c74fe74b97
views/month-view: Wrap cells
...
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/564 >
2026-03-03 18:35:18 -05:00
Hari Rana
d8e44108ea
views/month-view: Display quick add popover when activating cell
...
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/564 >
2026-03-03 18:35:18 -05:00
Hari Rana
3088b2260a
views/month-view-row: Add "activate-cell" signal
...
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/564 >
2026-03-03 18:35:18 -05:00
Hari Rana
cd0138393f
views/month-cell: Add activate signal
...
This will be needed for keyboard navigation.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/564 >
2026-03-03 18:35:17 -05:00
Hari Rana
471f81eb31
views/month-view-row: Implement focusing cells horizontally
...
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/564 >
2026-03-03 18:35:17 -05:00
Hari Rana
e6e201d9aa
views/month-view-row: Implement focusing cells vertically
...
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/564 >
2026-03-03 18:35:17 -05:00
Hari Rana
48e6607d43
views/month-view: Focus adjacent cell when pressing Ctrl+Tab
...
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/564 >
2026-03-03 18:35:17 -05:00
Hari Rana
405f826252
views/month-view-row: Add method for focusing adjacent cells
...
This method allows to focus the month cells behind the event widgets.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/564 >
2026-03-03 18:35:17 -05:00
Hari Rana
d76d37dff2
views/month-cell: Add focus styling
...
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/564 >
2026-03-03 18:35:17 -05:00
Hari Rana
e88f77802b
views/month-cell: Override focus() virtual function
...
Without this patch, focus immediately goes to the "Previous Month"
button at startup, for some unknown reason.
So, as a workaround, skip focus if the root cannot retrieve the
current focused widget.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/564 >
2026-03-03 18:35:17 -05:00
Hari Rana
80adbd0d23
views/month-cell: Inherit GtkWidget
...
AdwBreakpointBin, the parent, cannot set focus to itself. Instead
of focusing GtkOverlay, a child widget, we should instead inherit
GtkWidget to allow focusing that instead.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/564 >
2026-03-03 18:35:17 -05:00
Hari Rana
b592f15b26
views/month-view: Add and update accessible elements
...
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/564 >
2026-03-03 18:35:17 -05:00
Georges Basile Stavracas Neto
9712280aea
core/manager: Cosmetics
2026-03-03 20:12:45 -03:00
Georges Basile Stavracas Neto
b4292c2026
core/manager: Increment before potentially decrementing
...
Otherwise we can go backwards first. Not going to break anything,
but this is a more robust logic.
2026-03-03 20:11:07 -03:00
Georges Basile Stavracas Neto
e1438b3c8e
core/manager: Use g_autoptr more
...
In the clients list.
2026-03-03 20:09:51 -03:00
voyage200
9f956c93d4
core/manager: Also refresh collections
...
Add on_collection_source_refreshed() callback. Track collection
source refresh in clients_synchronizing. Refresh collection sources
before calendar clients. Fix PROP_SYNCHRONIZING state by waiting for
all async ops.
2026-03-03 20:07:18 -03:00
Georges Basile Stavracas Neto
6f37e4e486
50.rc
2026-03-01 16:55:19 -03:00
Hari Rana
caed41abdd
views/month-cell: Set accessibility properties for overflow button
...
This uses the "toggle-button" role instead of GtkToggleButton widget,
as GtkToggleButton remains toggled after closing the month popover.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/598 >
2026-03-01 19:35:46 +00:00
Hari Rana
55aa6b8cc5
views/month-view: Focus last focused widget after closing month popover
...
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/598 >
2026-03-01 19:35:46 +00:00
Hari Rana
8877d93059
views/month-popover: Add "closed" signal
...
This will be needed for setting focus to the last focused widget
after closing the popover.
Alternatively, we could have used the "unmap" signal, but this causes
a significant delay before setting focus to the last focused widget,
as it needs to complete the animation before it emits the
"unmap" signal.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/598 >
2026-03-01 19:35:46 +00:00
Hari Rana
f3a6c93245
views/month-popover: Cycle focus through widgets
...
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/598 >
2026-03-01 19:35:46 +00:00
Hari Rana
5c4a2b1ab0
views/month-popover: Only focus rows
...
This follows the same approach as
https://gitlab.gnome.org/GNOME/gnome-calendar/-/commit/0aaf13626c0bb7e8ade2d79e8b50132b3a583c9f?merge_request_iid=559
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/598 >
2026-03-01 19:35:45 +00:00
Hari Rana
a1c8a9575e
views/month-popover: Make close button unfocusable
...
Close buttons throughout the app are unfocusable, so it's best
to keep that behavior consistent.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/598 >
2026-03-01 19:35:45 +00:00
Hari Rana
19879c6c02
style: Decrease event widget's outline offset
...
Having an offset would hide the overflowing pixels.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/598 >
2026-03-01 19:35:45 +00:00
Hari Rana
295f154c76
views/month-view-row: Allow navigating through overflow buttons
...
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/598 >
2026-03-01 19:35:45 +00:00
Hari Rana
9e8c9ae6e8
style: Add border radius to overflow button
...
This also adds the `.overflow` style class.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/598 >
2026-03-01 19:35:45 +00:00
Hari Rana
d79a3260f0
views/month-cell: Add margins to overflow button
...
`margin-end` and `margin-bottom` have a 2px margin since the
`box-shadow` CSS property, which is used to mimic a border,
is offset by 1px.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/598 >
2026-03-01 19:35:44 +00:00
Hari Rana
5ed93e73d4
views/month-cell: Add method for retrieving overflow button
...
This is needed for keyboard navigation, specifically for grabbing
focus and checking focus.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/598 >
2026-03-01 19:35:44 +00:00
Hari Rana
24dd9be132
views/month-view: Allow skipping event widgets with Ctrl
...
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/598 >
2026-03-01 19:35:44 +00:00
Hari Rana
bdfb4b609e
views/week-view-common: Port from GtkStyleContext to GtkSnapshot
...
GtkStyleContext methods are deprecated.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/707 >
2026-02-28 13:57:52 +00:00
Hari Rana
033e719833
event-editor/alarm-row: Remove volume_button member
...
`volume_button` no longer exists.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/708 >
2026-02-27 21:37:42 -05:00
Bilal Elmoussaoui
e85512132d
Add provides to the metainfo file
...
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/59 >
2026-02-25 13:45:42 +00:00
Hari Rana
bb2fa2a63b
views/month-view-row: Find nearest vertical widget when tabbing
...
This was overlooked from the original commit:
https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/598/diffs?commit_id=2ae3dd771cb9b2cc0d08a1cabb0b2f5359719d0b#c04c121e2c8eebcfb09fbcbeecff310223fe987f_708_767
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/706 >
2026-02-24 19:46:47 -05:00
Hari Rana
aecb17a59b
views/month-view-row: Only find first/last event widget if tabbing through another widget
...
This was overlooked from the original commit:
https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/598/diffs?commit_id=4ad8aeac65648f8d0873f8392cd8ab9109de5198#c04c121e2c8eebcfb09fbcbeecff310223fe987f_471_600
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/706 >
2026-02-24 19:46:35 -05:00
Hari Rana
e1c139782f
views/month-view-row: Implement keyboard navigation for event widgets vertically
2026-02-24 21:22:26 -03:00
Hari Rana
4901709e63
views/month-view-row: Implement keyboard navigation for event widgets horizontally
...
Ideally, we should be comparing if the Y coordinate of both the
candidate and focused widgets are identical, but given font
sizing issues with special characters such as emojis
(see https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/1519 ),
it is safer to check if these widgets intersect vertically, as
otherwise a single pixel offset may cause keyboard focus to
completely skip event widgets.
2026-02-24 21:11:40 -03:00
Hari Rana
4ae0997c3f
views/month-view-row: Focus first and last event widgets
...
This also creates the FocusEventData struct, which stores
relevant information to compare and contrast event widgets.
2026-02-24 20:44:51 -03:00
Hari Rana
08e8318889
views/month-view: Allow navigating with Tab
...
This also notifies if keyboard navigation fails.
2026-02-24 20:05:15 -03:00
Automeris naranja
6950324d17
calendars-page: Port to AdwPreferencesPage
...
This simplifies the UI code a bit.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/446 >
2026-02-21 21:35:09 -05:00
Georges Basile Stavracas Neto