Commit Graph
1750 Commits
Author SHA1 Message Date
Günther Wutz b83b2b4e46 month-popover: typo fix in comment 2017-11-16 17:14:25 -02:00
Georges Basile Stavracas Neto 34d20a07ec month-popover: remove leftover comment 2017-11-15 21:04:46 -02:00
Georges Basile Stavracas Neto 4d23949a99 month-view: properly update today mark
https://bugzilla.gnome.org/show_bug.cgi?id=775103
2017-11-15 20:15:28 -02:00
Georges Basile Stavracas Neto 54839efbf4 month-view: fix rtl
This removes much of the subtle complexities of the size allocation
function in month view, and finally delivers a readable and working
implementation of the month view.

This also introduces a small code refactoring, and fixes clicking
on a cell on RTL.
2017-11-15 19:03:10 -02:00
Georges Basile Stavracas Neto b638a1537c event-widget: also compare by multiday 2017-11-15 15:32:37 -02:00
Georges Basile Stavracas Neto 09cd5d05cb month-popover: sort events 2017-11-15 03:17:04 -02:00
Georges Basile Stavracas Neto 72b9b34235 month-view: win the fight against the sizing machinery
We can now guarantee that the month cells unconditionally get
their desired allocations, but the event widgets are only created
when necessary.

I won.
2017-11-15 02:31:03 -02:00
Georges Basile Stavracas Neto eff50668d4 month-view: introduce new overflow popover window
This ~almost~ implements a perfectly semantic transition (which
is kinda impossible now).
2017-11-15 02:03:26 -02:00
Georges Basile Stavracas Neto 8d6785b6f7 month-view: implement a different hiding algorithm
As if the previous one wasn't crazy enough :(
2017-11-13 19:27:55 -02:00
Georges Basile Stavracas Neto b4cc36b344 month-view: fight the sizing machinery even harder
Make sure something changed in child widgets AND events,
otherwise just top allocating at all.
2017-11-13 17:06:38 -02:00
Georges Basile Stavracas Neto 31409b6e44 month-view: improve layout algorithm
Multiday event handling was a mess, and still it. But this commit
makes it at least layout things correctly.

It's not perfect, though; This commit brought back that terrible
allocation cycle issue, since we're showing and hiding events in
size-allocate.
2017-11-13 14:23:35 -02:00
Georges Basile Stavracas Neto 2c9f7e2041 month-view: reorganize header 2017-11-13 12:44:04 -02:00
Georges Basile Stavracas Neto 86b565a817 month-view: Improve code readability
No real changes except code reorganization and refactoring, just
to make it a little bit less painful to read and maintain.
2017-11-13 12:40:45 -02:00
Georges Basile Stavracas Neto 2a11959bdd month-cell: show +X in overflow label
Instead of "Other X Events".
2017-11-11 18:15:18 -02:00
Georges Basile Stavracas Neto b5ad149261 month-cell: improve calculation of header box height
Should also consider the top and bottom margins.
2017-11-11 18:15:02 -02:00
Georges Basile Stavracas Neto 4dd4c2410f month-cell: Move day label to top, split from overflow 2017-11-11 17:48:59 -02:00
Florian Brosch 22b0014bf9 source-dialog: Use the right file chooser action 2017-11-08 23:44:21 -02:00
Florian Brosch 1e1216d3f7 sourc-edialog: rename owncloud to nextcloud 2017-11-08 23:43:48 -02:00
Florian Brosch 8d55c7ea04 source-dialog: Avoid known file extensions in calendar name suggestions 2017-11-08 23:40:45 -02:00
Florian Brosch 4b3351d549 source-dialog: Convert filename to utf8 before displaying it 2017-11-08 23:32:31 -02:00
Florian Brosch 4c84cfbbdb source-dialog: plug two memory leaks 2017-11-08 23:28:19 -02:00
Georges Basile Stavracas Neto caffb60065 utils: add autoptr support for ESource 2017-11-08 23:26:25 -02:00
Georges Basile Stavracas Neto 5977eeefc8 month-cell: only update label when date changes
If the date is the same, we don't need to update the label.
This might cause an infinite resize loop.
2017-10-31 01:11:26 -02:00
Georges Basile Stavracas Neto 907e55ccbe month-view: remove reminescent dnd code
Month view does not manage Drag n' Drop anymore, but
this code was left behind by accident.
2017-10-31 01:00:15 -02:00
Georges Basile Stavracas Neto 1e54c9db12 month-view: only idle add month cell update when necessary 2017-10-31 00:34:45 -02:00
Georges Basile Stavracas Neto 523609f2c0 month-view: always update month cells in idle
This way, we can schedule the multiple resizing queueing
operations to after the size-allocate phase is over.
2017-10-29 19:05:42 -02:00
Georges Basile Stavracas Neto e04b7f0fd3 event-widget: lazily relayout main grid 2017-10-29 19:05:34 -02:00
Georges Basile Stavracas Neto 3411dbb13d month-view: don't outsmart GTK resizing machinery
If we need to resize, then let's just accept we need to
resize the month view (event if that's an expensive
operation) and do the resizing.

This fixed many minor annoyances like invisible overflow
labels, on-the-fly text direction changes, etc.
2017-10-07 11:40:48 -03:00
Georges Basile Stavracas Neto ff9c663c8c month-view: only update selection if there's a start date
We can potentially not have an end date set, but there's always
a start date. If there isn't, it means the user clicked from
outside of month view, or at an invalid cell, in which cases we
shouldn't display the quick add popover anyway.
2017-10-07 11:20:23 -03:00
Georges Basile Stavracas Neto a0c224a0d5 edit-dialog: alarm rows are not activatable
Otherwise, they show that annoying hover effect
that is ultimately useless, since clicking on the
row won't do anything.
2017-10-07 11:08:51 -03:00
Georges Basile Stavracas Neto df40a4d8bf month-view: don't hide month view when dragging from popover 2017-10-07 11:01:32 -03:00
Georges Basile Stavracas Neto 37fb5e8492 month-view: fix event positioning on RTL locales
We have to pick the mirrored column index on RTL locales.
2017-10-06 21:23:05 -03:00
Georges Basile Stavracas Neto f83471c609 window: trivial code refactoring 2017-10-06 20:32:00 -03:00
Georges Basile Stavracas Neto 999160495d log: accept NULL log domains 2017-10-06 20:32:00 -03:00
Georges Basile Stavracas Neto e59910f0e9 month-view: rewrite was a template widget 2017-10-06 20:32:00 -03:00
Iñigo Martínez 3d2ca61490 project: Fix missing translations
Gettext support in autotools does define ENABLE_NLS macro to 1 in
the autoconf generated configuration file. Due to the migration to
the meson build system, the procedure that defines This macro is
missing.

There is no reason to really disable i18n, so this fix removes the
condition that binds the text domain.

https://bugzilla.gnome.org/show_bug.cgi?id=787815
2017-09-20 19:14:17 -03:00
Georges Basile Stavracas Neto b9310a84a3 widgets: ensure types on class_init
This will avoid GtkBuilder crashing because it couldn't
find the correct type for a given widget.
2017-09-20 19:14:15 -03:00
Georges Basile Stavracas Neto 8a2376ae55 event: refactor gcal_event_is_multiday 2017-09-14 14:05:53 -03:00
Georges Basile Stavracas Neto f486569e19 week-grid: improve positioning code 2017-09-14 13:31:04 -03:00
Georges Basile Stavracas Neto 925e17e16c event-widget: fix dragging events 2017-09-14 13:26:28 -03:00
Georges Basile Stavracas Neto 25e5e9ecc1 view: don't add time headers in event lists
Nowadays, GcalEventWidget draws the time by itself. This
makes adding a time header pretty much useless.

Fix this double information by removing the time headers
from event listboxs.
2017-09-14 13:26:28 -03:00
Georges Basile Stavracas Neto 766de8c025 event-widget: remove alarm icon
This tiny icon wasn't really adding any value, but was
cluttering an already information-intensive view.
2017-09-14 13:26:28 -03:00
Georges Basile Stavracas Neto 2a923939d9 event-widget: draw horizontal timed events differently
This makes more clear which events are timed, and which events
are all day. They are also super cute!
2017-09-14 13:26:28 -03:00
Georges Basile Stavracas Neto 7dd42d4186 event-widget: add .timed style class to timed events
Another CSS tool for us to play with.
2017-09-14 13:26:28 -03:00
Georges Basile Stavracas Neto f42d5d0598 event-widget: add .vertical and .horizontal style classes
Depending on the GtkOrientation passed to it, just like the regular
behavior of GTK widgets. This way, we can have a finer control over
CSS selectors.
2017-09-14 13:26:28 -03:00
Georges Basile Stavracas Neto a853376629 event-widget: turn into a GtkBin subclass
The current GcalEventWidget implementation is a direct
GtkWidget subclass, which means we have to take care of
all the implementation details such as raising GdkWindows
and managing the drawing all by ourselves.

The event widget, however, can be easily described through
a GtkBuilder file. This would simplify the implementation
and makes us maintain less code.

Fix that by making GcalEventWidget a GtkBin subclass.
2017-09-14 13:26:28 -03:00
Georges Basile Stavracas Neto b3cfbe3d31 event-widget: update style 2017-09-14 13:26:28 -03:00
Georges Basile Stavracas Neto f3f2ba271b event-widget: update code style 2017-09-14 13:26:28 -03:00
Georges Basile Stavracas Neto d2d4e7a9b6 event-widget: remove unused prototypes
These are not implemented anymore, and just add more noise
to the header file.
2017-09-14 13:26:28 -03:00
Nidhi Gupta a5d1d9dc99 edit-dialog: set minimum number of occurrence to 2
An event should be considered as recurring only when it occurs
at least 2 times.

So to make sure the number of occurrences are at least 2,
set minimum value of recurrence spin button as 2.

https://bugzilla.gnome.org/show_bug.cgi?id=787054
2017-09-12 20:07:54 +05:30