Commit Graph
175 Commits
Author SHA1 Message Date
Georges Basile Stavracas Neto e60c8593dd window: propagate manager using properties 2017-09-07 14:35:44 -03:00
Georges Basile Stavracas Neto 05af332937 source-dialog: use DBus to spawn Control Center
In a Flatpak'd world, we cannot rely on the fact that
gnome-control-center binary will be installed at the
app's sandbox. But since it's a core app, we can rely
on the fact that it's available outside the sandbox.

To make it work, use DBus rather than raw spawn to
open control center.
2017-05-17 09:03:24 -03:00
Evgeny Shulgin 6728ddd019 source-dialog: use case-insensitive sorting in the calendar list
g_strcmp0() is used when comparing the display name of the ESource.
This is not a valid sort, because in this case we will get an order
like "a" < "z" < "B" < "Z", but it should be like "a", "B", "z", "Z".

We will use g_ascii_strcasecmp() to fix it.

https://bugzilla.gnome.org/show_bug.cgi?id=781231
2017-04-24 09:54:17 -03:00
Georges Basile Stavracas Neto 5396b946ad source-dialog: improve validation of remote calendars 2017-04-13 09:53:00 -03:00
Georges Basile Stavracas Neto fc074bcde3 source-dialog: improve URI handler
Now we have a more reliable way to detect whether
the passed URI is a file or a resource.

https://bugzilla.gnome.org/show_bug.cgi?id=780455
2017-04-13 09:17:52 -03:00
Georges Basile Stavracas Neto 7681b7a2da project: document classes 2017-04-12 15:17:17 -03:00
Yash Singh 7e68bfb150 source-dialog: change label to "Expired" if account credentials expire
Earlier Calendar showed an account as "on" even when the credentials had expired.

This patch fixes the issue and instead shows "Expired" label upon expiration of credentials.

https://bugzilla.gnome.org/show_bug.cgi?id=761766
2017-03-27 09:06:27 -03:00
Georges Basile Stavracas Neto 2544773645 manager: use EDS selectable property to track disabled agendas
This way, we can keep GNOME Calendar and Evolution synchronized.
And we can save some code too.
2017-03-17 21:25:23 -03:00
Georges Basile Stavracas Neto be137fca02 manager: unify completion flags
Instead of having a completion flag for GOA and calendars,
unify both of them and simplify some code.
2017-03-17 12:46:40 -03:00
Georges Basile Stavracas Neto cf6cdfd2aa project: use cairo_surface_t when possible
We can avoid an entire roundtrip from surface > pixbuf > surface
if we simply pass the surface to GtkImage. We also save quite
a bunch of debug lines.
2017-03-17 10:14:25 -03:00
Georges Basile Stavracas Neto d5825bbd35 project: override log domains
This way, we can have more useful debug spils.
2017-03-17 10:14:25 -03:00
Valentin Negoescu 7aa4cefa8e source-dialog: update calendar image color
After editing the color of a calendar its image is not
updated as well. Fix this by updating the image when the
edit is finished.

https://bugzilla.gnome.org/show_bug.cgi?id=773869
2017-03-05 20:51:26 -03:00
Mohammed Sadiq 0514d2b3b8 source-dialog: escape string in markup
Calendar name can potentially contain invalid markup texts.
So it have to be escaped to be safe.

https://bugzilla.gnome.org/show_bug.cgi?id=774986
2016-11-30 23:14:13 -02:00
Georges Basile Stavracas Neto cd50bec506 project: fix build warnings
https://bugzilla.gnome.org/show_bug.cgi?id=770466
2016-08-29 23:08:39 -03:00
Georges Basile Stavracas Neto de921ff54b source-dialog: open file when response is ok
The source dialog currently skips the file selected by
pressing the Open button.

Fix that by also considering the response of the dialog.
2016-06-01 11:59:22 -03:00
Thadeu Lima de Souza Cascardo c941326230 source-dialog: protect against NULL user address
e_webdav_discover_sources_finish can discover no user addresses and
return a NULL user_addresses. Check for that before calling
e_source_webdav_set_email_address.

https://bugzilla.gnome.org/show_bug.cgi?id=765170
2016-04-17 10:01:27 -03:00
Georges Basile Stavracas Neto 9ff5e05f9c app: automatically load resources from base path
We don't have to load most of the menus we're currently loading
by using the very handy automatic resource loading.

This patch fixup so the app loads resources automagically.
2016-02-16 18:12:18 -02:00
Georges Basile Stavracas Neto 50ce09617e source-dialog: remove private field 2016-01-19 20:03:19 -02:00
Erick Perez Castellanos 5f6bd95750 Fix gcal_manager_is_client_writable() semantics
Fix all the calls to it accordingly.
2015-10-07 08:39:51 -05:00
Milan Crha afdd726daf manager: fix bug #751209
https://bugzilla.gnome.org/show_bug.cgi?id=751209
2015-06-20 22:56:47 -03:00
Erick Pérez Castellanos d5cc7efcd0 build: fix merge leftovers 2015-05-25 12:43:49 -04:00
Georges Basile Stavracas Neto 0c47cda20c source-dialog: change visible page by pointers
Using their string representations was slow, compare
pointers which is fast.
2015-05-25 12:36:55 -04:00
Georges Basile Stavracas Neto b8fea7f1d1 source-dialog: fix memory leak
Free duplicated string when the listbox row is
destroyed.
2015-05-25 12:36:55 -04:00
Georges Basile Stavracas Neto 87c02b520a source-dialog: hide itself on response event 2015-05-25 12:36:55 -04:00
Erick Pérez Castellanos bb67518418 source-dialog: squash compilation warning 2015-05-25 12:36:55 -04:00
Georges Basile Stavracas Neto ef9d1301d9 source-dialog: use a builder .ui definition for interface
We know that coding interfaces sucks, so use a .ui file instead.
2015-05-25 12:36:54 -04:00
Erick Pérez Castellanos fdba286915 source-dialog: g_object_ref() returns the object 2015-05-25 12:36:54 -04:00
Erick Pérez Castellanos 53e3c04bb2 source-dialog: make NULL comparison explicit 2015-05-25 12:36:54 -04:00
Erick Pérez Castellanos 2677ec560a source-dialog: avoid unneeded comparisons
Sources are unique, so the comparison can be avoided once the source is
found
2015-05-25 12:36:54 -04:00
Erick Pérez Castellanos 1431f4b895 style: align arguments properly 2015-05-25 12:36:54 -04:00
Erick Pérez Castellanos 46a92fd96b source-dialog: join two conditionals
Below the main conditionals were another if with no else block.
Those can be joined using && operator.
Some minor style fixes in here also.
2015-05-25 12:36:54 -04:00
Erick Pérez Castellanos d1f437f4d9 style: use the entire line 2015-05-25 12:36:54 -04:00
Erick Pérez Castellanos d4f6963328 style: remove unneeded curly brackets 2015-05-25 12:36:54 -04:00
Erick Pérez Castellanos 899928e795 style: remove whitespace 2015-05-25 12:36:53 -04:00
Erick Pérez Castellanos 798b63903d source-dialog: sources are unique
Destroy the row and break the loop as soon as the source is found
2015-05-25 12:36:53 -04:00
Erick Pérez Castellanos cfa81e86a5 style: group variables declarations 2015-05-25 12:36:53 -04:00
Erick Pérez Castellanos cff0b59b2e style: ensure separation of code and declarations 2015-05-25 12:36:53 -04:00
Georges Basile Stavracas Neto bbcd5bcc49 source-dialog: use GtkEntry::get_text_length 2015-05-25 12:35:58 -04:00
Georges Basile Stavracas Neto e3e30140b3 source-dialog: use g_clear_object instead of manual free 2015-05-25 12:35:58 -04:00
Georges Basile Stavracas Neto 6213f5cc78 source-dialog: remove useless checks before freeing memory
g_free is NULL-proof, no need to check if it's NULL
before using it.
2015-05-25 12:35:58 -04:00
Georges Basile Stavracas Neto f9b3f2f6c7 source-dialog: remove unused enum 2015-05-25 12:35:58 -04:00
Georges Basile Stavracas Neto 27fa9983f4 manager: change ::get_client to ::get_goa_client
This explains better the purpose of the methods, and also
don't collide with the ECalClient prefix we already use.
2015-05-25 12:35:58 -04:00
Georges Basile Stavracas Neto 2b4e46a4b6 manager: notify when sources are enabled/disabled
Add the new signal for GcalManager::source-enabled that
notifies connected widgets about the source change. With
that, we can keep checkboxes syncronizes.
2015-05-25 12:35:58 -04:00
Georges Basile Stavracas Neto 023a79a90f source-dialog: bind source::display-name with label::label 2015-05-25 12:35:58 -04:00
Georges Basile Stavracas Neto 51a2695546 source-dialog: open online account settings when button is clicked 2015-05-25 12:35:57 -04:00
Georges Basile Stavracas Neto 60401426a2 source-dialog: silence gnome-control-center 2015-05-25 12:35:57 -04:00
Georges Basile Stavracas Neto 7482469b01 source-dialog: sort online accounts 2015-05-25 12:35:57 -04:00
Georges Basile Stavracas Neto 06e6f39721 source-dialog: remove accounts with GoaClient::account-removed 2015-05-25 12:35:57 -04:00
Georges Basile Stavracas Neto 1a580e3be5 source-dialog: hide empty goa rows instead of removing them 2015-05-25 12:35:57 -04:00
Georges Basile Stavracas Neto a8631eb99a source-dialog: initialize the icon name
Avoids some compiler warnings.
2015-05-25 12:35:57 -04:00