Commit Graph
1597 Commits
Author SHA1 Message Date
Georges Basile Stavracas Neto 352ebd40c3 window: code cleanup
Removes an unused function and an unused variable.
2015-01-09 09:16:43 -05:00
Georges Basile Stavracas Neto 0b4efe3bed window: don't change the header title when changed
As strongly recommended by the design team, it's redundant to have the 'Results for 'xyz'' title.
2015-01-09 09:16:42 -05:00
Georges Basile Stavracas Neto d65f01c3f2 window: show the search popover when the entry is mapped
This avois the flickering of the popover trying to reach an unmaped widget.
2015-01-09 09:16:42 -05:00
Georges Basile Stavracas Neto 0002e7640f search-view: update the view when a valid search occurs 2015-01-09 09:16:42 -05:00
Georges Basile Stavracas Neto 8933b1485a search-view: reset states when performs the search
Also, reset search when starting a new search from window.
2015-01-09 09:16:42 -05:00
Georges Basile Stavracas Neto 469999cd96 window: remove list button from search bar
We won't be using is for now, and it causes a lot of confusion. Also, the behavior is quite broken.
2015-01-09 09:16:42 -05:00
Georges Basile Stavracas Neto a458a7fb52 search-view: coding style fixes
This commit introduces no new code, as it only
change function ordering and some minor style
fixes.
2015-01-09 09:16:42 -05:00
Georges Basile Stavracas Neto 37566a435e search-view: run the search when the sources changes 2015-01-09 09:16:42 -05:00
Georges Basile Stavracas Neto f0c126b0ee window: fix header display 2015-01-09 09:16:42 -05:00
Georges Basile Stavracas Neto d5d1d37411 search-view: style it to better fit the HIG stardard 2015-01-09 09:16:42 -05:00
Georges Basile Stavracas Neto e88af3ab5f search-view: show properly a thin line before every result
This time, do not rely on CSS hacks.
2015-01-09 09:16:41 -05:00
Georges Basile Stavracas Neto a00bc04f71 window: properly show/hide search bar
Instead of relaying on hacks, properly toggle visibility based on the GtkRevealer::child-revealed property.
2015-01-09 09:16:41 -05:00
Georges Basile Stavracas Neto 7f24744455 window: don't hide search bar 2015-01-09 09:16:41 -05:00
Georges Basile Stavracas Neto d628c4b9fc search-label: show a friendly label when search entry is empty 2015-01-09 09:16:41 -05:00
Georges Basile Stavracas Neto ff54f7eb67 search-view: don't try to access NULL data
This should be better debugged, as it may be a thread syncronization problem.
2015-01-09 09:16:41 -05:00
Georges Basile Stavracas Neto ddb93d8d72 search-view: subscribe on demand
To avoid filling up the list with all events, subscribe only when the first search happens.
2015-01-09 09:16:41 -05:00
Georges Basile Stavracas Neto c9047c102f search-view: handle search independently
Instead of letting GcalWindow handle the searches,
make GcalSearchView handle it so the widget has
more control over the general appearance of the
popover.
2015-01-09 09:16:41 -05:00
Georges Basile Stavracas Neto 35fa63028a search-view: does not show the popover on startup
That would try to set relative to an unmapped widget, which causes awful things.
2015-01-09 09:16:41 -05:00
Georges Basile Stavracas Neto b5c80e1849 search-view: better width for labels
The labels are consuming too much space. This commit fix it.
2015-01-09 09:16:41 -05:00
Georges Basile Stavracas Neto fb7b738ff7 search-view: make it a GtkPopover descendant
This huge patch makes GcalSearchView a GtkPopover
descendant. Also, it poorly adapts GcalWindow to
make it work with it.
2015-01-09 09:16:40 -05:00
Georges Basile Stavracas Neto 6c7500c5b0 search-view: remove GcalSearchView::date_mask fiels
Completely replaced by "%x" formatting string on GDateTime.
2015-01-09 09:16:40 -05:00
Georges Basile Stavracas Neto a9de8dd3c1 search-view: remove GcalSearchView::time_mask field
It is unused and should be removed to avoid further headaches.
2015-01-09 09:16:40 -05:00
Georges Basile Stavracas Neto d72729356d search-view: respect system time format 2015-01-09 09:16:40 -05:00
Georges Basile Stavracas Neto 8742b47dc6 search-view: comment almost every function possible 2015-01-09 09:16:40 -05:00
Georges Basile Stavracas Neto cd4fb40281 search-view: major code cleanup 2015-01-09 09:16:40 -05:00
Georges Basile Stavracas Neto 95b35964cd search-view: fixed double border at the end of the list
Also, fixes a small details that the results list is
always expanded.
2015-01-09 09:16:40 -05:00
Georges Basile Stavracas Neto e34a587f16 window: properly hear GcalSearchView::'event-activated' signal
Data passed by search view's signal is different
from the other views, so special case this into
a new function.
2015-01-09 09:16:40 -05:00
Georges Basile Stavracas Neto a0e5a8564e search-view: properly connect 'row-activated' signal 2015-01-09 09:16:40 -05:00
Georges Basile Stavracas Neto 3cb6c0af25 search-view: emit GcalSearchView::'event-activated' signal
Needed so that GcalWindow can go to the selected event's date.
2015-01-09 09:16:39 -05:00
Georges Basile Stavracas Neto 90ad7f2cde search-view: remove obsolete prototype 2015-01-09 09:16:39 -05:00
Georges Basile Stavracas Neto 38311c27b5 search-view: ignore case when sorting events 2015-01-09 09:16:39 -05:00
Georges Basile Stavracas Neto 0c08577504 search-view: show 'All day' for all day events 2015-01-09 09:16:39 -05:00
Georges Basile Stavracas Neto a0b0cf1e46 search-view: make it looks more like the proposed design
The current implementation uses 2 hash tables, one
mapping (uuid : event data) and the other one mapping
(row : event data).

Events are added and removed from both of these tables,
but only GcalSearchView::events is responsible for the
destruction proccess.
2015-01-09 09:16:39 -05:00
Georges Basile Stavracas Neto 0c233fe3b3 search-view: define detroy functions for hash table 2015-01-09 09:16:39 -05:00
Georges Basile Stavracas Neto fb23939aa7 search-view: add hash of events
Maps uuid -> event data
2015-01-09 09:16:39 -05:00
Georges Basile Stavracas Neto f44179da43 search-view: remove obsolete comment, some style fixing 2015-01-09 09:16:39 -05:00
Georges Basile Stavracas Neto 26c27e880c search-view: change list row ordering
First step to reach the design proposed[1].

[1] https://dl.dropboxusercontent.com/u/5031519/calendar-search-result.png
2015-01-09 09:16:38 -05:00
Georges Basile Stavracas Neto 38213ae5d2 window: reset query when entering search mode
An empty query should show all events.
2015-01-09 09:16:38 -05:00
Georges Basile Stavracas Neto 397e1da5de window: make 'Calendar' the default title
Shows it for empty search results.
2015-01-09 09:16:38 -05:00
Georges Basile Stavracas Neto 900b55dce5 search-view: highlight date 2015-01-09 09:16:38 -05:00
Georges Basile Stavracas Neto c4724fc875 window: hear GcalSearchView::'event-activated' signal again 2015-01-09 09:16:38 -05:00
Georges Basile Stavracas Neto 1055709d40 search-view: don't cast to GcalView when emit signal
Also, remove the last traces of GcalView.
2015-01-09 09:16:38 -05:00
Georges Basile Stavracas Neto 36e51ac981 search-view: remove GcalView interface, add GcalSearchView::'search-activated' signal 2015-01-09 09:16:37 -05:00
Georges Basile Stavracas Neto baad1c352b Revert "window: hear GcalSearchView signals"
This reverts commit 3c5d833f0bc33213757479289cc0daabfa4667c5.
2015-01-09 09:16:37 -05:00
Erick Pérez Castellanos c68a499ad7 Revert "window: readd binding between search button and search mode"
This reverts commit f83c5865a3.

Conflicts:
	src/gcal-window.c
2015-01-09 09:16:37 -05:00
Erick Pérez Castellanos bdaf2dbc25 subscriber: files renaming before class renaming 2015-01-09 09:02:02 -05:00
Erick Pérez Castellanos e57d9ca55e year-view: initial GtkWidget::size_allocate impl
This impl uses internals structures from GcalSubscriber
2015-01-09 08:51:18 -05:00
Erick Pérez Castellanos 5f29241c64 year-view: add initial ::draw impl
So far support RTL drawing.
Missing:
+ Overflow indicators (this could be buttons)
+ selection borders drawing
2015-01-09 08:46:32 -05:00
Erick Pérez Castellanos 61e1101952 year-view: add orientation factor
This would be helpful in order to provide proper RTL drawing to the view
2015-01-09 08:44:37 -05:00
Erick Pérez Castellanos caf4031efe subscriber: rework ::remove and ::modified vfuncs
Since we have now access to the hash keeping the children of thw widget
there's no more need of calling GcalView::get_by_uuid
2015-01-09 08:43:21 -05:00