Federated_Computer/federated-calendar
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
1,597 Commits 3 Branches 0 Tags
abd6fa8b2d9207d8d28fa9836e1e336aecffa67f
Commit Graph
1155 Commits
Author SHA1 Message Date
Georges Basile Stavracas Neto abd6fa8b2d window: properly case ::manager property getter 
It's a readwrite property, thus it must have an
case PROP_MANAGER set in get_property.
 2015-12-31 00:37:36 -02:00
Georges Basile Stavracas Neto 961bf5dc88 window: setup edit dialog from UI file 
This commit sets up the edit dialog from the window's ui
resource file, in a series of commits that tries to move
all C code to the UI definitions.

Also, GcalManager is a full GObject class, not a simple
pointer. As such, update the property spec to be of type
object, not pointer.
 2015-12-30 17:37:12 -02:00
Georges Basile Stavracas Neto 13c4145507 edit-dialog: add ::writable and ::manager properties 
By using these properties, we gain the possibility to
bind them to the widgets and save some needless code.

This commit adds GcalEditDialog::writable and ::manager
properties. Other needed properties will be eventually
added in the subsequent commits.
 2015-12-30 17:34:29 -02:00
Georges Basile Stavracas Neto de207f9c63 edit-dialog: move bindings to UI file 
We don't need to manually bind these properties in
the source code if we can make it on the UI files.
 2015-12-30 15:05:20 -02:00
Georges Basile Stavracas Neto 4d19950c2c edit-dialog: cosmetic changes 
Fixes some alignment issues, as well as some
needless checks. Also, use some handy glib
functions to shrink the code even more.
 2015-12-30 14:59:16 -02:00
Georges Basile Stavracas Neto 3396291e3e edit-dialog: remove needless casts 
These widgets are already stored as GtkWidgets,
and there is no need to do these casts.
 2015-12-30 14:40:34 -02:00
Georges Basile Stavracas Neto 6f1eb7ca9d edit-dialog: turn into a final class 
This commit updates GcalEditDialog's code for
it to be a final class. As such, we don't need
the GcalEditDialogPrivate type - we can simply
move our data to the GcalEditDialog struct.
 2015-12-30 14:36:27 -02:00
Georges Basile Stavracas Neto 0ac827d87d edit-dialog: remove dead code 
This is already set in the UI definition file
for the dialog.
 2015-12-30 14:12:02 -02:00
Erick Perez Castellanos 9be7233f28 date-selector: fix typo 
The parsing of the date mask was never happening because it was always assuming
it was wrong.

Bug: https://bugzilla.gnome.org/show_bug.cgi?id=758391
 2015-12-22 23:55:12 -06:00
Erick Perez Castellanos cb25af0164 year-view: Get selected date before hiding popover 
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=757931
 2015-12-21 22:53:33 -06:00
Miguel Vaello Martínez 2001273c28 Fix uninitialized variable 
In the 'icaltime_compare_with_current' function, the 'result' was
uninitialized. As a consequence, this simplifies the if-else
condition.

https://bugzilla.gnome.org/show_bug.cgi?id=759588
 2015-12-21 20:11:42 -06:00
Georges Basile Stavracas Neto b6bec55185 month-view: don't show popover when clicking an invalid cell 
Because we're using a simple (gint) cast to round y value of
the clicked point, a negative y was rounding to a valid cell
position and showing the popover even when the user clicked
on the blank cells before the actual month view.

Fix that by properly checking if y is negative.

https://bugzilla.gnome.org/show_bug.cgi?id=755910
 2015-10-27 12:00:49 -02:00
Georges Basile Stavracas Neto 6afa9b98f6 month-view: fix mirroring macro 
It was using a local variable, which is a bad idea. It
only worked because we were using it in the context of
that local variable, but it was luck.
 2015-10-27 11:57:51 -02:00
Erick Perez Castellanos e611f87d6a manager: prevent excessive logging. 
Skip "Job failed" warning when the error is caused by ouselves cancelling the
thread.

Bug: https://bugzilla.gnome.org/show_bug.cgi?id=749337
 2015-10-21 08:49:55 -05:00
Erick Perez Castellanos e81f7090f4 date-selector: use glib string translations 
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=756412
 2015-10-20 09:35:54 -05:00
Erick Perez Castellanos 5f6bd95750 Fix gcal_manager_is_client_writable() semantics 
Fix all the calls to it accordingly.
 2015-10-07 08:39:51 -05:00
Alexandre Franke 8e38b15129 Unmark properties for translation 
It makes no sense here to have those translatable
 2015-08-31 22:31:24 +02:00
Georges Basile Stavracas Neto d644cbc8bf search-view: update UI to match upstream 
Latest GNOME applications follow a clear style of
searching and displaying results, with a no results
page.

To create a coherent usage between GNOME applications,
add the No results page to search popover.
 2015-07-17 02:19:44 -03:00
Georges Basile Stavracas Neto 6080b62368 manager: implement ::move method 2015-07-16 00:22:54 -03:00
Georges Basile Stavracas Neto d3a806a684 year-view: improve font rendering 
By using doubles instead of integers, we give a very
fluid resize effect for year view.
 2015-07-15 23:55:08 -03:00
Georges Basile Stavracas Neto 10e340c20f manager: initialize value 
Avoids calling g_free on uninitialized memory,
which results in a nasty segfault.
 2015-07-15 21:18:52 -03:00
Georges Basile Stavracas Neto b1540e3f41 window: code cleanup 
Remove the unneeded code to manage search bar visibility,
since it is correctly hidden now. Also, clean up some UI
code.
 2015-07-15 20:57:12 -03:00
Georges Basile Stavracas Neto 0c1df74735 month-view: add keyboard navigation 
This big patch implements keyboard navigation for
Month view and the main window. Also, refactor
some of it's drawing code.
 2015-07-15 20:40:55 -03:00
Milan Crha 6a39614e38 Bug 751206 - correct trust prompt for collection sources 
This enables trust prompts for collection sources. Note the changes from the
above cited bug are needed to have this fully and properly working.

https://bugzilla.gnome.org/show_bug.cgi?id=751206
 2015-06-20 23:04:10 -03:00
Milan Crha 3e97490e1d Bug 751211 - crash on ESource::read-only property change notification 
Two things changes:
a) the actual crash cause in on_client_readonly_changed(), to test whether
   the 'unit' is valid at all before dereferencing it
b) the callback doesn't seem to be disconnected at all, thus added a disconnect
   of it on the source removal as well

The b) might be enough, but just to be sure I included also a).

https://bugzilla.gnome.org/show_bug.cgi?id=751211
 2015-06-20 23:00:40 -03:00
Milan Crha afdd726daf manager: fix bug #751209 
https://bugzilla.gnome.org/show_bug.cgi?id=751209
 2015-06-20 22:56:47 -03:00
Georges Basile Stavracas Neto 1f666ba405 window: move forward/backward according to locale 2015-06-04 15:44:48 -03:00
Georges Basile Stavracas Neto 5381dc77a4 month-view: update focused cell on mouse events 
Also, quit selection mode when Escape is pressed
 2015-06-04 13:02:47 -03:00
Georges Basile Stavracas Neto e4b5da7f50 month-view: implement keyboard navigation 
For this to be made, some significant changes on the inners
of GcalMonthView had to be done. Later on, I'll do a complete
rewrite of it, deprecating the use of 'sw' and 'k'.
 2015-06-04 12:48:50 -03:00
Piotr Drąg bf2eb4771c Fix minor typos in a comment 2015-06-03 21:10:59 +02:00
Erick Pérez Castellanos fd54a863f4 date-selector: fix crash on some locales 
As stated on the bug below Calendar crashes in some locales because of the
parsing of the string representing the date. Since parsing this string can be
very tricky, we decided to make a simple translatable string with the format it
is needed and th translators can set the proper order according to his locale.

The translatable string goes as "%d/%m/%y" being %d the representation of the
day, %m the representation of the month and, %y, the year. The translators
should place it in the correct order for its locale, for instance en_US, should
place it: "%m/%d/%y"

The validation of the translated string is lacking some strength. It could use
some improving.

Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1226823
 2015-06-03 14:46:00 -04:00
Georges Basile Stavracas Neto b7476cb84c manager: only load calendar sources 
Do not blindly load every source loaded by the
ESourceRegistry::source-added, since it may be
a non-calendar source.
 2015-05-25 14:05:49 -03:00
Erick Pérez Castellanos d5cc7efcd0 build: fix merge leftovers 2015-05-25 12:43:49 -04:00
Georges Basile Stavracas Neto 0c47cda20c source-dialog: change visible page by pointers 
Using their string representations was slow, compare
pointers which is fast.
 2015-05-25 12:36:55 -04:00
Georges Basile Stavracas Neto b8fea7f1d1 source-dialog: fix memory leak 
Free duplicated string when the listbox row is
destroyed.
 2015-05-25 12:36:55 -04:00
Georges Basile Stavracas Neto 87c02b520a source-dialog: hide itself on response event 2015-05-25 12:36:55 -04:00
Erick Pérez Castellanos bb67518418 source-dialog: squash compilation warning 2015-05-25 12:36:55 -04:00
Georges Basile Stavracas Neto c1b14e48d4 window: comment misleading destruction of calendar row 2015-05-25 12:36:55 -04:00
Georges Basile Stavracas Neto ef9d1301d9 source-dialog: use a builder .ui definition for interface 
We know that coding interfaces sucks, so use a .ui file instead.
 2015-05-25 12:36:54 -04:00
Georges Basile Stavracas Neto f63541f475 manager: unred GOA client on finalize 2015-05-25 12:36:54 -04:00
Georges Basile Stavracas Neto 18f0026eb7 manager: use goa_client for private field 
To not confuse it with the many other clients we
already have here
 2015-05-25 12:36:54 -04:00
Erick Pérez Castellanos 3d7ffdbaa7 app: add GbScrolledWindow 
GbScrolledWindow comes from Builder, courtesy of christian Hergert.
We'll use it in calendars' popover.
 2015-05-25 12:36:54 -04:00
Erick Pérez Castellanos fdba286915 source-dialog: g_object_ref() returns the object 2015-05-25 12:36:54 -04:00
Erick Pérez Castellanos 53e3c04bb2 source-dialog: make NULL comparison explicit 2015-05-25 12:36:54 -04:00
Erick Pérez Castellanos 2677ec560a source-dialog: avoid unneeded comparisons 
Sources are unique, so the comparison can be avoided once the source is
found
 2015-05-25 12:36:54 -04:00
Erick Pérez Castellanos 1431f4b895 style: align arguments properly 2015-05-25 12:36:54 -04:00
Erick Pérez Castellanos 46a92fd96b source-dialog: join two conditionals 
Below the main conditionals were another if with no else block.
Those can be joined using && operator.
Some minor style fixes in here also.
 2015-05-25 12:36:54 -04:00
Erick Pérez Castellanos d1f437f4d9 style: use the entire line 2015-05-25 12:36:54 -04:00
Erick Pérez Castellanos d4f6963328 style: remove unneeded curly brackets 2015-05-25 12:36:54 -04:00
Erick Pérez Castellanos 899928e795 style: remove whitespace 2015-05-25 12:36:53 -04:00