Georges Basile Stavracas Neto
e39bd95c87
log: Use g_autofree
2019-09-14 10:39:38 -03:00
Michael Catanzaro
5d2c0faf41
Fix use-after-free in GcalManager code
...
This was originally discovered and fixed by Milan Crha; I'm just
forward-porting his fix to the master branch. self->clients takes
ownership of this source but we don't currently have ownership here,
leading to a double free vulnerability.
Fixes #435
2019-09-03 12:07:26 +00:00
Michael Catanzaro
748b7207e7
Don't leave dangling pointers in the GcalEvent cache
...
The cache has an unowned pointer to the GcalEvent's UID. We need to
update the cache with the GcalEvent's new UID to avoid use-after-free.
Fixes #434
2019-08-25 17:39:01 +03:00
Georges Basile Stavracas Neto
b49486d0f9
calendar: Disconnect from the visible signals as well
...
Missed from the initial implementation.
2019-07-13 19:54:47 -03:00
Georges Basile Stavracas Neto
07acf540ae
calendar: Disconnect from the correct object
...
The name changed signal comes from the ESource, not
the extension.
2019-07-13 19:54:17 -03:00
Georges Basile Stavracas Neto
bb2a1321be
calendar: Use gulong for signal handlers
...
They are unsigned longs, not unsigned ints.
2019-07-13 19:52:53 -03:00
Georges Basile Stavracas Neto
1d6dee8bbb
manager: Avoid reentrancy
...
While deleting the calendar, we may run into a situation
where the GcalCalendar instance is destroyed before the
GcalManager:calendar-removed signal is emitted, causing
us to emit the signal with a destroyed object.
Prevent that by increasing the ref count before emiting
the signal.
2019-07-13 19:51:02 -03:00
Georges Basile Stavracas Neto
a2d15697d9
log: Increase prefix width
...
GcalCalendarManagementDialog is too wide and breaks the log
layout, so increase the spacing to fit it.
2019-06-24 21:32:58 -03:00
Georges Basile Stavracas Neto
badd1fb0f1
calendar: Fix double free
...
The GError is unreferenced twice.
2019-05-24 21:25:28 -03:00
Milan Crha
a0cae4356a
Port to libecal-2.0
...
Fixes https://gitlab.gnome.org/GNOME/gnome-calendar/merge_requests/70
2019-05-17 21:58:55 +02:00
Georges Basile Stavracas Neto
198180d023
manager: Fix typo
2019-05-10 13:44:43 -03:00
Georges Basile Stavracas Neto
f4c4a91465
manager: Add 'synchronizing' property
...
Will be useful to know if there are any clients being
synchronized.
2019-05-10 12:42:13 -03:00
Georges Basile Stavracas Neto
7ad0f100a7
manager: Properly bind default calendar
...
We need to convert from ESource to GcalCalendar.
2019-05-10 11:20:51 -03:00
Georges Basile Stavracas Neto
a2609d6853
project: Reorganize much
2019-05-04 19:48:40 -03:00
Georges Basile Stavracas Neto
bb8d5b92ce
manager: Handle default calendars via GcalCalendar
2019-05-04 12:05:39 -03:00
Georges Basile Stavracas Neto
ada9bcc473
calendar: Fix signal handler cleanup on finalize()
2019-05-04 12:05:39 -03:00
Georges Basile Stavracas Neto
245df513d7
event: Simplify color handling
...
We can use GcalCalendar::color property directly now.
2019-05-04 12:05:39 -03:00
Georges Basile Stavracas Neto
02cbfdadf2
calendar: Make it a derivable class
2019-05-04 12:05:39 -03:00
Georges Basile Stavracas Neto
df182d1b88
manager: Remove "loading" property
...
The stack is robust enough to handle dynamically
loading the calendars.
2019-05-04 12:05:39 -03:00
Georges Basile Stavracas Neto
e7c6120133
manager: Remove gcal_manager_is_client_writable()
...
It is now handled by GcalCalendar, and nobody else uses
it.
2019-05-04 12:05:39 -03:00
Georges Basile Stavracas Neto
e800bb2476
manager: Remove gcal_manager_enable/disable_source()
...
This is now managed by GcalCalendar itself.
2019-05-04 12:05:39 -03:00
Georges Basile Stavracas Neto
2ef1cbc463
manager: Toggle data model sources when changed
...
Instead of other classes needing to manually set and
unset whether a source is registered in the data model,
we can now simply call GcalCalendar.set_visible() and
have the model be updated for us.
2019-05-04 12:05:39 -03:00
Georges Basile Stavracas Neto
64fa11f4c0
calendar: Fix double unref
2019-05-04 12:05:39 -03:00
Georges Basile Stavracas Neto
1a5ff545a2
project: Move a few classes to core/
2019-05-04 12:05:39 -03:00
