Georges Basile Stavracas Neto
17e5327cf4
manager: prevent a segfault when opening edit dialog with no sources connected
2015-01-13 17:10:39 -02:00
Georges Basile Stavracas Neto
5423280398
edit-dialog: use UI file to connect signals
...
Fixes bug #739313 .
2015-01-13 17:02:07 -02:00
Georges Basile Stavracas Neto
c799acf482
edit-dialog: calculate all_day before using it to set the dates
...
It was using the all_day var before actually using it.
This caused an issue where the start time showed as the current time.
2015-01-13 16:18:40 -02:00
Georges Basile Stavracas Neto
b1daf9eeb4
edit-dialog: remove unused field
...
The old times when calendar used GtkTreeIter has passed, and it no longer needs the active iter field.
2015-01-13 13:29:17 -02:00
Georges Basile Stavracas Neto
3cf37cc3d2
window: remove unused prototype
...
The code was implemented at gcal-utils, so no need to have it here.
2015-01-13 13:25:11 -02:00
Georges Basile Stavracas Neto
6de2bdd292
edit-dialog: fix missing icons from source selection menu
2015-01-13 13:23:42 -02:00
Georges Basile Stavracas Neto
6094cb7b69
window: fix missing icons from calendar management menu
2015-01-13 13:23:10 -02:00
Georges Basile Stavracas Neto
b44f14bdf2
utils: added code to show the GtkPopover menu's icons
...
This will be useful for the next commits, which will introduce a fix for the hidden icons at calendar menus.
2015-01-13 13:21:48 -02:00
Erick Pérez Castellanos
eee9d11633
window: move search-view into ui file
...
This new impl of search-view will allow a lot of cleaning on GcalWindow impl
2015-01-09 15:01:02 -05:00
Erick Pérez Castellanos
ea21ffdd70
search-view: internal manager is not a property
...
The idea here it to include SearchView as a widget in GcalWindow
Builder UI file.
2015-01-09 15:01:01 -05:00
Georges Basile Stavracas Neto
7f8e8eaa1f
window: show search view when animation finish, hide when animation starts
...
This prevents a warning, and makes the behavior a little bit more polished.
2015-01-09 12:53:42 -02:00
Georges Basile Stavracas Neto
ee09608a58
search-view: remove non-working connection
...
All the source update stuff is done internally by ECalDataModel, and we don't need to do it again.
2015-01-09 12:40:16 -02:00
Erick Pérez Castellanos
79f4000271
year-view: fix reminders of the merge
2015-01-09 09:22:03 -05:00
Erick Pérez Castellanos
029e34a205
year-view: remove debug statement
2015-01-09 09:16:44 -05:00
Erick Pérez Castellanos
372c6fba3d
search-view: fix memory leak
...
Use internal icaltimetype from ECalComponentDateTime. Mark
GcalSearchView::event-activated signal parameter as constant.
2015-01-09 09:16:44 -05:00
Erick Pérez Castellanos
4832f5e79e
providers: remove from screen on app::finalize
...
This fixes the quirks of decreasing the refcount after attaching the
providers to the default screen.
2015-01-09 09:16:44 -05:00
Georges Basile Stavracas Neto
bc17a9b38b
search-view: right-align icons
2015-01-09 09:16:44 -05:00
Georges Basile Stavracas Neto
54aa3933fc
search-view: show icons for event attributes
...
For now, only the alarm and lock icons are showed.
2015-01-09 09:16:44 -05:00
Georges Basile Stavracas Neto
3ed508b8c0
search-view: order by date, instead of name
2015-01-09 09:16:43 -05:00
Georges Basile Stavracas Neto
352ebd40c3
window: code cleanup
...
Removes an unused function and an unused variable.
2015-01-09 09:16:43 -05:00
Georges Basile Stavracas Neto
0b4efe3bed
window: don't change the header title when changed
...
As strongly recommended by the design team, it's redundant to have the 'Results for 'xyz'' title.
2015-01-09 09:16:42 -05:00
Georges Basile Stavracas Neto
d65f01c3f2
window: show the search popover when the entry is mapped
...
This avois the flickering of the popover trying to reach an unmaped widget.
2015-01-09 09:16:42 -05:00
Georges Basile Stavracas Neto
0002e7640f
search-view: update the view when a valid search occurs
2015-01-09 09:16:42 -05:00
Georges Basile Stavracas Neto
8933b1485a
search-view: reset states when performs the search
...
Also, reset search when starting a new search from window.
2015-01-09 09:16:42 -05:00
Georges Basile Stavracas Neto
469999cd96
window: remove list button from search bar
...
We won't be using is for now, and it causes a lot of confusion. Also, the behavior is quite broken.
2015-01-09 09:16:42 -05:00
Georges Basile Stavracas Neto
a458a7fb52
search-view: coding style fixes
...
This commit introduces no new code, as it only
change function ordering and some minor style
fixes.
2015-01-09 09:16:42 -05:00
Georges Basile Stavracas Neto
37566a435e
search-view: run the search when the sources changes
2015-01-09 09:16:42 -05:00
Georges Basile Stavracas Neto
f0c126b0ee
window: fix header display
2015-01-09 09:16:42 -05:00
Georges Basile Stavracas Neto
e88af3ab5f
search-view: show properly a thin line before every result
...
This time, do not rely on CSS hacks.
2015-01-09 09:16:41 -05:00
Georges Basile Stavracas Neto
a00bc04f71
window: properly show/hide search bar
...
Instead of relaying on hacks, properly toggle visibility based on the GtkRevealer::child-revealed property.
2015-01-09 09:16:41 -05:00
Georges Basile Stavracas Neto
7f24744455
window: don't hide search bar
2015-01-09 09:16:41 -05:00
Georges Basile Stavracas Neto
d628c4b9fc
search-label: show a friendly label when search entry is empty
2015-01-09 09:16:41 -05:00
Georges Basile Stavracas Neto
ff54f7eb67
search-view: don't try to access NULL data
...
This should be better debugged, as it may be a thread syncronization problem.
2015-01-09 09:16:41 -05:00
Georges Basile Stavracas Neto
ddb93d8d72
search-view: subscribe on demand
...
To avoid filling up the list with all events, subscribe only when the first search happens.
2015-01-09 09:16:41 -05:00
Georges Basile Stavracas Neto
c9047c102f
search-view: handle search independently
...
Instead of letting GcalWindow handle the searches,
make GcalSearchView handle it so the widget has
more control over the general appearance of the
popover.
2015-01-09 09:16:41 -05:00
Georges Basile Stavracas Neto
b5c80e1849
search-view: better width for labels
...
The labels are consuming too much space. This commit fix it.
2015-01-09 09:16:41 -05:00
Georges Basile Stavracas Neto
fb7b738ff7
search-view: make it a GtkPopover descendant
...
This huge patch makes GcalSearchView a GtkPopover
descendant. Also, it poorly adapts GcalWindow to
make it work with it.
2015-01-09 09:16:40 -05:00
Georges Basile Stavracas Neto
6c7500c5b0
search-view: remove GcalSearchView::date_mask fiels
...
Completely replaced by "%x" formatting string on GDateTime.
2015-01-09 09:16:40 -05:00
Georges Basile Stavracas Neto
a9de8dd3c1
search-view: remove GcalSearchView::time_mask field
...
It is unused and should be removed to avoid further headaches.
2015-01-09 09:16:40 -05:00
Georges Basile Stavracas Neto
d72729356d
search-view: respect system time format
2015-01-09 09:16:40 -05:00
Georges Basile Stavracas Neto
8742b47dc6
search-view: comment almost every function possible
2015-01-09 09:16:40 -05:00
Georges Basile Stavracas Neto
cd4fb40281
search-view: major code cleanup
2015-01-09 09:16:40 -05:00
Georges Basile Stavracas Neto
95b35964cd
search-view: fixed double border at the end of the list
...
Also, fixes a small details that the results list is
always expanded.
2015-01-09 09:16:40 -05:00
Georges Basile Stavracas Neto
e34a587f16
window: properly hear GcalSearchView::'event-activated' signal
...
Data passed by search view's signal is different
from the other views, so special case this into
a new function.
2015-01-09 09:16:40 -05:00
Georges Basile Stavracas Neto
a0e5a8564e
search-view: properly connect 'row-activated' signal
2015-01-09 09:16:40 -05:00
Georges Basile Stavracas Neto
3cb6c0af25
search-view: emit GcalSearchView::'event-activated' signal
...
Needed so that GcalWindow can go to the selected event's date.
2015-01-09 09:16:39 -05:00
Georges Basile Stavracas Neto
90ad7f2cde
search-view: remove obsolete prototype
2015-01-09 09:16:39 -05:00
Georges Basile Stavracas Neto
38311c27b5
search-view: ignore case when sorting events
2015-01-09 09:16:39 -05:00
Georges Basile Stavracas Neto
0c08577504
search-view: show 'All day' for all day events
2015-01-09 09:16:39 -05:00
Georges Basile Stavracas Neto
a0b0cf1e46
search-view: make it looks more like the proposed design
...
The current implementation uses 2 hash tables, one
mapping (uuid : event data) and the other one mapping
(row : event data).
Events are added and removed from both of these tables,
but only GcalSearchView::events is responsible for the
destruction proccess.
2015-01-09 09:16:39 -05:00