"Report an Issue" now redirects to the issues overview page instead of
directly creating a new issue which is only possible for logged in
users.
Fixes: #1206
Use a GtkListBox and bind from the model. Create rows from the model
items, and bind properties as needed.
The action target is set only when the calendar is writable because
setting an invalid action+target pair makes the row insensitive.
Remove the ancient menu icon hack.
- Fix a bug where clicking the "Add Event" button created an empty title in the event editor dialog.
- Add "error" class when the user writes an invalid event name.
- Add new function to validate event name.
Because the sections are split into files, the event editor will need a signal to check that each section is correct, and each section will have to emit the signal. This will need to be done in a future commit.
The "Done" button was apparently meant for read-only events,
while the "Save" action was for everything else.
It didn't work correctly because of a mismatch between code and UI XML.
Fixes: https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/1142
Holding and releasing the weather service makes sure it
is stopped whenever no UI depends on it.
Signed-off-by: Markus Göllnitz <camelcasenick@bewares.it>
Splitting an activation flag from starting and stopping
the service makes it possible to flag the service as
wanted from the settings and still due use counting in a
subsequent commit.
Signed-off-by: Markus Göllnitz <camelcasenick@bewares.it>
This helps in preparation of splitting out a dedicated
activation flag from the actually starting and stopping
the service.
Signed-off-by: Markus Göllnitz <camelcasenick@bewares.it>
Libadwaita's about window widget let's expose debug information, that's
useful for bug reports, users can open up the about window and just
copy/paste debug information on the bug report.
Closes https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/1114
Currently, if you have lots of calendars you need to scroll all the way
to the bottom of list to have access to the "New Calendar" button.
This commit moves the "New Calendar" button to be on a bottom toolbar
provided by AdwToolbarView. It makes the button always on view and easy
to access.
Closes https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/1051
This patch fixes an issue when creating new events in week view the week
after the daylight saving change.
The problem was in the calc of the selected date, that's done couting
the 30 minutes slots and adding that minutes to the week_start datetime.
When there's a daylight saving change, the real date to select should be
adjusted. This patch adds a new util function to make it easy to add
minutes ignoring the tz so we can make this calc directly with
gcal_date_time_add_floating_minutes.
This also includes a new test file with some checks for the new util
function and spring / autumn changes.
This new function could be used in other places to fix specific issues
that could be caused by the same logic error, calculate a selection or
event position based on GDateTime operations.
Fix https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/482