Commit Graph
148 Commits
Author SHA1 Message Date
Piotr Drąg 93fa37ce11 Replace three dots with a proper ellipsis 2015-01-20 19:22:35 +01:00
Erick Pérez Castellanos 0f13cb4a11 month-view: optimize days_delay update
No need of memory allocation and releasing which is costly.
2015-01-20 13:12:01 -05:00
Erick Pérez Castellanos 0b2367200b copyright: update year 2015-01-20 13:11:58 -05:00
Erick Pérez Castellanos d15c4a5c1b view iface: remove manager property
There's no reason at all why manager should be a property inside the
views. It won't benefit of bindings or anything else inherent to GObject
property system.
2015-01-20 13:11:58 -05:00
Erick Pérez Castellanos 5a3e9577f2 view: fix gdk relayout warning 2015-01-08 13:04:49 -05:00
Erick Pérez Castellanos 13a2aad87b month-view: impl ::clear_state vfunc
Implementing GcalSubscrberView::clear_state allow month-view to use
GcalSubscriberView::setup_child when handling overflow widgets
2015-01-05 10:33:27 -05:00
Erick Pérez Castellanos e0b26dd6f7 style: misc fixes 2015-01-05 10:33:27 -05:00
Erick Pérez Castellanos 22eda85632 month-view: use subscriber-view internals 2015-01-05 10:33:27 -05:00
Erick Pérez Castellanos a5fe4c5ef0 subscriber-view: use ::setup_child protected func 2015-01-05 10:33:26 -05:00
Erick Pérez Castellanos 663f1c6fa4 build: remove not-used code 2015-01-05 10:33:26 -05:00
Erick Pérez Castellanos 9994377c9f subscriber-view: gained ::get_child_by_uuid vfunc
Started migrating methods from GcalView to GcalSubscriber
2015-01-05 10:33:26 -05:00
Erick Pérez Castellanos 0e5c197c2f subscriber: renamed to GcalSubscriberView
This is more of a semantic change than anything else. GcalSubscriber
will gradually take on GcalView interface and that's why I'm adding the
View suffix.
2015-01-05 10:33:26 -05:00
Erick Pérez Castellanos 11324a6712 month-view: fix all-day events end-date
All-day events has an end-date one day after they really end.
2014-12-26 16:53:05 -05:00
Erick Pérez Castellanos 443a502b1f month-view: fix ::forall impl leaking 2014-12-26 12:02:15 -05:00
Erick Pérez Castellanos b66d4eb21c misc: fix memory leak 2014-12-26 12:01:53 -05:00
Erick Pérez Castellanos e6a929f3fd view: remove ::mark_current_unit
New event action will open edit-dialog directly so this method is not needed
2014-12-25 20:24:36 -05:00
Erick Pérez Castellanos 2261ea6909 month-view: fix memory leak
Remove unneeded debug instructions
2014-12-25 18:47:54 -05:00
Erick Pérez Castellanos a7aed0987a month-view: fix draw and allocation on 6 rows months
Sometimes months expand 6 rows completely instead of the regular
5. March, 2015 is an example of it. Allocation of widgets, drawing
of indicators, placement of the overflow popover was wrong.
2014-12-24 13:33:29 -05:00
Georges Basile Stavracas Neto fb57d5998a month-view: better handle overflow background draw 2014-12-23 21:35:05 -02:00
Erick Pérez Castellanos 1de6a8b87a misc: whitespace and code style minor fixes 2014-12-22 21:56:38 -05:00
Erick Pérez Castellanos 0ff177c1d8 comments: document utils functions, add FIXME 2014-12-22 21:55:55 -05:00
Erick Pérez Castellanos 4eabc0223b build: remove unneeded code
GObject type system zeroing instance private data, so initialization to
NULL and FALSE is not needed.
Misc code styles fixes.
2014-12-22 21:52:35 -05:00
Erick Pérez Castellanos 442b26b5ea month-view: properly handle all-day events
Note: when the marking of break events is made, this have to be taken
into account.
2014-12-22 14:54:05 -05:00
Erick Pérez Castellanos 3f093c5e13 month-view: fix drawing of overflow indicator
The drawing was happening but the clipping was not including the full
widget. Queuing a new draw expands the clip to the whole area of the widget.
2014-12-22 10:01:58 -05:00
Benjamin Otte 45601d39a2 Use d_ngettext() in printf format directly
.. instead of going via an intermediate variable.
This way, gcc is smart enough to detect that the format string is indeed
static and not throw a warning.
2014-12-22 15:10:20 +01:00
Erick Pérez Castellanos e2d4e52ec7 month-view: monitor click only on overflow indicator 2014-12-22 08:38:19 -05:00
Erick Pérez Castellanos c97473e955 month-view: emit ::create-event-detailed
Emit this signal from the "Add new event..." button of overflow popover,
the reason is mainly aesthetics since it won't look good showing one
popover after another.
2014-12-22 08:38:18 -05:00
Erick Pérez Castellanos 56f7f88572 month-view: fix insert ordered widgets
The head of the list might changed when ordering the list at insertion,
then, some events was getting lost
2014-12-22 08:38:18 -05:00
Erick Pérez Castellanos 4bef6148f9 month-view: sort single-day event widgets by start date
This guarantee that events widgets appear sorted by its start date on
the overflow popover
2014-12-20 09:10:00 -05:00
Erick Pérez Castellanos f9627fcf98 month-view: show start time header on overflow popover 2014-12-20 09:10:00 -05:00
Erick Pérez Castellanos 9badd9f502 month-view: read 12/24 time format setting
The setting will be used when showing the start time of events in the
overflow popover.
2014-12-20 09:10:00 -05:00
Erick Pérez Castellanos 5051ba600f month-view: draw a background on the overflow indicator
This code suffer from a similar bug to ::queue_area on
::size_allocate. This need some revisiting to make it work properly.
2014-12-20 09:10:00 -05:00
Erick Pérez Castellanos 7a00364efb month-view: preserve hovered cell on popover show
The hovered cell is the indicator to draw the background and the
coloring of the overflow indicator. Preserve its value as long as the
overflow is shown.
2014-12-20 09:10:00 -05:00
Erick Pérez Castellanos d63d23bc16 month-view: add title to overflow popover 2014-12-20 09:10:00 -05:00
Erick Pérez Castellanos 96a939ab48 month-view: update note about Gtk+ clipping bug 2014-12-20 09:10:00 -05:00
Erick Pérez Castellanos bd62b96a75 month-view: FIXME removed, feature added 2014-12-20 09:10:00 -05:00
Erick Pérez Castellanos ca20726959 month-view: fix popover placement on RTL locales 2014-12-20 09:09:59 -05:00
Erick Pérez Castellanos 046dac4fe9 month-view: highlight overflow indicator on hover 2014-12-20 09:09:59 -05:00
Erick Pérez Castellanos 07b4ee4862 month-view: initial impl of overflow popover 2014-12-20 09:09:59 -05:00
Erick Pérez Castellanos e5f507b95a month-view: track events on overflow indicator area
We keep to state variables to handle hovering and clicking on the
indicator.
Note: This commit does not build because requires of upcoming work
2014-12-20 09:09:59 -05:00
Erick Pérez Castellanos 9bfa048101 month-view: add proper count of overflowed events
Keep a list of the hidden events per cell in order to add them later to
the popover
2014-12-20 09:09:59 -05:00
Erick Pérez Castellanos 06e43d836f month-view: amend fix ::forall impl 2014-12-19 10:40:39 -05:00
Erick Pérez Castellanos 2c639d2d00 month-view: queue draw on size_allocate
It should not be necessary to queue a draw operation after
::size_allocate. This has been discussed over with Gtk+ devs, as soon as
the bug is fixed these statements will goes away.
2014-12-18 22:21:18 -05:00
Erick Pérez Castellanos 780bebf871 month-view: optimize text direction query
By keeping the value of the direction factor k around we save code and
function calling every time we need to use it.
2014-12-18 19:58:13 -05:00
Erick Pérez Castellanos 232b93095d month-view: fix ::forall and ::remove impl
Take care of removing parts-widgets first whenever a master widgets is removed
2014-12-18 19:25:23 -05:00
Erick Pérez Castellanos 5b4e7d470d month-view: implement GcalView::get_by_uuid 2014-12-18 15:43:13 -05:00
Erick Pérez Castellanos 170501bbdd month-view: add helper method 2014-12-18 14:50:29 -05:00
Erick Pérez Castellanos ceabae5e2c month-view: rework handling of widget's hiding
Previously, we were hoping keeping a list of the widgets hidden by the
application, but the implementation did not work.
Now we keep a hash of those widgets hidden because of the overflow, when
a widget is not visible, and it's not in GcalMonthView::hidden_as_overflow
hash, then was hidden by the application.
2014-12-18 14:44:05 -05:00
Erick Pérez Castellanos 1f9b380238 month-view: overflow indicator drawn centered 2014-12-18 01:54:24 -05:00
Erick Pérez Castellanos fbeb6d35b2 month-view: initial implementation of size alloc
This implements breaking of events, and showing of its parts. It also
provides the information need for the drawing of the overflow indicator.
This implementation brings support to RTL locales as well as LTR.

There's some things still missing here:
1. Mark the widgets with CSS classes for styling its broken status
2. Draw properly the overflow indicator
2014-12-18 01:23:46 -05:00