Federated_Computer/federated-calendar
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
5,525 Commits 3 Branches 0 Tags
4fb5c1ebb35675cb4fbe6d9fa9ede30d23ba4383
Commit Graph
10 Commits
Author SHA1 Message Date
Jean-François Fortin Tam ab76cd59be Create only DISPLAY alarms in reminders, not AUDIO 
Creating "AUDIO" VALARM notification actions causes endless problems:
users may only hear a sound notification (with no visuals), if at all,
and most other apps don't honor nor support editing audio-only alarms.
Other systems typically play a sound automatically on "DISPLAY" alarms.

https://datatracker.ietf.org/doc/html/rfc5545#section-3.6.6 says:

> Multiple mutually independent "VALARM" calendar components
> can be specified for a single "VEVENT" or "VTODO" calendar component.

However, each component states:

> 'action' and 'trigger' are both REQUIRED,
> but MUST NOT occur more than once.

To keep the UI simple, we should pick one or the other; "DISPLAY" it is.
Remove "AUDIO" alarm code and add a warning to never add it again.

Fixes: https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/1280
Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/680>
 2026-01-16 01:18:28 +00:00
Dimitrios Christidis 5dbf0c24bd event-editor: Introduce reminder at event start time 2024-07-09 19:54:03 +00:00
Abdullahi Usman d8e2fd6d81 reminders-section: make alarm sound changes persistent 
When the alarm sound changes, the change is not updated because
gcal-manager does not see the changes.

We now update the components and make more comparisons so that
it can be seen by gcal-manager
 2024-07-09 19:47:13 +00:00
Abdullahi Usman 420a126ddb reminders-section: fix reminder alarm toggle button states 
Alarm toggle state are in three stages because we do not update both
icon and active when pressed.

we now update the icons to match their states.
 2024-07-09 19:47:13 +00:00
Alice Mikhaylenko a74e7179c1 reminders-section: Port Add Reminder row to AdwButtonRow 2024-05-01 13:47:16 +00:00
Georges Basile Stavracas Neto 82d8ec31ca event-editor/sections: Add vfunc to check for changes 
This will be useful for next commits where we will need to check
if the schedule section actually changed something.
 2022-10-17 23:37:13 -03:00
Abdullahi Usman 659fdca460 event-detail: Grey out already added reminder in drop-down list 2022-05-25 13:35:08 +00:00
Georges Basile Stavracas Neto c0365a1681 event-editor/reminders: Port to GTK4 2022-02-11 09:18:38 -03:00
Dan Levin 8b251d5a98 reminders-section: Introduce 15 minute reminder 
10 minute reminder is too little advanced notice. 30 minutes is too
much. Say hello to 15 minute reminder.
 2020-11-02 17:05:31 +01:00
Georges Basile Stavracas Neto 997f6bb671 event-editor-dialog: Move reminders to GcalRemindersSection 
Move all widgetry, logic, and setup to GcalReminderSection.
 2020-10-31 13:30:56 -03:00