Commit Graph
78 Commits
Author SHA1 Message Date
Georges Basile Stavracas Neto 070bc681fc edit-dialog: simplify code
We don't need to have 2 functions that do exactly
the same thing.
2016-02-14 12:17:37 -02:00
Georges Basile Stavracas Neto 34ff93ce3f time-selector: use GDateTime
Pretty much like the previous commit, but porting the
GcalTimeSelector class.
2016-02-14 12:17:37 -02:00
Georges Basile Stavracas Neto afe8def60c date-selector: use GDateTime internally
Using a GDateTime improves consistency with the
other components (ideally, we'll move completely
to GDateTime) and simplifies the code.

This commit adds a new property GcalDateSelector::date
and adapts the API to use GDateTime.
2016-02-14 12:17:37 -02:00
Georges Basile Stavracas Neto e31e6eeac0 edit-dialog: use GcalEvent internally
Instead of using the ESource + ECalComponent combination,
use the new GcalEvent class, which wraps up and simplifies
most of the code.

This commit adds a GcalEditDialog::event property, and
adapts the dialog (and everything dependant on it's code)
to use the GcalEvent class.
2016-02-14 12:17:37 -02:00
Georges Basile Stavracas Neto 0ec0ea8121 event-widget: use GcalEvent internally
This saves a lot of code, and is much saner to maintain.
2016-02-14 12:17:37 -02:00
Georges Basile Stavracas Neto 2280a74856 edit-dialog: notify property before manually check sensitivity
When we check start & end time selector's sensitivity before
notifying the property change, the check is overriden by the
binding.

Fix that by performing the checks after the notification of the
property change.
2016-01-04 02:18:19 -02:00
Georges Basile Stavracas Neto 13c4145507 edit-dialog: add ::writable and ::manager properties
By using these properties, we gain the possibility to
bind them to the widgets and save some needless code.

This commit adds GcalEditDialog::writable and ::manager
properties. Other needed properties will be eventually
added in the subsequent commits.
2015-12-30 17:34:29 -02:00
Georges Basile Stavracas Neto de207f9c63 edit-dialog: move bindings to UI file
We don't need to manually bind these properties in
the source code if we can make it on the UI files.
2015-12-30 15:05:20 -02:00
Georges Basile Stavracas Neto 4d19950c2c edit-dialog: cosmetic changes
Fixes some alignment issues, as well as some
needless checks. Also, use some handy glib
functions to shrink the code even more.
2015-12-30 14:59:16 -02:00
Georges Basile Stavracas Neto 3396291e3e edit-dialog: remove needless casts
These widgets are already stored as GtkWidgets,
and there is no need to do these casts.
2015-12-30 14:40:34 -02:00
Georges Basile Stavracas Neto 6f1eb7ca9d edit-dialog: turn into a final class
This commit updates GcalEditDialog's code for
it to be a final class. As such, we don't need
the GcalEditDialogPrivate type - we can simply
move our data to the GcalEditDialog struct.
2015-12-30 14:36:27 -02:00
Georges Basile Stavracas Neto 0ac827d87d edit-dialog: remove dead code
This is already set in the UI definition file
for the dialog.
2015-12-30 14:12:02 -02:00
Erick Perez Castellanos 5f6bd95750 Fix gcal_manager_is_client_writable() semantics
Fix all the calls to it accordingly.
2015-10-07 08:39:51 -05:00
Erick Pérez Castellanos e5c7dee5d8 misc: code style fixing 2015-03-16 13:07:54 -04:00
Erick Pérez Castellanos cac370e6b7 edit-dialog: handle timezone properly 2015-03-16 13:07:34 -04:00
Erick Pérez Castellanos c7563da2d0 app: handle calendars colours better
Bug: https://bugzilla.gnome.org/show_bug.cgi?id=745487
2015-03-06 11:32:32 -05:00
Erick Pérez Castellanos 9f20c3f2f9 edit-dialog: fix ref leak when selecting a calendar 2015-03-06 10:35:25 -05:00
Erick Pérez Castellanos 264492580e edit-dialog: convert time to timezone 2015-02-16 09:31:21 -05:00
Erick Pérez Castellanos b1df382ee3 app: use get_color_name_from_source() 2015-02-06 09:21:36 -05:00
Rishabh Raj 57ebe7aed9 time-selector: fix handler unblocked 2015-01-27 10:33:39 -05:00
Erick Pérez Castellanos 0b2367200b copyright: update year 2015-01-20 13:11:58 -05:00
Georges Basile Stavracas Neto 5423280398 edit-dialog: use UI file to connect signals
Fixes bug #739313.
2015-01-13 17:02:07 -02:00
Georges Basile Stavracas Neto c799acf482 edit-dialog: calculate all_day before using it to set the dates
It was using the all_day var before actually using it.

This caused an issue where the start time showed as the current time.
2015-01-13 16:18:40 -02:00
Georges Basile Stavracas Neto b1daf9eeb4 edit-dialog: remove unused field
The old times when calendar used GtkTreeIter has passed, and it no longer needs the active iter field.
2015-01-13 13:29:17 -02:00
Georges Basile Stavracas Neto 6de2bdd292 edit-dialog: fix missing icons from source selection menu 2015-01-13 13:23:42 -02:00
Georges Basile Stavracas Neto c10ba6b228 time-selector: don't access dconf multiple times for the same key
Instead of accessing 3 times the same key, use the cached version and save up some time.
2015-01-03 15:31:05 -02:00
Erick Pérez Castellanos b66d4eb21c misc: fix memory leak 2014-12-26 12:01:53 -05:00
Erick Pérez Castellanos 375425573d edit-dialog: fix memory leak
Also, evolution set altrep to NULL usually, we better do the same.
2014-12-24 11:09:45 -05:00
Georges Basile Stavracas Neto 07e052ef9c edit-dialog: requires date format for construct
Neccessary to pass it to GcalDateSelector & GcalTimeSelector without having to search the value again.
2014-12-23 12:01:41 -05:00
Georges Basile Stavracas Neto 63e473476b edit-dialog: fixed wrong setting of date selector sensitivity 2014-12-23 12:01:38 -05:00
Georges Basile Stavracas Neto 40683e5e10 date-selector: initial implementetation
No functionality is ready, only project settings and class type.
2014-12-23 12:01:38 -05:00
Erick Pérez Castellanos 4eabc0223b build: remove unneeded code
GObject type system zeroing instance private data, so initialization to
NULL and FALSE is not needed.
Misc code styles fixes.
2014-12-22 21:52:35 -05:00
Erick Pérez Castellanos f0d35f60fb Revert "edit-dialog: update sources when their readonly state changes"
This reverts commit 31fa4e8e06.
2014-12-22 08:38:20 -05:00
Erick Pérez Castellanos 0749520a35 edit-dialog: don't open with summary entry empty 2014-12-22 08:38:18 -05:00
Georges Basile Stavracas Neto fa7bc69192 edit-dialog: properly set time selector's sensivity
Instead of simply not settings them at all, it is now set according to the writable and all day values.
2014-12-18 09:55:11 -05:00
Georges Basile Stavracas Neto 448594325e edit-dialog: remove useless code
I'm not really sure of this one, but it seems very correct. At least, things work now.
2014-12-18 09:55:11 -05:00
Georges Basile Stavracas Neto 33d101062d time-selector: implemented time selection with spin buttons 2014-12-18 09:55:09 -05:00
Georges Basile Stavracas Neto 75143200cb manager: change signal name to ::'source-activated' 2014-12-16 13:01:29 -02:00
Georges Basile Stavracas Neto 31fa4e8e06 edit-dialog: update sources when their readonly state changes
This fixes the annoying all-insensitive-menu bug.
2014-12-16 11:19:56 -02:00
Erick Pérez Castellanos 738bb89d94 edit-dialog: fix memory leaks 2014-12-08 12:33:41 -05:00
Georges Basile Stavracas Neto f8c269ac74 edit-dialog: fixed wrong menu fill
Menu is created each time the dialog is shown, now. This avoids the syncronization between sources loading time.

Also, icon color is now 16px.
2014-12-08 15:34:04 -02:00
Erick Pérez Castellanos e62f48bfea events: fix handling of event with no end date
Fix the sigsegv in edit-dialog and event-widgets when there's no
end-date set.
Set a guard in Utils::gcal_dup_icaltime function.
There's still some problems with the events showing the first time but
not anymore.

Bug: https://bugzilla.gnome.org/show_bug.cgi?id=736002
2014-12-08 11:21:14 -05:00
Georges Basile Stavracas Neto 20575b928f edit-dialog: update source color on selection 2014-12-05 17:22:03 -02:00
Georges Basile Stavracas Neto dd17c45167 edit-dialog: enable selecting source at event creation
When creating a new event, the user should be able to select in which source it'll be created in. This commit implements that.

Moving an event to another source, however, is not allowed at the moment.
2014-12-05 16:27:01 -02:00
Georges Basile Stavracas Neto 8f4d6be1bf edit-dialog: hide Delete button when creating a new event
Because we don't want to delete an event that is not created
2014-12-05 00:41:34 -02:00
Erick Pérez Castellanos 1916986f15 app: active More details button from new event popover
GcalWindow got connected to GcalManager, and pass just created component
to GcalEditDialog
GcalEditDialog gained support to handle component not committed to
manager singleton instance yet.
2014-12-04 17:10:56 -05:00
Erick Pérez Castellanos dc941b6a9d edit-dialog: use reccurrence_id of events
When generating the uuid of an event if the event is recurrent, you need
to take into account its rid.
2014-12-04 17:10:55 -05:00
Georges Basile Stavracas Neto cba6da043d edit-dialog: removed unused code
Also, updates the edit dialog to the newer backend design, removing all traces of the old cached data type.

This patch is mostly functional, but it introduces some crashes after the component is updated.
2014-12-04 17:10:51 -05:00
Georges Basile Stavracas Neto 8e878f0a06 edit-dialog: show Save label for editable events
Fixes bug #739309.
2014-12-04 17:10:49 -05:00
Georges Basile Stavracas Neto 56e69f7c88 edit-dialog: implements GCAL_RESPONSE_SAVE_EVENT
This patch mainly implements GCAL_RESPONSE_SAVE_EVENT. It updates the event correctly, no matter in which source it is.

Signed-off-by: Georges Basile Stavracas Neto <georges.stavracas@gmail.com>
2014-12-04 17:10:49 -05:00