Commit Graph
158 Commits
Author SHA1 Message Date
Georges Basile Stavracas Neto 50ce09617e source-dialog: remove private field 2016-01-19 20:03:19 -02:00
Erick Perez Castellanos 5f6bd95750 Fix gcal_manager_is_client_writable() semantics
Fix all the calls to it accordingly.
2015-10-07 08:39:51 -05:00
Milan Crha afdd726daf manager: fix bug #751209
https://bugzilla.gnome.org/show_bug.cgi?id=751209
2015-06-20 22:56:47 -03:00
Erick Pérez Castellanos d5cc7efcd0 build: fix merge leftovers 2015-05-25 12:43:49 -04:00
Georges Basile Stavracas Neto 0c47cda20c source-dialog: change visible page by pointers
Using their string representations was slow, compare
pointers which is fast.
2015-05-25 12:36:55 -04:00
Georges Basile Stavracas Neto b8fea7f1d1 source-dialog: fix memory leak
Free duplicated string when the listbox row is
destroyed.
2015-05-25 12:36:55 -04:00
Georges Basile Stavracas Neto 87c02b520a source-dialog: hide itself on response event 2015-05-25 12:36:55 -04:00
Erick Pérez Castellanos bb67518418 source-dialog: squash compilation warning 2015-05-25 12:36:55 -04:00
Georges Basile Stavracas Neto ef9d1301d9 source-dialog: use a builder .ui definition for interface
We know that coding interfaces sucks, so use a .ui file instead.
2015-05-25 12:36:54 -04:00
Erick Pérez Castellanos fdba286915 source-dialog: g_object_ref() returns the object 2015-05-25 12:36:54 -04:00
Erick Pérez Castellanos 53e3c04bb2 source-dialog: make NULL comparison explicit 2015-05-25 12:36:54 -04:00
Erick Pérez Castellanos 2677ec560a source-dialog: avoid unneeded comparisons
Sources are unique, so the comparison can be avoided once the source is
found
2015-05-25 12:36:54 -04:00
Erick Pérez Castellanos 1431f4b895 style: align arguments properly 2015-05-25 12:36:54 -04:00
Erick Pérez Castellanos 46a92fd96b source-dialog: join two conditionals
Below the main conditionals were another if with no else block.
Those can be joined using && operator.
Some minor style fixes in here also.
2015-05-25 12:36:54 -04:00
Erick Pérez Castellanos d1f437f4d9 style: use the entire line 2015-05-25 12:36:54 -04:00
Erick Pérez Castellanos d4f6963328 style: remove unneeded curly brackets 2015-05-25 12:36:54 -04:00
Erick Pérez Castellanos 899928e795 style: remove whitespace 2015-05-25 12:36:53 -04:00
Erick Pérez Castellanos 798b63903d source-dialog: sources are unique
Destroy the row and break the loop as soon as the source is found
2015-05-25 12:36:53 -04:00
Erick Pérez Castellanos cfa81e86a5 style: group variables declarations 2015-05-25 12:36:53 -04:00
Erick Pérez Castellanos cff0b59b2e style: ensure separation of code and declarations 2015-05-25 12:36:53 -04:00
Georges Basile Stavracas Neto bbcd5bcc49 source-dialog: use GtkEntry::get_text_length 2015-05-25 12:35:58 -04:00
Georges Basile Stavracas Neto e3e30140b3 source-dialog: use g_clear_object instead of manual free 2015-05-25 12:35:58 -04:00
Georges Basile Stavracas Neto 6213f5cc78 source-dialog: remove useless checks before freeing memory
g_free is NULL-proof, no need to check if it's NULL
before using it.
2015-05-25 12:35:58 -04:00
Georges Basile Stavracas Neto f9b3f2f6c7 source-dialog: remove unused enum 2015-05-25 12:35:58 -04:00
Georges Basile Stavracas Neto 27fa9983f4 manager: change ::get_client to ::get_goa_client
This explains better the purpose of the methods, and also
don't collide with the ECalClient prefix we already use.
2015-05-25 12:35:58 -04:00
Georges Basile Stavracas Neto 2b4e46a4b6 manager: notify when sources are enabled/disabled
Add the new signal for GcalManager::source-enabled that
notifies connected widgets about the source change. With
that, we can keep checkboxes syncronizes.
2015-05-25 12:35:58 -04:00
Georges Basile Stavracas Neto 023a79a90f source-dialog: bind source::display-name with label::label 2015-05-25 12:35:58 -04:00
Georges Basile Stavracas Neto 51a2695546 source-dialog: open online account settings when button is clicked 2015-05-25 12:35:57 -04:00
Georges Basile Stavracas Neto 60401426a2 source-dialog: silence gnome-control-center 2015-05-25 12:35:57 -04:00
Georges Basile Stavracas Neto 7482469b01 source-dialog: sort online accounts 2015-05-25 12:35:57 -04:00
Georges Basile Stavracas Neto 06e6f39721 source-dialog: remove accounts with GoaClient::account-removed 2015-05-25 12:35:57 -04:00
Georges Basile Stavracas Neto 1a580e3be5 source-dialog: hide empty goa rows instead of removing them 2015-05-25 12:35:57 -04:00
Georges Basile Stavracas Neto a8631eb99a source-dialog: initialize the icon name
Avoids some compiler warnings.
2015-05-25 12:35:57 -04:00
Georges Basile Stavracas Neto 2f882d2b0b source-dialog: add accounts when they're added 2015-05-25 12:35:57 -04:00
Georges Basile Stavracas Neto 10e032f510 source-dialog: open online account when row is activated 2015-05-25 12:35:57 -04:00
Georges Basile Stavracas Neto 06cfeace4d source-dialog: load online accounts 2015-05-25 12:35:57 -04:00
Georges Basile Stavracas Neto 7942677b8e application: move GoaClient to manager 2015-05-25 12:35:56 -04:00
Georges Basile Stavracas Neto ee7025ea99 source-dialog: add ::application property 2015-05-25 12:35:56 -04:00
Georges Basile Stavracas Neto a61a970049 source-dialog: spawn online accounts creation on row activation 2015-05-25 12:35:56 -04:00
Georges Basile Stavracas Neto 5d6fe1b7f4 source-dialog: revalidates on entry activation 2015-05-25 12:35:56 -04:00
Georges Basile Stavracas Neto b45e76b9af source-dialog: properly hide the list of discovered sources 2015-05-25 12:35:55 -04:00
Georges Basile Stavracas Neto bbca705f55 source-dialog: show an icon on success for web sources 2015-05-25 12:35:55 -04:00
Georges Basile Stavracas Neto 24189bddd3 source-dialog: fix sorting function 2015-05-25 12:35:55 -04:00
Georges Basile Stavracas Neto e62d744cef source-dialog: Add a "Calendars" label before calendar listbox
Also, this commit correctly hides the calendar
label and list.
2015-05-25 12:35:55 -04:00
Georges Basile Stavracas Neto dcd1fbe6d9 source-dialog: fix insensitive button when addin file or local source 2015-05-25 12:35:55 -04:00
Georges Basile Stavracas Neto d892f981cb source-dialog: first action goes top, second goes down 2015-05-25 12:35:55 -04:00
Georges Basile Stavracas Neto d5b04e24ac source-dialog: always focus user entry when asking credentials 2015-05-25 12:35:55 -04:00
Georges Basile Stavracas Neto 85fd55ce96 source-dialog: make it able to select the desired calendars 2015-05-25 12:35:54 -04:00
Georges Basile Stavracas Neto 76432b81e0 source-dialog: fix credentials leaked data 2015-05-25 12:35:54 -04:00
Georges Basile Stavracas Neto 102698a9e3 source-dialog: remove unneeded fields 2015-05-25 12:35:54 -04:00