Georges Basile Stavracas Neto
1234dd8292
manager: small cleanup
...
Use g_clear_pointer()
2018-02-23 15:48:15 -03:00
Elias Entrup
5f4c5f5cbe
event-widget: Handle NULL in event sorting
...
The application crashes when e_cal_component_get_last_modified
returns NULL which is used for sorting events.
2018-02-11 23:30:34 +00:00
Iñigo Martínez
11fb4717a2
tests: Fix GCalManager test
...
The unit test that checks GCalManager test fails due to missing
schemas.
This patch allows schemas to be compiled in the build tree and also
sets the environment variables so tests can found them and run
properly.
Additional code and testing from Mohammed Sadiq <sadiq@sadiqpk.org >
2018-02-11 23:17:12 +00:00
Piotr Drąg
d9e306bb86
main: Mark g_set_application_name for translation
...
According to [1], it should be marked for translation.
[1] https://developer.gnome.org/glib/stable/glib-Miscellaneous-Utility-Functions.html#g-set-application-name
2018-02-05 17:19:41 +01:00
Georges Basile Stavracas Neto
c60a881ca3
event: Use G_DEFINE_QUARK
2018-01-30 02:07:47 -02:00
Georges Basile Stavracas Neto
503191377f
application: More code style cleanup and reorganization
2018-01-30 01:30:59 -02:00
Georges Basile Stavracas Neto
ab259fe57b
date-selector: Use parameter specs to declare properties
2018-01-30 01:10:43 -02:00
Georges Basile Stavracas Neto
f83826515e
edit-dialog: Use parameter specs to define properties
2018-01-30 01:10:25 -02:00
Georges Basile Stavracas Neto
f3b4f68bf0
event: Use parameter specs to declare properties
2018-01-30 01:10:08 -02:00
Georges Basile Stavracas Neto
8892c31379
week-view: Remove embarrassing debug message
2018-01-28 12:50:04 -02:00
Georges Basile Stavracas Neto
09b986f526
quick-add-popover: Only remove existing rows
...
We can receive the source-changed signal on read-only sources,
and these sources have no row associated. Trying to remove the
non-existing row would yield a warning.
2018-01-28 12:45:57 -02:00
Georges Basile Stavracas Neto
f698981aa8
application: Improve order of statup
...
This commit makes sure that logging is set before
actually logging anything. It also sychronizes the
application startup with the manager startup.
2018-01-28 12:39:13 -02:00
Georges Basile Stavracas Neto
194407ecfb
views: Instrument and fix reference leaks
2018-01-28 12:08:04 -02:00
Georges Basile Stavracas Neto
58b3340736
window: Remove dead code
...
An unused variable and a binding to a non existing property
2018-01-28 11:17:50 -02:00
Georges Basile Stavracas Neto
7364d8bf29
manager: Handle refresh in the source directly
...
Instead of implementing code to refresh sources, let's just
use the ESourceRefresh extension and let Evolution handle that.
2018-01-28 10:43:48 -02:00
Georges Basile Stavracas Neto
037567209c
view: Remove first weekday helpers when unecessary
...
Not all views need to know the first weekday, and those
who need, it can be stored internally.
2018-01-28 10:20:19 -02:00
Georges Basile Stavracas Neto
30ba757c40
utils: Cleanup first weekday function
2018-01-28 09:59:08 -02:00
Georges Basile Stavracas Neto
3873b3b5bb
shell-search-provider: Remove dead fixme
2018-01-28 09:56:17 -02:00
Georges Basile Stavracas Neto
b936759e5c
project: Make time format a first-class citizen
...
The current code deals with 12/24h clock formats almost like
a workaround of the issue. This commit adds proper support to
different clock formats.
2018-01-28 02:30:55 -02:00
Georges Basile Stavracas Neto
79987734cd
enums: Generate enums with standard GLib syntax
2018-01-28 02:30:07 -02:00
Georges Basile Stavracas Neto
c7f6fd19c4
project: Move enums to gcal-enums.h
2018-01-28 00:44:36 -02:00
Georges Basile Stavracas Neto
71e9c3e0c7
shell-search-provider: Instrument and modernize code
2018-01-28 00:27:56 -02:00
Georges Basile Stavracas Neto
0bfc6fe291
shell-search-provider: Rework property initialization
2018-01-28 00:13:15 -02:00
Georges Basile Stavracas Neto
9424d8f3cc
weather-settings: Only deserialize valid locations
2018-01-27 23:32:21 -02:00
Georges Basile Stavracas Neto
fe53414b07
weather-settings: Instrument more loading functions
2018-01-27 23:27:25 -02:00
Georges Basile Stavracas Neto
a7aa997ac3
weather-service: Remove more dead code
2018-01-27 23:27:03 -02:00
Georges Basile Stavracas Neto
c4ca9cac3c
project: Rename GcalSearchView to GcalSearchPopover
...
This was never a view, but a popover.
2018-01-27 23:02:36 -02:00
Georges Basile Stavracas Neto
1dcf0d1f24
project: Unify headers
2018-01-27 22:35:20 -02:00
Georges Basile Stavracas Neto
ac4f8feb15
weather-service: More small refactorings
...
Now it appears to be fully funcitonal again!
2018-01-27 22:26:30 -02:00
Georges Basile Stavracas Neto
718266f349
window: Bind manager to GcalWeatherSettings
...
A missing entry point from the previous refactorings
2018-01-27 22:25:57 -02:00
Georges Basile Stavracas Neto
50ec8fd30b
window: Notify properties by pspec
...
It avoids lookups on the class properties.
2018-01-27 22:25:32 -02:00
Georges Basile Stavracas Neto
6dc3d9ee39
weather-settings: Improve start/stop logic
2018-01-27 21:56:58 -02:00
Georges Basile Stavracas Neto
5dddff9939
weather-service: Fix debug location
...
This is tricking us into thinking the code is being
executed when in fact it's falling into the early return.
2018-01-27 21:56:14 -02:00
Georges Basile Stavracas Neto
5a651b01f8
window: Rework property initialization
...
There is a clear chain of properties that must be respected
in order to make Calendar initialize properly:
1. GcalManager, since it provider access to the settings
2. The initial date
3. GcalWeatherService, that depends on settings and the initial date
2018-01-27 21:46:15 -02:00
Georges Basile Stavracas Neto
5a0844c127
application: Remove conditional include
...
We always generate the config file nowadays.
2018-01-27 21:26:33 -02:00
Georges Basile Stavracas Neto
737181c655
application: Use g_auto* to simplify code
2018-01-27 21:11:08 -02:00
Georges Basile Stavracas Neto
499db7bfd4
weather: Rework weather management
...
This commit brings a few changes that I was too lazy to
split in different commits:
* Remove a few useless arguments in the GcalWeatherService API
* Move the weather management code from GcalWindow to GcalWeatherSettings
* A few style changes
2018-01-27 20:36:29 -02:00
Georges Basile Stavracas Neto
ab20672aeb
weather: Move to a subdirectory
2018-01-27 15:24:32 -02:00
Georges Basile Stavracas Neto
a8d6bfea0b
month-popover: Properly mark static function as static
2018-01-27 14:30:31 -02:00
Georges Basile Stavracas Neto
702c089c17
weather-service: Simplify code
2018-01-27 14:30:02 -02:00
Georges Basile Stavracas Neto
5a6fabddc8
window: Rework property creation
2018-01-27 14:28:55 -02:00
Georges Basile Stavracas Neto
f0a2a43438
Merge branch 'master' into 'master'
...
week-view: display "12 PM" correctly
See merge request GNOME/gnome-calendar!22
2018-01-10 16:08:08 +00:00
Adam Dingle
67efbd0f6c
week-view: display "12 PM" correctly
...
https://gitlab.gnome.org/GNOME/gnome-calendar/issues/235
2018-01-10 10:10:46 +01:00
Akbar Hashmi
4048296314
application: Add --quit commandline argument
...
Overview: Clicking the close button in gnome-calendar doesn't always close all the instances of the application. The window is closed, but an instance of gnome-calendar is still running as a gapplication-service, which was probably run by gnome-shell search provider.
The two changes made were as follows:
1) added the argument quit to GOptionEntry
2) added the definition of quit to gcal_application_command_line
2017-12-19 07:41:40 +05:30
Georges Basile Stavracas Neto
b8f51e1d3d
window: a load more weather changes
2017-12-17 11:35:19 -02:00
Georges Basile Stavracas Neto
61b9ba85a2
month-view: cleanup includes
2017-12-16 23:52:06 -02:00
Georges Basile Stavracas Neto
9f1885d807
weather-service: use GPtrArray for public API
...
Using GLists and GSLists is a bad practice. These data
structures are too much inneficient and GPtrArray has
the advantage of having a free function pointer, so we
can hide the underlying free function from the consumers
of this API.
This also gets rid of another allocation cycle in Month
view.
2017-12-16 23:12:06 -02:00
Georges Basile Stavracas Neto
dcf4ff0bda
views: more weather service cleanups
...
Did I ever say how happy I'll be when people start
actually following my code style when densing code
to my projects?
2017-12-16 22:36:39 -02:00
Georges Basile Stavracas Neto
d283316382
views: simplify reference leak workaround
...
Oh so many unecessary casts =(
2017-12-16 21:49:22 -02:00
Georges Basile Stavracas Neto
5c1bf907fa
views: move :event-activated signal to GcalView
...
We don't really need to copy this signal to every GcalView
implementation. It's just wasting code.
2017-12-16 21:44:09 -02:00