From f19bf803bacfa722af8c570169a59d408bcbfb66 Mon Sep 17 00:00:00 2001 From: Georges Basile Stavracas Neto Date: Fri, 23 Feb 2018 16:11:36 -0300 Subject: [PATCH] docs: update CONTRIBUTING.md --- CONTRIBUTING.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index e295f5c8..873f6d5a 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -7,7 +7,8 @@ Please note we have a code of conduct, please follow it in all your interactions ## Pull Request Process -1. Ensure your code compiles. Run `make` before creating the pull request. +1. Ensure your code compiles and doesn't break anything. Run `meson test -C ` before creating + the pull request. 2. If you're adding new API, it must be properly documented. 3. The commit message is formatted as follows: ``` @@ -17,7 +18,7 @@ Please note we have a code of conduct, please follow it in all your interactions ‌ Another one explaining how you solved that. ‌ - + ``` 4. You may merge the pull request in once you have the sign-off of the maintainers, or if you do not have permission to do that, you may request the second reviewer to merge it for you.