Federated_Computer/federated-calendar
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

gui/month-view-row: Add upward variable

Browse Source 
`!downward` is disambiguous and could merely be interpreted
as "not downward and not upward either". The `upward` variable
is explicit and describes literally the condition.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-calendar/-/merge_requests/729>
This commit is contained in:
Hari Rana
2026-03-21 10:39:16 -04:00
parent b75c44795e
commit d0bdc9f2af
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/gui/views/gcal-month-view-row.c
+5 -3
View File
@@ -264,12 +264,14 @@ find_nearest_vertical_event_widget (GcalMonthViewRow *self,
g_autoptr (FocusEventData) candidate = NULL; g_autoptr (FocusEventData) candidate = NULL;
g_autoptr (FocusEventData) nearest = NULL; g_autoptr (FocusEventData) nearest = NULL;
GtkWidget *child; GtkWidget *child;
gboolean downward, forward_or_backward; gboolean downward, upward, forward_or_backward;
gboolean is_rtl; gboolean is_rtl;
GCAL_ENTRY; GCAL_ENTRY;
downward = direction == GTK_DIR_DOWN || direction == GTK_DIR_TAB_FORWARD; downward = direction == GTK_DIR_DOWN || direction == GTK_DIR_TAB_FORWARD;
upward = !downward;
is_rtl = gtk_widget_get_direction (GTK_WIDGET (self)) == GTK_TEXT_DIR_RTL; is_rtl = gtk_widget_get_direction (GTK_WIDGET (self)) == GTK_TEXT_DIR_RTL;
forward_or_backward = direction == GTK_DIR_TAB_FORWARD || direction == GTK_DIR_TAB_BACKWARD; forward_or_backward = direction == GTK_DIR_TAB_FORWARD || direction == GTK_DIR_TAB_BACKWARD;
@@ -297,13 +299,13 @@ find_nearest_vertical_event_widget (GcalMonthViewRow *self,
continue; continue;
if ((downward && candidate->rect.origin.y < focused->rect.origin.y) || if ((downward && candidate->rect.origin.y < focused->rect.origin.y) ||
(!downward && candidate->rect.origin.y > focused->rect.origin.y)) (upward && candidate->rect.origin.y > focused->rect.origin.y))
continue; continue;
if (nearest == NULL) if (nearest == NULL)
swap_focus_event_data (&nearest, g_steal_pointer (&candidate)); swap_focus_event_data (&nearest, g_steal_pointer (&candidate));
else if ((downward && candidate->rect.origin.y < nearest->rect.origin.y) || else if ((downward && candidate->rect.origin.y < nearest->rect.origin.y) ||
(!downward && candidate->rect.origin.y > nearest->rect.origin.y)) (upward && candidate->rect.origin.y > nearest->rect.origin.y))
swap_focus_event_data (&nearest, g_steal_pointer (&candidate)); swap_focus_event_data (&nearest, g_steal_pointer (&candidate));
else if (downward && candidate->rect.origin.y == nearest->rect.origin.y && else if (downward && candidate->rect.origin.y == nearest->rect.origin.y &&
((is_rtl && candidate->focal_x > nearest->focal_x) || ((is_rtl && candidate->focal_x > nearest->focal_x) ||