Federated_Computer/federated-calendar
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

calendar-monitor: Improve lifecycle of updated events

Browse Source 
Keep a ref alive while updating the old event, as it may be
destroyed during signal emission.
This commit is contained in:
Georges Basile Stavracas Neto
2023-08-02 11:05:00 -03:00
parent 745e022aa0
commit 9c21dff77d
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/core/gcal-calendar-monitor.c
+3 -1
View File
@@ -1071,7 +1071,7 @@ update_events_in_idle_cb (gpointer user_data)
writer_locker = g_rw_lock_writer_locker_new (&self->shared.lock); writer_locker = g_rw_lock_writer_locker_new (&self->shared.lock);
for (guint i = 0; i < events->len; i++) for (guint i = 0; i < events->len; i++)
{ {
GcalEvent *old_event; g_autoptr (GcalEvent) old_event = NULL;
GcalEvent *event; GcalEvent *event;
const gchar *event_id; const gchar *event_id;
@@ -1081,6 +1081,8 @@ update_events_in_idle_cb (gpointer user_data)
old_event = g_hash_table_lookup (self->shared.events, event_id); old_event = g_hash_table_lookup (self->shared.events, event_id);
if (old_event) if (old_event)
{ {
g_object_ref (old_event);
g_hash_table_insert (self->shared.events, g_strdup (event_id), g_object_ref (event)); g_hash_table_insert (self->shared.events, g_strdup (event_id), g_object_ref (event));
g_signal_emit (self, signals[EVENT_UPDATED], 0, old_event, event); g_signal_emit (self, signals[EVENT_UPDATED], 0, old_event, event);
} }