Federated_Computer/federated-calendar
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

year-view: don't cancel selection while dragging

Browse Source 
This breaks the users' expectations that the navigator
will keep the selected dates. The old behavior was hazardous
for users with disabilities.

https://bugzilla.gnome.org/show_bug.cgi?id=762462
This commit is contained in:
Georges Basile Stavracas Neto
2016-05-20 22:18:34 -03:00
parent 6a8a4dfad0
commit 9c150de822
1 changed files with 6 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/gcal-year-view.c
+6 -12
View File
@@ -1076,14 +1076,14 @@ navigator_motion_notify_cb (GcalYearView *year_view,
gint day, month; gint day, month;
gboolean is_title = FALSE; gboolean is_title = FALSE;
/* Cancel the hover when selecting a date range */
year_view->selected_data->hovered_day = -1;
year_view->selected_data->hovered_month = -1;
if (calculate_day_month_for_coord (year_view, event->x, event->y, &day, &month, &is_title)) if (calculate_day_month_for_coord (year_view, event->x, event->y, &day, &month, &is_title))
{ {
if (year_view->button_pressed) if (year_view->button_pressed)
{ {
/* Cancel the hover when selecting a date range */
year_view->selected_data->hovered_day = -1;
year_view->selected_data->hovered_month = -1;
if (is_title) if (is_title)
day = g_date_get_days_in_month (month + 1, year_view->date->year); day = g_date_get_days_in_month (month + 1, year_view->date->year);
@@ -1103,16 +1103,10 @@ navigator_motion_notify_cb (GcalYearView *year_view,
return GDK_EVENT_PROPAGATE; return GDK_EVENT_PROPAGATE;
} }
} }
else
{
/* Reset the end day */
year_view->selected_data->end_day = year_view->selected_data->start_day;
year_view->selected_data->end_month = year_view->selected_data->start_month;
gtk_widget_queue_draw (widget); gtk_widget_queue_draw (widget);
return GDK_EVENT_STOP; return GDK_EVENT_STOP;
}
} }
static void static void