Federated_Computer/federated-calendar
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

weather-service: Fix buffer overflow in get_icon_name_sortkey()

Browse Source 
We can just use strlen() here.

Fixes #425
This commit is contained in:
Michael Catanzaro
2019-07-09 21:48:11 -03:00
committed by Georges Basile Stavracas Neto
parent 02a5eca945
commit 223ed62034
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/weather/gcal-weather-service.c
+2 -1
View File
@@ -309,7 +309,8 @@ get_icon_name_sortkey (const gchar *icon_name,
for (i = 0; i < G_N_ELEMENTS (icons); i++) for (i = 0; i < G_N_ELEMENTS (icons); i++)
{ {
if (icons[i].name[normalized_name_len] == '\0' && strncmp (icon_name, icons[i].name, normalized_name_len) == 0) if (normalized_name_len == strlen (icons[i].name) &&
strncmp (icon_name, icons[i].name, normalized_name_len) == 0)
{ {
*supports_night_icon = icons[i].night_support; *supports_night_icon = icons[i].night_support;
return i; return i;