Use more g_signal_connect_object()
Most of these are probably paranoid, not bugs. I haven't done an exhaustive review to see what really needs it: that would be time-consuming and require significant familiarity with the Calendar codebase. This was just a quick check. Anyway, I vote for paranoid when it comes to using g_signal_connect() regardless. It's dangerous, and there's no reason to ever leave a signal connected after the user data object has been destroyed. Fixes #423
This commit is contained in:
committed by
Georges Basile Stavracas Neto
parent
9644c30eee
commit
18ae67cb59
@@ -759,16 +759,18 @@ on_gclue_simple_creation_cb (GClueSimple *_source,
|
||||
{
|
||||
update_gclue_location (self, location);
|
||||
|
||||
g_signal_connect (location,
|
||||
"notify::location",
|
||||
G_CALLBACK (on_gclue_location_changed_cb),
|
||||
self);
|
||||
g_signal_connect_object (location,
|
||||
"notify::location",
|
||||
G_CALLBACK (on_gclue_location_changed_cb),
|
||||
self,
|
||||
0);
|
||||
}
|
||||
|
||||
g_signal_connect (client,
|
||||
"notify::active",
|
||||
G_CALLBACK (on_gclue_client_activity_changed_cb),
|
||||
self);
|
||||
g_signal_connect_object (client,
|
||||
"notify::active",
|
||||
G_CALLBACK (on_gclue_client_activity_changed_cb),
|
||||
self,
|
||||
0);
|
||||
|
||||
GCAL_EXIT;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user