Use more g_signal_connect_object()
Most of these are probably paranoid, not bugs. I haven't done an exhaustive review to see what really needs it: that would be time-consuming and require significant familiarity with the Calendar codebase. This was just a quick check. Anyway, I vote for paranoid when it comes to using g_signal_connect() regardless. It's dangerous, and there's no reason to ever leave a signal connected after the user data object has been destroyed. Fixes #423
This commit is contained in:
committed by
Georges Basile Stavracas Neto
parent
9644c30eee
commit
18ae67cb59
@@ -623,10 +623,11 @@ gcal_date_chooser_init (GcalDateChooser *self)
|
||||
{
|
||||
self->days[row][col] = gcal_date_chooser_day_new ();
|
||||
|
||||
g_signal_connect (self->days[row][col],
|
||||
"selected",
|
||||
G_CALLBACK (day_selected_cb),
|
||||
self);
|
||||
g_signal_connect_object (self->days[row][col],
|
||||
"selected",
|
||||
G_CALLBACK (day_selected_cb),
|
||||
self,
|
||||
0);
|
||||
|
||||
gtk_widget_show (self->days[row][col]);
|
||||
gtk_grid_attach (GTK_GRID (self->day_grid), self->days[row][col], col, row, 1, 1);
|
||||
|
||||
Reference in New Issue
Block a user