From 06b3c38db8cd7d4d87d9d857af19c4ee5dd05ec5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jean-Fran=C3=A7ois=20Fortin=20Tam?= Date: Sun, 10 Dec 2023 20:42:17 -0500 Subject: [PATCH] event-editor: Fix the "Save" / "Done" button label The "Done" button was apparently meant for read-only events, while the "Save" action was for everything else. It didn't work correctly because of a mismatch between code and UI XML. Fixes: https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/1142 --- src/gui/event-editor/gcal-event-editor-dialog.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/gui/event-editor/gcal-event-editor-dialog.c b/src/gui/event-editor/gcal-event-editor-dialog.c index c3b6b19f..56c96f4f 100644 --- a/src/gui/event-editor/gcal-event-editor-dialog.c +++ b/src/gui/event-editor/gcal-event-editor-dialog.c @@ -647,7 +647,7 @@ gcal_event_editor_dialog_class_init (GcalEventEditorDialogClass *klass) properties[PROP_WRITABLE] = g_param_spec_boolean ("writable", "Whether the current event can be edited", "Whether the current event can be edited or not", - TRUE, + FALSE, G_PARAM_READWRITE | G_PARAM_EXPLICIT_NOTIFY | G_PARAM_STATIC_STRINGS); g_object_class_install_properties (object_class, N_PROPS, properties); @@ -684,8 +684,6 @@ gcal_event_editor_dialog_init (GcalEventEditorDialog *self) }; gint i = 0; - self->writable = TRUE; - /* Actions */ self->action_group = g_simple_action_group_new (); g_action_map_add_action_entries (G_ACTION_MAP (self->action_group),