Federated_Computer/federated-calendar
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

utils/source-discoverer: Test URI before discovery

Browse Source 
This makes sure that we have a valid host set. This check is
copies from Soup's private SOUP_URI_IS_VALID() macro.

Add a test for this behavior.

Closes https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/794
This commit is contained in:
Georges Basile Stavracas Neto
2023-03-05 11:24:49 -03:00
parent 075b91d279
commit 0322bcf54c
2 changed files with 65 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/test-discoverer.c
+38
View File
@@ -82,6 +82,43 @@ discoverer_file (void)
/*********************************************************************************************************************/
static void
discoverer_invalid_https_only_cb (GObject *source_object,
GAsyncResult *result,
gpointer user_data)
{
g_autoptr (GPtrArray) sources = NULL;
g_autoptr (GError) error = NULL;
GMainLoop *mainloop = user_data;
sources = gcal_discover_sources_from_uri_finish (result, &error);
g_assert_error (error, G_URI_ERROR, G_URI_ERROR_FAILED);
g_assert_null (sources);
g_main_loop_quit (mainloop);
}
static void
discoverer_invalid_https_only (void)
{
g_autoptr (GMainLoop) mainloop = NULL;
g_test_bug ("794");
mainloop = g_main_loop_new (NULL, FALSE);
gcal_discover_sources_from_uri ("https://",
NULL,
NULL,
NULL,
discoverer_invalid_https_only_cb,
mainloop);
g_main_loop_run (mainloop);
}
/*********************************************************************************************************************/
#if 0
static void
@@ -184,6 +221,7 @@ main (gint argc,
g_test_bug_base ("https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/");
g_test_add_func ("/discoverer/file", discoverer_file);
g_test_add_func ("/discoverer/invalid-https-only", discoverer_invalid_https_only);
//g_test_add_func ("/discoverer/webdav/unauthorized", discoverer_webdav_unauthorized);
return g_test_run ();