Andrew S Erwin
4e421f6ea2
release gate / check (push) Failing after 6m43s
High severity: - wire TRUSTED_PROXY through Compose/deploy/docs and warn at web startup - bucket public rate limits on effective client IP, add per-bookmark budget, and forward the signed browser identity from the share page - disable first-run bootstrap in server deployments and document seeding - serialize last-admin demotion in one advisory-locked transaction Medium/low: - cap and batch share recipient inserts - add a shared outbound budget for preview/CardDAV/IMAP/signal work - pin CardDAV dials to 443 and bound IMAP logout - fix rightward kanban column drags and normalize cards on column delete - classify backend outages in auth guards, add request timeouts and an error boundary, remove the dead login route, surface throttling - enforce pinned/unpinned page reorder grouping server-side - avoid preview work for stale bookmark versions; drop duplicate dialog fetch - sequence-guard collection/tag/calendar/quick-find loads - validate property config and fix MULTI_SELECT/DATE filter inputs - document index maintenance; apply same-origin check to sign-out - trim signup names, unique shared dates and kanban keys (migration 010), reset reference cache on identity changes, hide OIDC issuer, return 413 for oversized direct bodies, escape Markdown link destinations - remove dead template files and duplicate test helper Verified with go build/vet, full PostgreSQL race suite, db convergence, tsc, both ESLint configs and a Next production build.
34 lines
1.4 KiB
TypeScript
34 lines
1.4 KiB
TypeScript
import { backendFetch } from '@/lib/api'
|
|
|
|
export const VIEW_AS_COOKIE = 'computer_view_as'
|
|
export type AuthUser = { id: string; name?: string | null; email?: string | null; image?: string | null; role: 'USER' | 'ADMIN'; actingAdminId?: string }
|
|
|
|
// Review M-6: Go distinguishes "no session" (401) from backend degradation
|
|
// (503). Collapsing both to null sent an authenticated admin to /login during
|
|
// a database outage, as if their credentials had failed. Only 401 means
|
|
// signed out; anything else is an outage the UI must show as such.
|
|
export class BackendUnavailableError extends Error {
|
|
status: number
|
|
constructor(status: number) {
|
|
super('Backend unavailable')
|
|
this.name = 'BackendUnavailableError'
|
|
this.status = status
|
|
}
|
|
}
|
|
|
|
async function account() {
|
|
let res: Response
|
|
try {
|
|
res = await backendFetch('/api/me')
|
|
} catch (error) {
|
|
const status = (error as { status?: unknown })?.status
|
|
throw new BackendUnavailableError(typeof status === 'number' ? status : 502)
|
|
}
|
|
if (res.status === 401) return null
|
|
if (!res.ok) throw new BackendUnavailableError(res.status)
|
|
return res.json()
|
|
}
|
|
|
|
export async function getRealUser(): Promise<AuthUser | null> { return (await account())?.user ?? null }
|
|
export async function getAuthUser(): Promise<AuthUser | null> { const me = await account(); return me ? { ...me.effectiveUser, ...(me.viewingAs ? { actingAdminId: me.user.id } : {}) } : null }
|