Add trust features: history, trash, export, and collection sharing

Implement Notion-like upgrade phase 4: append-only page revisions with restore-as-a-new-version; recoverable bookmark/page/collection deletions whose restores never resurrect public flags or shares; owner-scoped JSON export; and explicit, revocable read-only collection sharing with owner-only mutations and no transitive third-party bookmark leaks. Add migration 009, API/docs, integration coverage, and page/collections/trash UI.

internal/handlers/bookmarks.go

@@ -363,7 +363,15 @@ func HandleBookmarksUpdate(w http.ResponseWriter, r *http.Request) {
 	respond(w, 200, v, e)
 }
 func HandleBookmarksDelete(w http.ResponseWriter, r *http.Request) {
-	e := remove(r, "Bookmark", r.PathValue("id"), "ownerId")
+	// Recoverable delete (trust phase): snapshot intrinsic fields and
+	// owner-scoped links in the same transaction as the hard delete. Shares
+	// and the public flag are deliberately not restored.
+	e := db.Transaction(r.Context(), database(r), func(tx *sql.Tx) error {
+		if e := lockUser(r, tx); e != nil {
+			return e
+		}
+		return trashBookmark(r, tx, r.PathValue("id"))
+	})
 	respond(w, 200, OK{true}, e)
 }
 

internal/handlers/collections.go

@@ -63,6 +63,15 @@ var (
 func collectionOwned(r *http.Request, q db.Queryer, id string) (object, error) {
 	return db.One(r.Context(), q, `SELECT to_jsonb(c) FROM "Collection" c WHERE c.id=$1 AND c."ownerId"=$2`, id, user(r))
 }
+
+// collectionReadable admits the owner and explicit recipients of a
+// CollectionShare. Mutating surfaces keep using collectionOwned, so a shared
+// reader can never rename, delete, reorder, or edit collection content.
+func collectionReadable(r *http.Request, q db.Queryer, id string) (object, error) {
+	return db.One(r.Context(), q, `SELECT to_jsonb(c)||jsonb_build_object('shared',c."ownerId"<>$2)
+		FROM "Collection" c WHERE c.id=$1 AND (c."ownerId"=$2 OR EXISTS(
+			SELECT 1 FROM "CollectionShare" s WHERE s."collectionId"=c.id AND s."userId"=$2))`, id, user(r))
+}
 func collectionProperties(r *http.Request, q db.Queryer, collectionID string) ([]object, error) {
 	return db.Many(r.Context(), q, `SELECT to_jsonb(p) FROM "CollectionProperty" p WHERE p."collectionId"=$1 ORDER BY p.position,p.id`, collectionID)
 }
@@ -99,6 +108,19 @@ func collectionDetail(r *http.Request, q db.Queryer, col object) (object, error)
 		out[k] = v
 	}
 	out["properties"], out["views"], out["_count"] = props, views, counts
+	shared := str(col, "ownerId") != user(r)
+	out["shared"] = shared
+	if shared {
+		// Recipients see who shared it, but never the other recipients.
+		out["owner"], _ = db.One(r.Context(), q, `SELECT jsonb_build_object('id',u.id,'name',u.name,'email',u.email,'image',u.image) FROM "User" u WHERE u.id=$1`, str(col, "ownerId"))
+		out["sharedWith"] = []object{}
+	} else {
+		shares, e := db.Many(r.Context(), q, `SELECT jsonb_build_object('userId',s."userId",'email',u.email,'name',u.name,'createdAt',s."createdAt") FROM "CollectionShare" s JOIN "User" u ON u.id=s."userId" WHERE s."collectionId"=$1 ORDER BY s."createdAt"`, str(col, "id"))
+		if e != nil {
+			return nil, e
+		}
+		out["sharedWith"] = shares
+	}
 	return out, nil
 }
 
@@ -159,11 +181,18 @@ func HandleCollectionsList(w http.ResponseWriter, r *http.Request) {
 	// Item counts are authorized counts (N-10 edge case): a bookmark the
 	// caller can no longer see never inflates them. Collections are
 	// owner-scoped in phase 2, so $1 (owner) and $2 (BookmarkVisible) match.
-	v, e := db.Many(r.Context(), database(r), `SELECT to_jsonb(c)||jsonb_build_object('_count',jsonb_build_object(
+	// Owner collections and collections explicitly shared with this user.
+	// `shared` is disclosed by the UI; item counts are authorized counts and
+	// therefore only include bookmarks the caller may see.
+	v, e := db.Many(r.Context(), database(r), `SELECT to_jsonb(c)||jsonb_build_object(
+		'shared',c."ownerId"<>$1,
+		'owner',(SELECT jsonb_build_object('id',u.id,'name',u.name,'email',u.email,'image',u.image) FROM "User" u WHERE u.id=c."ownerId"),
+		'_count',jsonb_build_object(
 		'items',(SELECT count(*) FROM "CollectionItem" ci JOIN "Bookmark" b ON b.id=ci."bookmarkId" WHERE ci."collectionId"=c.id AND `+db.BookmarkVisible+`),
 		'properties',(SELECT count(*) FROM "CollectionProperty" p WHERE p."collectionId"=c.id),
 		'views',(SELECT count(*) FROM "CollectionView" v WHERE v."collectionId"=c.id)))
-		FROM "Collection" c WHERE c."ownerId"=$1 ORDER BY c."createdAt",c.id`, user(r), user(r))
+		FROM "Collection" c WHERE c."ownerId"=$1 OR EXISTS(SELECT 1 FROM "CollectionShare" s WHERE s."collectionId"=c.id AND s."userId"=$1)
+		ORDER BY (c."ownerId"<>$1),c."createdAt",c.id`, user(r), user(r))
 	respond(w, 200, v, e)
 }
 
@@ -204,7 +233,7 @@ func HandleCollectionsCreate(w http.ResponseWriter, r *http.Request) {
 }
 
 func HandleCollectionsGet(w http.ResponseWriter, r *http.Request) {
-	col, e := collectionOwned(r, database(r), r.PathValue("id"))
+	col, e := collectionReadable(r, database(r), r.PathValue("id"))
 	if e != nil {
 		respond(w, 0, nil, e)
 		return
@@ -252,8 +281,51 @@ func HandleCollectionsUpdate(w http.ResponseWriter, r *http.Request) {
 
 func HandleCollectionsDelete(w http.ResponseWriter, r *http.Request) {
 	// Memberships, properties and views cascade; bookmarks are never touched
-	// (N-01 acceptance criterion).
-	respond(w, 200, OK{true}, remove(r, "Collection", r.PathValue("id"), "ownerId"))
+	// (N-01 acceptance criterion). The collection structure is snapshotted for
+	// restore; shares are not, so a revoked grant never comes back.
+	e := db.Transaction(r.Context(), database(r), func(tx *sql.Tx) error {
+		if e := lockUser(r, tx); e != nil {
+			return e
+		}
+		return trashCollection(r, tx, r.PathValue("id"))
+	})
+	respond(w, 200, OK{true}, e)
+}
+
+// HandleCollectionShare grants read-only access to explicitly named users.
+// The share is disclosed in the collection UI and revocable; recipients get
+// the narrowed bookmark projection for member bookmarks and cannot mutate the
+// collection or its items. Sharing an already-shared user is idempotent.
+func HandleCollectionShare(w http.ResponseWriter, r *http.Request) {
+	id := r.PathValue("id")
+	if _, e := collectionOwned(r, database(r), id); e != nil {
+		respond(w, 0, nil, e)
+		return
+	}
+	b, ok := read(w, r)
+	if !ok {
+		return
+	}
+	list, e := ids(b, "userIds")
+	if e != nil {
+		respond(w, 0, nil, e)
+		return
+	}
+	// Sharing with yourself is meaningless; skip it rather than creating an
+	// ownership-adjacent row that would confuse the recipient list.
+	filtered := make([]string, 0, len(list))
+	for _, uid := range list {
+		if uid != user(r) {
+			filtered = append(filtered, uid)
+		}
+	}
+	e = db.Transaction(r.Context(), database(r), func(tx *sql.Tx) error {
+		if e := lockUser(r, tx); e != nil {
+			return e
+		}
+		return shareRows(r, tx, "CollectionShare", "collectionId", id, filtered)
+	})
+	respond(w, 200, OK{true}, e)
 }
 
 // --- properties -----------------------------------------------------------
@@ -1203,8 +1275,9 @@ func HandleCollectionItemsList(w http.ResponseWriter, r *http.Request) {
 		}
 		limit = n
 	}
-	// Ownership is the gate: a foreign collection is a 404, not an empty list.
-	if _, e := collectionOwned(r, database(r), cid); e != nil {
+	// Owner or explicit share is the read gate: a foreign collection is a
+	// 404, not an empty list. Mutations below still require ownership.
+	if _, e := collectionReadable(r, database(r), cid); e != nil {
 		respond(w, 0, nil, e)
 		return
 	}
@@ -1217,7 +1290,7 @@ func HandleCollectionItemsList(w http.ResponseWriter, r *http.Request) {
 	// $1 stays a permanently-nil placeholder (BookmarkVisible binds $2), the
 	// same port artifact the bookmarks list documents.
 	args := []any{nil, user(r), cid}
-	where := `c."ownerId"=$2 AND ci."collectionId"=$3 AND ` + db.BookmarkVisible + ` AND $1::text IS NULL`
+	where := `(c."ownerId"=$2 OR EXISTS(SELECT 1 FROM "CollectionShare" cs WHERE cs."collectionId"=c.id AND cs."userId"=$2)) AND ci."collectionId"=$3 AND ` + db.BookmarkVisible + ` AND $1::text IS NULL`
 	var sorts []any
 	if viewID := sp.Get("viewId"); viewID != "" {
 		view, e2 := db.One(r.Context(), database(r), `SELECT to_jsonb(v) FROM "CollectionView" v WHERE v.id=$1 AND v."collectionId"=$2`, viewID, cid)

internal/handlers/export.go

@@ -0,0 +1,83 @@
+package handlers
+
+import (
+	"net/http"
+	"time"
+
+	"github.com/andrew/go-computer/internal/db"
+)
+
+// Structured export (trust phase): a single owner-scoped JSON archive that is
+// richer than the per-item Markdown downloads. It deliberately excludes
+// credentials (IMAP config, CardDAV passwords) and includes only data the
+// caller owns or may read through the owner projection.
+func HandleExport(w http.ResponseWriter, r *http.Request) {
+	ctx := r.Context()
+	uid := user(r)
+	me, e := db.One(ctx, database(r), `SELECT jsonb_build_object('id',u.id,'name',u.name,'email',u.email,'role',u.role,'createdAt',u."createdAt") FROM "User" u WHERE u.id=$1`, uid)
+	if e != nil {
+		respond(w, 0, nil, e)
+		return
+	}
+	bookmarks, e := db.Many(ctx, database(r), `SELECT `+db.BookmarkOwnerView+` FROM "Bookmark" b WHERE b."ownerId"=$1 ORDER BY b."createdAt",b.id`, uid)
+	if e != nil {
+		respond(w, 0, nil, e)
+		return
+	}
+	tags, e := db.Many(ctx, database(r), `SELECT to_jsonb(t)||jsonb_build_object('sharedWith',COALESCE((SELECT jsonb_agg(jsonb_build_object('userId',s."userId",'email',u.email,'name',u.name)) FROM "TagShare" s JOIN "User" u ON u.id=s."userId" WHERE s."tagId"=t.id),'[]'::jsonb)) FROM "Tag" t WHERE t."ownerId"=$1 ORDER BY t."createdAt",t.id`, uid)
+	if e != nil {
+		respond(w, 0, nil, e)
+		return
+	}
+	pages, e := db.Many(ctx, database(r), `SELECT to_jsonb(p)||jsonb_build_object(
+		'bookmarks',COALESCE((SELECT jsonb_agg(to_jsonb(pb)||jsonb_build_object('bookmark',`+db.BookmarkOwnerView+`) ORDER BY pb.position) FROM "PageBookmark" pb JOIN "Bookmark" b ON b.id=pb."bookmarkId" WHERE pb."pageId"=p.id AND b."ownerId"=$1),'[]'::jsonb),
+		'revisions',COALESCE((SELECT jsonb_agg(to_jsonb(r) ORDER BY r.version) FROM "PageRevision" r WHERE r."pageId"=p.id),'[]'::jsonb))
+		FROM "Page" p WHERE p."ownerId"=$1 ORDER BY p."createdAt",p.id`, uid)
+	if e != nil {
+		respond(w, 0, nil, e)
+		return
+	}
+	contacts, e := db.Many(ctx, database(r), `SELECT to_jsonb(c) FROM "Contact" c WHERE c."userId"=$1 ORDER BY c."displayName",c.id`, uid)
+	if e != nil {
+		respond(w, 0, nil, e)
+		return
+	}
+	collections, e := db.Many(ctx, database(r), `SELECT to_jsonb(c) FROM "Collection" c WHERE c."ownerId"=$1 ORDER BY c."createdAt",c.id`, uid)
+	if e != nil {
+		respond(w, 0, nil, e)
+		return
+	}
+	exported := make([]object, 0, len(collections))
+	for _, col := range collections {
+		detail, e := collectionDetail(r, database(r), col)
+		if e != nil {
+			respond(w, 0, nil, e)
+			return
+		}
+		cid := str(col, "id")
+		items, e := db.Many(ctx, database(r), `SELECT to_jsonb(ci)||jsonb_build_object('bookmark',`+db.BookmarkOwnerView+`) FROM "CollectionItem" ci JOIN "Bookmark" b ON b.id=ci."bookmarkId" WHERE ci."collectionId"=$1 ORDER BY ci.position,ci.id`, cid)
+		if e != nil {
+			respond(w, 0, nil, e)
+			return
+		}
+		shares, e := db.Many(ctx, database(r), `SELECT jsonb_build_object('userId',s."userId",'email',u.email,'name',u.name,'createdAt',s."createdAt") FROM "CollectionShare" s JOIN "User" u ON u.id=s."userId" WHERE s."collectionId"=$1 ORDER BY s."createdAt"`, cid)
+		if e != nil {
+			respond(w, 0, nil, e)
+			return
+		}
+		detail["items"], detail["sharedWith"] = items, shares
+		exported = append(exported, detail)
+	}
+	w.Header().Set("Content-Disposition", `attachment; filename="computer-export.json"`)
+	respond(w, 200, object{
+		"format":      "computer-export",
+		"version":     1,
+		"exportedAt":  time.Now().UTC(),
+		"user":        me,
+		"bookmarks":   bookmarks,
+		"tags":        tags,
+		"pages":       pages,
+		"collections": exported,
+		"contacts":    contacts,
+	}, nil)
+}

internal/handlers/page_revisions.go

@@ -0,0 +1,95 @@
+package handlers
+
+import (
+	"database/sql"
+	"net/http"
+	"time"
+
+	"github.com/andrew/go-computer/internal/db"
+)
+
+// Page revision history (trust phase). Every committed content version gets
+// an immutable snapshot; restoring an old snapshot writes a new version rather
+// than rewriting history. Snapshots are owner-scoped through their page.
+func capturePageRevision(r *http.Request, tx *sql.Tx, pageID string) error {
+	_, e := tx.ExecContext(r.Context(), `INSERT INTO "PageRevision"(id,"pageId",version,title,content,icon)
+		SELECT $1,p.id,p.version,p.title,p.content,p.icon FROM "Page" p WHERE p.id=$2
+		ON CONFLICT ("pageId",version) DO NOTHING`, db.NewID(), pageID)
+	return e
+}
+
+func revisionOwned(r *http.Request, q db.Queryer, pageID, revisionID string) (object, error) {
+	if _, e := owned(r, q, "Page", pageID, "ownerId"); e != nil {
+		return nil, e
+	}
+	return db.One(r.Context(), q, `SELECT to_jsonb(r) FROM "PageRevision" r WHERE r.id=$1 AND r."pageId"=$2`, revisionID, pageID)
+}
+
+// HandlePageRevisionsList returns metadata only — the editor fetches a body on
+// demand (a page can have a long history and each body is up to 512 KiB).
+func HandlePageRevisionsList(w http.ResponseWriter, r *http.Request) {
+	pageID := r.PathValue("id")
+	if _, e := owned(r, database(r), "Page", pageID, "ownerId"); e != nil {
+		respond(w, 0, nil, e)
+		return
+	}
+	v, e := db.Many(r.Context(), database(r), `SELECT jsonb_build_object(
+		'id',r.id,'version',r.version,'title',r.title,'icon',r.icon,
+		'createdAt',r."createdAt",'length',length(r.content))
+		FROM "PageRevision" r WHERE r."pageId"=$1 ORDER BY r.version DESC`, pageID)
+	respond(w, 200, v, e)
+}
+
+func HandlePageRevisionsGet(w http.ResponseWriter, r *http.Request) {
+	v, e := revisionOwned(r, database(r), r.PathValue("id"), r.PathValue("revisionId"))
+	respond(w, 200, v, e)
+}
+
+// HandlePageRevisionsRestore copies a snapshot into the live page as a new
+// version. It requires the current base version (the same DATA-05 rule as a
+// content save), so restoring while another tab writes is a 409, not a silent
+// overwrite. The restored state itself becomes a history entry.
+func HandlePageRevisionsRestore(w http.ResponseWriter, r *http.Request) {
+	pageID, revisionID := r.PathValue("id"), r.PathValue("revisionId")
+	b, ok := read(w, r)
+	if !ok {
+		return
+	}
+	baseVersion, e := patchVersion(b)
+	if e != nil {
+		respond(w, 0, nil, e)
+		return
+	}
+	var v object
+	e = db.Transaction(r.Context(), database(r), func(tx *sql.Tx) error {
+		if e := lockUser(r, tx); e != nil {
+			return e
+		}
+		current, e := owned(r, tx, "Page", pageID, "ownerId")
+		if e != nil {
+			return e
+		}
+		if stored, _ := current["version"].(float64); int(stored) != baseVersion {
+			return conflict("Page was modified elsewhere; reload to see the latest version")
+		}
+		rev, e := db.One(r.Context(), tx, `SELECT to_jsonb(r) FROM "PageRevision" r WHERE r.id=$1 AND r."pageId"=$2`, revisionID, pageID)
+		if e != nil {
+			return e
+		}
+		if _, e := tx.ExecContext(r.Context(), `UPDATE "Page" SET title=$1,content=$2,icon=$3,version=version+1,"updatedAt"=$4 WHERE id=$5 AND "ownerId"=$6`,
+			str(rev, "title"), str(rev, "content"), rev["icon"], time.Now().UTC(), pageID, user(r)); e != nil {
+			return e
+		}
+		// Restoring content also restores its derived graph. Targets that no
+		// longer exist (or are no longer owned) are ignored by syncPageGraph.
+		if e := syncPageGraph(r.Context(), tx, pageID, user(r), str(rev, "content")); e != nil {
+			return e
+		}
+		if e := capturePageRevision(r, tx, pageID); e != nil {
+			return e
+		}
+		v, e = pageView(r.Context(), tx, pageID, user(r))
+		return e
+	})
+	respond(w, 200, v, e)
+}

internal/handlers/pages.go

@@ -121,6 +121,9 @@ func HandlePagesCreate(w http.ResponseWriter, r *http.Request) {
 				return e
 			}
 		}
+		if e := capturePageRevision(r, tx, d["id"].(string)); e != nil {
+			return e
+		}
 		// Acknowledge the same snapshot the write produced (the update path's
 		// CR-18 discipline), so the 201 already carries links/embeds.
 		v, e = pageView(r.Context(), tx, d["id"].(string), user(r))
@@ -218,6 +221,9 @@ func HandlePagesUpdate(w http.ResponseWriter, r *http.Request) {
 			if e := syncPageGraph(r.Context(), tx, id, user(r), content); e != nil {
 				return e
 			}
+			if e := capturePageRevision(r, tx, id); e != nil {
+				return e
+			}
 		}
 		if bid := str(b, "addBookmarkId"); bid != "" {
 			if _, e := db.One(r.Context(), tx, `SELECT to_jsonb(b) FROM "Bookmark" b WHERE b.id=$1 AND `+db.BookmarkVisible, bid, user(r)); e != nil {
@@ -254,8 +260,15 @@ func HandlePagesBacklinks(w http.ResponseWriter, r *http.Request) {
 }
 func HandlePagesDelete(w http.ResponseWriter, r *http.Request) {
 	// Children are promoted to the top level by the self-FK's SET NULL; a
-	// delete never silently takes nested pages with it.
-	respond(w, 200, OK{true}, remove(r, "Page", r.PathValue("id"), "ownerId"))
+	// delete never silently takes nested pages with it. The page, its history
+	// and its bookmark links are snapshotted for restore.
+	e := db.Transaction(r.Context(), database(r), func(tx *sql.Tx) error {
+		if e := lockUser(r, tx); e != nil {
+			return e
+		}
+		return trashPage(r, tx, r.PathValue("id"))
+	})
+	respond(w, 200, OK{true}, e)
 }
 func HandlePagesMarkdown(w http.ResponseWriter, r *http.Request) {
 	v, e := page(r, r.PathValue("id"))

internal/handlers/trash.go

@@ -0,0 +1,364 @@
+package handlers
+
+import (
+	"database/sql"
+	"encoding/json"
+	"net/http"
+
+	"github.com/andrew/go-computer/internal/db"
+)
+
+// Recoverable deletions (trust phase).
+//
+// Trash stores a private, per-owner JSON snapshot taken in the same
+// transaction as the hard delete. Restoring inserts the intrinsic record and
+// owner-scoped relationships, but deliberately NOT access grants:
+//   - bookmark isPublic is forced false and bookmark/tag shares are not
+//     snapshotted, so a restored bookmark never resurrects a public link or a
+//     share removed while it was in the trash;
+//   - collection shares are not snapshotted;
+//   - server-driven watcher rows are not snapshotted.
+// Contextual collection memberships and page links are owner-scoped data and
+// are restored when their parent still exists.
+
+func jsonSnapshot(v any) (string, error) {
+	raw, e := json.Marshal(v)
+	return string(raw), e
+}
+
+func addTrash(r *http.Request, tx *sql.Tx, kind, originalID string, data object) error {
+	raw, e := jsonSnapshot(data)
+	if e != nil {
+		return e
+	}
+	_, e = db.Insert(r.Context(), tx, "Trash", object{
+		"id": db.NewID(), "ownerId": user(r), "type": kind,
+		"originalId": originalID, "data": raw,
+	})
+	return e
+}
+
+func deleteOwnedRow(r *http.Request, tx *sql.Tx, table, id, ownerCol string, deleted *int64) error {
+	res, e := tx.ExecContext(r.Context(), `DELETE FROM `+db.Quote(table)+` WHERE id=$1 AND `+db.Quote(ownerCol)+`=$2`, id, user(r))
+	if e != nil {
+		return e
+	}
+	n, _ := res.RowsAffected()
+	if n == 0 {
+		return db.ErrNotFound
+	}
+	if deleted != nil {
+		*deleted = n
+	}
+	return nil
+}
+
+// --- delete snapshots -----------------------------------------------------
+
+func trashBookmark(r *http.Request, tx *sql.Tx, id string) error {
+	row, e := owned(r, tx, "Bookmark", id, "ownerId")
+	if e != nil {
+		return e
+	}
+	tags, e := db.Many(r.Context(), tx, `SELECT jsonb_build_object('tagId',bt."tagId") FROM "BookmarkTag" bt JOIN "Tag" t ON t.id=bt."tagId" WHERE bt."bookmarkId"=$1 AND (t."ownerId"=$2 OR EXISTS(SELECT 1 FROM "TagShare" s WHERE s."tagId"=t.id AND s."userId"=$2))`, id, user(r))
+	if e != nil {
+		return e
+	}
+	pageLinks, e := db.Many(r.Context(), tx, `SELECT jsonb_build_object('pageId',pb."pageId",'position',pb.position) FROM "PageBookmark" pb JOIN "Page" p ON p.id=pb."pageId" WHERE pb."bookmarkId"=$1 AND p."ownerId"=$2`, id, user(r))
+	if e != nil {
+		return e
+	}
+	collectionItems, e := db.Many(r.Context(), tx, `SELECT jsonb_build_object('id',ci.id,'collectionId',ci."collectionId",'bookmarkId',ci."bookmarkId",'propertyValues',ci."propertyValues",'position',ci.position,'version',ci.version,'addedAt',ci."addedAt",'updatedAt',ci."updatedAt") FROM "CollectionItem" ci JOIN "Collection" c ON c.id=ci."collectionId" WHERE ci."bookmarkId"=$1 AND c."ownerId"=$2`, id, user(r))
+	if e != nil {
+		return e
+	}
+	if e := addTrash(r, tx, "bookmark", id, object{
+		"bookmark": row, "tags": tags, "pageLinks": pageLinks, "collectionItems": collectionItems,
+	}); e != nil {
+		return e
+	}
+	return deleteOwnedRow(r, tx, "Bookmark", id, "ownerId", nil)
+}
+
+func trashPage(r *http.Request, tx *sql.Tx, id string) error {
+	row, e := owned(r, tx, "Page", id, "ownerId")
+	if e != nil {
+		return e
+	}
+	bookmarks, e := db.Many(r.Context(), tx, `SELECT jsonb_build_object('bookmarkId',pb."bookmarkId",'position',pb.position) FROM "PageBookmark" pb WHERE pb."pageId"=$1`, id)
+	if e != nil {
+		return e
+	}
+	revisions, e := db.Many(r.Context(), tx, `SELECT to_jsonb(r) FROM "PageRevision" r WHERE r."pageId"=$1 ORDER BY r.version`, id)
+	if e != nil {
+		return e
+	}
+	if e := addTrash(r, tx, "page", id, object{"page": row, "bookmarks": bookmarks, "revisions": revisions}); e != nil {
+		return e
+	}
+	return deleteOwnedRow(r, tx, "Page", id, "ownerId", nil)
+}
+
+func trashCollection(r *http.Request, tx *sql.Tx, id string) error {
+	row, e := owned(r, tx, "Collection", id, "ownerId")
+	if e != nil {
+		return e
+	}
+	properties, e := db.Many(r.Context(), tx, `SELECT to_jsonb(p) FROM "CollectionProperty" p WHERE p."collectionId"=$1 ORDER BY p.position,p.id`, id)
+	if e != nil {
+		return e
+	}
+	views, e := db.Many(r.Context(), tx, `SELECT to_jsonb(v) FROM "CollectionView" v WHERE v."collectionId"=$1 ORDER BY v.position,v.id`, id)
+	if e != nil {
+		return e
+	}
+	items, e := db.Many(r.Context(), tx, `SELECT to_jsonb(ci) FROM "CollectionItem" ci WHERE ci."collectionId"=$1 ORDER BY ci.position,ci.id`, id)
+	if e != nil {
+		return e
+	}
+	if e := addTrash(r, tx, "collection", id, object{
+		"collection": row, "properties": properties, "views": views, "items": items,
+	}); e != nil {
+		return e
+	}
+	return deleteOwnedRow(r, tx, "Collection", id, "ownerId", nil)
+}
+
+// --- restore --------------------------------------------------------------
+
+func objectValue(v any) object {
+	if m, ok := v.(map[string]any); ok {
+		return m
+	}
+	return nil
+}
+
+func objectList(v any) []object {
+	arr, _ := v.([]any)
+	out := make([]object, 0, len(arr))
+	for _, x := range arr {
+		if m, ok := x.(map[string]any); ok {
+			out = append(out, m)
+		}
+	}
+	return out
+}
+
+func insertSnapshot(r *http.Request, tx *sql.Tx, table, kind string, row object) error {
+	raw, e := jsonSnapshot(row)
+	if e != nil {
+		return e
+	}
+	_, e = tx.ExecContext(r.Context(), `INSERT INTO `+db.Quote(table)+` SELECT * FROM jsonb_populate_record(NULL::`+db.Quote(table)+`, $1::jsonb)`, raw)
+	return e
+}
+
+func restoreBookmark(r *http.Request, tx *sql.Tx, data object) (string, error) {
+	row := objectValue(data["bookmark"])
+	if row == nil {
+		return "", bad("Trash entry is damaged")
+	}
+	id := str(row, "id")
+	// Restore access decisions to their safe default. A public link or a
+	// direct share is a grant, not intrinsic content.
+	row["isPublic"] = false
+	for _, pair := range [][2]string{{"contactId", "Contact"}, {"kanbanColumnId", "KanbanColumn"}} {
+		if ref := str(row, pair[0]); ref != "" {
+			col := "userId"
+			var exists bool
+			if e := tx.QueryRowContext(r.Context(), `SELECT EXISTS(SELECT 1 FROM `+db.Quote(pair[1])+` WHERE id=$1 AND `+db.Quote(col)+`=$2)`, ref, user(r)).Scan(&exists); e != nil {
+				return "", e
+			}
+			if !exists {
+				row[pair[0]] = nil
+			}
+		}
+	}
+	if e := insertSnapshot(r, tx, "Bookmark", "bookmark", row); e != nil {
+		return "", e
+	}
+	for _, t := range objectList(data["tags"]) {
+		tagID := str(t, "tagId")
+		var exists bool
+		if e := tx.QueryRowContext(r.Context(), `SELECT EXISTS(SELECT 1 FROM "Tag" t WHERE t.id=$1 AND (t."ownerId"=$2 OR EXISTS(SELECT 1 FROM "TagShare" s WHERE s."tagId"=t.id AND s."userId"=$2)))`, tagID, user(r)).Scan(&exists); e != nil {
+			return "", e
+		}
+		if exists {
+			if _, e := tx.ExecContext(r.Context(), `INSERT INTO "BookmarkTag"("bookmarkId","tagId") VALUES($1,$2) ON CONFLICT DO NOTHING`, id, tagID); e != nil {
+				return "", e
+			}
+		}
+	}
+	for _, l := range objectList(data["pageLinks"]) {
+		var exists bool
+		if e := tx.QueryRowContext(r.Context(), `SELECT EXISTS(SELECT 1 FROM "Page" WHERE id=$1 AND "ownerId"=$2)`, str(l, "pageId"), user(r)).Scan(&exists); e != nil {
+			return "", e
+		}
+		if !exists {
+			continue
+		}
+		if _, e := tx.ExecContext(r.Context(), `INSERT INTO "PageBookmark"("pageId","bookmarkId",position) VALUES($1,$2,$3) ON CONFLICT DO NOTHING`, str(l, "pageId"), id, intFieldValue(l, "position")); e != nil {
+			return "", e
+		}
+	}
+	for _, item := range objectList(data["collectionItems"]) {
+		var exists bool
+		if e := tx.QueryRowContext(r.Context(), `SELECT EXISTS(SELECT 1 FROM "Collection" WHERE id=$1 AND "ownerId"=$2)`, str(item, "collectionId"), user(r)).Scan(&exists); e != nil {
+			return "", e
+		}
+		if !exists {
+			continue
+		}
+		if e := insertSnapshot(r, tx, "CollectionItem", "collectionItem", item); e != nil {
+			return "", e
+		}
+	}
+	return id, nil
+}
+
+func intFieldValue(b object, key string) int {
+	if f, ok := b[key].(float64); ok {
+		return int(f)
+	}
+	return 0
+}
+
+func restorePage(r *http.Request, tx *sql.Tx, data object) (string, error) {
+	row := objectValue(data["page"])
+	if row == nil {
+		return "", bad("Trash entry is damaged")
+	}
+	id := str(row, "id")
+	parent, e := pageParent(r.Context(), tx, id, user(r), row["parentId"])
+	if e != nil {
+		// A parent deleted while this page sat in the trash simply promotes
+		// the restored page to the top level.
+		if _, ok := e.(clientError); !ok {
+			return "", e
+		}
+		parent = nil
+	}
+	row["parentId"] = parent
+	if e := insertSnapshot(r, tx, "Page", "page", row); e != nil {
+		return "", e
+	}
+	for _, l := range objectList(data["bookmarks"]) {
+		var visible bool
+		if e := tx.QueryRowContext(r.Context(), `SELECT EXISTS(SELECT 1 FROM "Bookmark" b WHERE b.id=$1 AND `+db.BookmarkVisible+`)`, str(l, "bookmarkId"), user(r)).Scan(&visible); e != nil {
+			return "", e
+		}
+		if !visible {
+			continue
+		}
+		if _, e := tx.ExecContext(r.Context(), `INSERT INTO "PageBookmark"("pageId","bookmarkId",position) VALUES($1,$2,$3) ON CONFLICT DO NOTHING`, id, str(l, "bookmarkId"), intFieldValue(l, "position")); e != nil {
+			return "", e
+		}
+	}
+	for _, rev := range objectList(data["revisions"]) {
+		if e := insertSnapshot(r, tx, "PageRevision", "pageRevision", rev); e != nil {
+			return "", e
+		}
+	}
+	if e := syncPageGraph(r.Context(), tx, id, user(r), str(row, "content")); e != nil {
+		return "", e
+	}
+	// A restore is a new trust event: bump the revision and record it, so the
+	// state that came back from the trash is itself auditable.
+	if _, e := tx.ExecContext(r.Context(), `UPDATE "Page" SET version=version+1,"updatedAt"=now() WHERE id=$1 AND "ownerId"=$2`, id, user(r)); e != nil {
+		return "", e
+	}
+	if e := capturePageRevision(r, tx, id); e != nil {
+		return "", e
+	}
+	return id, nil
+}
+
+func restoreCollection(r *http.Request, tx *sql.Tx, data object) (string, error) {
+	row := objectValue(data["collection"])
+	if row == nil {
+		return "", bad("Trash entry is damaged")
+	}
+	id := str(row, "id")
+	if e := insertSnapshot(r, tx, "Collection", "collection", row); e != nil {
+		return "", e
+	}
+	for _, prop := range objectList(data["properties"]) {
+		if e := insertSnapshot(r, tx, "CollectionProperty", "collectionProperty", prop); e != nil {
+			return "", e
+		}
+	}
+	for _, view := range objectList(data["views"]) {
+		if e := insertSnapshot(r, tx, "CollectionView", "collectionView", view); e != nil {
+			return "", e
+		}
+	}
+	for _, item := range objectList(data["items"]) {
+		var visible bool
+		if e := tx.QueryRowContext(r.Context(), `SELECT EXISTS(SELECT 1 FROM "Bookmark" b WHERE b.id=$1 AND `+db.BookmarkVisible+`)`, str(item, "bookmarkId"), user(r)).Scan(&visible); e != nil {
+			return "", e
+		}
+		if !visible {
+			continue
+		}
+		if e := insertSnapshot(r, tx, "CollectionItem", "collectionItem", item); e != nil {
+			return "", e
+		}
+	}
+	return id, nil
+}
+
+// --- HTTP surfaces --------------------------------------------------------
+
+func HandleTrashList(w http.ResponseWriter, r *http.Request) {
+	v, e := db.Many(r.Context(), database(r), `SELECT jsonb_build_object(
+		'id',t.id,'type',t.type,'originalId',t."originalId",'deletedAt',t."deletedAt",
+		'title',COALESCE(
+			NULLIF(t.data->'bookmark'->>'title',''),
+			t.data->'bookmark'->>'url',
+			NULLIF(t.data->'page'->>'title',''),
+			t.data->'collection'->>'name',
+			'Untitled'))
+		FROM "Trash" t WHERE t."ownerId"=$1 ORDER BY t."deletedAt" DESC,t.id`, user(r))
+	respond(w, 200, v, e)
+}
+
+func HandleTrashRestore(w http.ResponseWriter, r *http.Request) {
+	id := r.PathValue("id")
+	var kind, originalID string
+	e := db.Transaction(r.Context(), database(r), func(tx *sql.Tx) error {
+		if e := lockUser(r, tx); e != nil {
+			return e
+		}
+		entry, e := db.One(r.Context(), tx, `SELECT to_jsonb(t) FROM "Trash" t WHERE t.id=$1 AND t."ownerId"=$2 FOR UPDATE`, id, user(r))
+		if e != nil {
+			return e
+		}
+		kind, originalID = str(entry, "type"), str(entry, "originalId")
+		data := objectValue(entry["data"])
+		if data == nil {
+			return bad("Trash entry is damaged")
+		}
+		switch kind {
+		case "bookmark":
+			_, e = restoreBookmark(r, tx, data)
+		case "page":
+			_, e = restorePage(r, tx, data)
+		case "collection":
+			_, e = restoreCollection(r, tx, data)
+		default:
+			return bad("Unknown trash entry type")
+		}
+		if e != nil {
+			return e
+		}
+		_, e = tx.ExecContext(r.Context(), `DELETE FROM "Trash" WHERE id=$1 AND "ownerId"=$2`, id, user(r))
+		return e
+	})
+	respond(w, 200, object{"ok": true, "type": kind, "id": originalID}, e)
+}
+
+func HandleTrashPurge(w http.ResponseWriter, r *http.Request) {
+	// Permanent removal is explicit (the default delete moves to the trash).
+	_, e := database(r).ExecContext(r.Context(), `DELETE FROM "Trash" WHERE id=$1 AND "ownerId"=$2`, r.PathValue("id"), user(r))
+	respond(w, 200, OK{true}, e)
+}

internal/handlers/unshare.go

@@ -20,6 +20,9 @@ func HandleBookmarkUnshare(w http.ResponseWriter, r *http.Request) {
 func HandleTagUnshare(w http.ResponseWriter, r *http.Request) {
 	unshare(w, r, "Tag", "TagShare", "tagId")
 }
+func HandleCollectionUnshare(w http.ResponseWriter, r *http.Request) {
+	unshare(w, r, "Collection", "CollectionShare", "collectionId")
+}
 func HandleSharedDateDelete(w http.ResponseWriter, r *http.Request) {
 	respond(w, 200, OK{true}, remove(r, "SharedDate", r.PathValue("id"), "creatorId"))
 }