Address code review findings across API, web and deployment
release gate / check (push) Failing after 6m43s
release gate / check (push) Failing after 6m43s
High severity: - wire TRUSTED_PROXY through Compose/deploy/docs and warn at web startup - bucket public rate limits on effective client IP, add per-bookmark budget, and forward the signed browser identity from the share page - disable first-run bootstrap in server deployments and document seeding - serialize last-admin demotion in one advisory-locked transaction Medium/low: - cap and batch share recipient inserts - add a shared outbound budget for preview/CardDAV/IMAP/signal work - pin CardDAV dials to 443 and bound IMAP logout - fix rightward kanban column drags and normalize cards on column delete - classify backend outages in auth guards, add request timeouts and an error boundary, remove the dead login route, surface throttling - enforce pinned/unpinned page reorder grouping server-side - avoid preview work for stale bookmark versions; drop duplicate dialog fetch - sequence-guard collection/tag/calendar/quick-find loads - validate property config and fix MULTI_SELECT/DATE filter inputs - document index maintenance; apply same-origin check to sign-out - trim signup names, unique shared dates and kanban keys (migration 010), reset reference cache on identity changes, hide OIDC issuer, return 413 for oversized direct bodies, escape Markdown link destinations - remove dead template files and duplicate test helper Verified with go build/vet, full PostgreSQL race suite, db convergence, tsc, both ESLint configs and a Next production build.
This commit is contained in:
@@ -47,6 +47,10 @@ services:
|
||||
ENCRYPTION_KEY: ${ENCRYPTION_KEY:-}
|
||||
NEXTAUTH_URL: ${NEXTAUTH_URL:-http://localhost:3000}
|
||||
ADMIN_EMAILS: ${ADMIN_EMAILS:-}
|
||||
# Review H-3: these must reach the Go container, not just .env. An empty
|
||||
# value keeps local defaults (bootstrap enabled, signup open).
|
||||
ALLOW_BOOTSTRAP_SIGNUP: ${ALLOW_BOOTSTRAP_SIGNUP:-}
|
||||
SIGNUP_ENABLED: ${SIGNUP_ENABLED:-}
|
||||
COOKIE_SECURE: ${COOKIE_SECURE:-}
|
||||
OIDC_ISSUER: ${OIDC_ISSUER:-}
|
||||
OIDC_CLIENT_ID: ${OIDC_CLIENT_ID:-}
|
||||
@@ -73,6 +77,11 @@ services:
|
||||
NEXTAUTH_SECRET: ${AUTH_SECRET}
|
||||
NEXTAUTH_URL: ${NEXTAUTH_URL:-http://localhost:3000}
|
||||
AUTH_TRUST_HOST: "true"
|
||||
# Review H-1: opt in only when a proxy in front of web pins X-Real-IP
|
||||
# (the shipped nginx template does; scripts/server-deploy.sh sets it).
|
||||
# Leave unset when port 3000 is browser-reachable directly, otherwise
|
||||
# clients can spoof their rate-limit identity.
|
||||
TRUSTED_PROXY: ${TRUSTED_PROXY:-}
|
||||
OIDC_ISSUER: ${OIDC_ISSUER:-}
|
||||
OIDC_CLIENT_ID: ${OIDC_CLIENT_ID:-}
|
||||
OIDC_CLIENT_SECRET: ${OIDC_CLIENT_SECRET:-}
|
||||
|
||||
Reference in New Issue
Block a user